Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to 1ES PT #1503

Merged
merged 19 commits into from
Jun 14, 2024
Merged

build: update to 1ES PT #1503

merged 19 commits into from
Jun 14, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented May 29, 2024

Description

Moving to 1ES PT.
Added new pipelines referencing 1ES pipeline templates and using 1ES hosted pools.

  • code mirror pipeline
  • official build
  • public build
  • E2E tests

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria changed the title build: code mirror template for worker build: update to 1ES PT Jun 3, 2024
@hallvictoria hallvictoria marked this pull request as ready for review June 5, 2024 23:38
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.37%. Comparing base (2f65a2f) to head (a5dab45).
Report is 3 commits behind head on dev.

Current head a5dab45 differs from pull request most recent head 3dd05b5

Please upload reports for the commit 3dd05b5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1503      +/-   ##
==========================================
+ Coverage   30.48%   31.37%   +0.88%     
==========================================
  Files          36       36              
  Lines        2293     2327      +34     
  Branches      345      346       +1     
==========================================
+ Hits          699      730      +31     
- Misses       1592     1595       +3     
  Partials        2        2              
Flag Coverage Δ
unittests 31.37% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eng/ci/official-build.yml Outdated Show resolved Hide resolved
eng/ci/official-build.yml Outdated Show resolved Hide resolved
eng/ci/public-build.yml Show resolved Hide resolved
eng/templates/official/jobs/ci-e2e-tests.yml Outdated Show resolved Hide resolved
@manvkaur
Copy link
Contributor

Please also add link to public pipeline that is running.

eng/ci/public-build.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@manvkaur manvkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with suggestion so that you are not blocked on me to create the pipelines, just take a look at publishvstsfeed, if it is needed in common template

eng/ci/official-build.yml Outdated Show resolved Hide resolved
eng/ci/public-build.yml Outdated Show resolved Hide resolved
eng/templates/jobs/build.yml Outdated Show resolved Hide resolved
eng/ci/official-build.yml Show resolved Hide resolved
eng/templates/official/jobs/ci-e2e-tests.yml Outdated Show resolved Hide resolved
@hallvictoria hallvictoria merged commit c244569 into dev Jun 14, 2024
60 of 61 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/worker-code-mirror branch June 14, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants