Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change current working directory when reloading environment variables #613

Merged
merged 7 commits into from
Feb 5, 2020

Conversation

Hazhzeng
Copy link
Contributor

@Hazhzeng Hazhzeng commented Jan 29, 2020

This can solve the issue when user tries to import files in the function app directory.
They should no longer require to use os.path.abspath for deriving the file paths.

Added rollback flag PYTHON_ROLLBACK_CWD_PATH for disabling the cwd change behavior

@Hazhzeng
Copy link
Contributor Author

As discussed with @AnatoliB,

  1. We need to add a rollback flag for this feature in case it breaks our customer
  2. We need to announce the change we make in this change

@Hazhzeng Hazhzeng force-pushed the hazeng/resolve-import branch from c405b74 to 7541899 Compare January 30, 2020 23:56
@Hazhzeng Hazhzeng requested a review from AnatoliB January 31, 2020 01:38
@Hazhzeng
Copy link
Contributor Author

Hey @AnatoliB, this PR is ready for review. Feel free to come to me for additional questions. Thanks in advance.

azure_functions_worker/utils/common.py Outdated Show resolved Hide resolved
azure_functions_worker/dispatcher.py Outdated Show resolved Hide resolved
Copy link

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hazhzeng Hazhzeng merged commit aa4bea9 into dev Feb 5, 2020
@Hazhzeng Hazhzeng deleted the hazeng/resolve-import branch April 29, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants