Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for 3.9 along with nit fixes #751

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Changes for 3.9 along with nit fixes #751

merged 1 commit into from
Oct 6, 2020

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Oct 4, 2020

Description

  • Fixing ''' to """ string for PyDocs
  • Adding critical logs to hit that code path
  • Marking some tests as flaky to allow it to be rerun.
  • Adding some sleep when starting the test host/worker to allow it to start on mac.
  • With asycio.Task.creat_task() now removed from Python 3.9, refactored it to work for 3.6-3.9.
  • Bump grpcio and grpcio-tools from 1.26.0 to 1.32.0.

Fixes #742

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr
Fixing pydoc comments and flaky tests
5b9a16e 
* Fixing ''' to """ string for PyDocs
* Adding critical logs to hit that code path
* Marking some tests as flaky to allow it to be rerun.
* Adding some sleep when starting the test host/worker to allow it to start on mac.
* Bump grpcio from 1.26.0 to 1.32.0.
@vrdmr vrdmr changed the title Changes for 3.9 along with fixing pydoc comments and marking flaky tests Changes for 3.9 along with nit fixes Oct 4, 2020
@berndverst
Copy link
Member

Thanks for doing this @vrdmr. 3.9 was released today!

@vrdmr vrdmr merged commit c465de4 into dev Oct 6, 2020
@vrdmr vrdmr deleted the vameru/nit-cleanup-flaky-tests branch October 6, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hazhzeng Hazhzeng Hazhzeng approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Python 3.9 support
3 participants
@vrdmr @berndverst @Hazhzeng