-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PYTHON_THREADPOOL_THREAD_COUNT not apply to Linux Conusmption #774
Conversation
Known CI issue in Python Worker CI, Python 3.9 windows will fail here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
some nits
Hi @vrdmr Any idea when this fix is going into production? We have been working on understanding this behaviour for weeks and I just stumbled over this pull request by accident ... Cheers, Casper |
Its already in Linux Premium. It is rolling out in Linux Consumption as we speak. Should be everywhere by the middle of next week. |
Hi @anirudhgarg I just tried consumption plan in west europe and I am still unable to go beyond a single thread. Do you have any documentation on how this feature is supposed to work, ideally with working code examples? Cheers, Casper |
Hi @vrdmr and @anirudhgarg Any update on this? Documentation or working code examples ... Cheers, Casper |
Hi @casper-79, @stefanushinardi is working on the documentation update (PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/139057) and this should go in soon. Once that PR is in, the new perf-guidance page for Python function apps should light-up immediately. Please let us know if you are looking for something specific. Thanks. |
Thanks @vrdmr Unfortunately, there seems to be an error with the PR link you provided (404). Is the performance guidance page you are referring to something that will show up in the Azure portal? Cheers, Casper |
@casper-79 I think you might be asking for specific instructions on how to use this. (You might not have access to the Azure Docs PR) Basically you just add an app setting: PYTHON_THREADPOOL_THREAD_COUNT and set it to the number of threads that you want. |
@anirudhgarg Any idea when the documentation will be finished? The link currently leads to a 404. |
@jokoso - The docs PR was merged today and the scaling-and-performance section should update soon.
|
Description
This is a fix to an issue where in Linux Consumption, the PYTHON_THREADPOOL_THREAD_COUNT app setting is not properly applied to an instance during specialization. This will make the Python worker in Linux Consumption ignore the app setting, making the maximum worker count always to 1.
Miscellaneous:
@patch
decorator in unittests to use with patch() syntax, since previously, it suppresses all assertion exceptions in async test cases.PR information
Quality of Code and Contribution Guidelines