Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sbom generator task in the pipeline #918

Merged
merged 13 commits into from
Dec 1, 2021
Merged

add sbom generator task in the pipeline #918

merged 13 commits into from
Dec 1, 2021

Conversation

arroyc
Copy link
Contributor

@arroyc arroyc commented Nov 24, 2021 •
edited
Loading

https://azfunc.visualstudio.com/AzurePythonFx/_workitems/edit/1412

As title is mentioned ..

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@arroyc arroyc mentioned this pull request Nov 24, 2021
Closed
5 tasks
@arroyc arroyc force-pushed the arroyc/sbom-pipeline branch from fc48370 to c5601ed Compare November 24, 2021 18:53
arroyc
arroyc commented Nov 24, 2021
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
arroyc
arroyc commented Nov 24, 2021
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
@arroyc arroyc force-pushed the arroyc/sbom-pipeline branch from b9d0f70 to 22bb2a5 Compare November 24, 2021 23:19
@arroyc arroyc force-pushed the arroyc/sbom-pipeline branch 14 times, most recently from 3051827 to 4baeb52 Compare November 29, 2021 02:38
@arroyc arroyc force-pushed the arroyc/sbom-pipeline branch from 4baeb52 to 157e807 Compare November 29, 2021 03:30
vrdmr
vrdmr requested changes Nov 30, 2021
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
@arroyc arroyc force-pushed the arroyc/sbom-pipeline branch from 569562e to a3f6343 Compare November 30, 2021 18:50
@gavin-aguiar
Copy link
Contributor

Are we not adding a validator task?

@arroyc
Copy link
Contributor Author

arroyc commented Nov 30, 2021

Are we not adding a validator task?

not now

@gavin-aguiar gavin-aguiar reopened this Nov 30, 2021
@gavin-aguiar
Copy link
Contributor

Are we not adding a validator task?

not now

Got it. Can you update the PR title to remove the validator task?

@arroyc arroyc changed the title add sbom generator and validator task add sbom generator task in the pipeline Nov 30, 2021
@arroyc arroyc merged commit 93738f1 into dev Dec 1, 2021
@arroyc arroyc deleted the arroyc/sbom-pipeline branch December 1, 2021 20:24
@arroyc arroyc mentioned this pull request Dec 2, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-aguiar gavin-aguiar gavin-aguiar left review comments

@vrdmr vrdmr vrdmr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arroyc @gavin-aguiar @vrdmr