Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to enable debug logging tests #943

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add comments to enable debug logging tests #943

merged 1 commit into from
Jan 19, 2022

Conversation

YunchuWang
Copy link
Member

Description

Fixes #
Add comments to enable debug logging tests
Rename TestLogFilteringFunctions class

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

gavin-aguiar
gavin-aguiar approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@gavin-aguiar gavin-aguiar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit.: Just add an empty line after the comment and before /classmethod

@YunchuWang YunchuWang merged commit ae21607 into dev Jan 19, 2022
@YunchuWang YunchuWang deleted the wangbill/enable-debug-logging-comment-update branch January 19, 2022 00:10
@vrdmr
Copy link
Member

vrdmr commented Feb 1, 2022

Child of #939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-aguiar gavin-aguiar gavin-aguiar approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YunchuWang @vrdmr @gavin-aguiar @wangbill1993