Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address telemetry loss in very short intervals #585

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

YingXue
Copy link
Member

@YingXue YingXue commented Nov 29, 2022

Address two root causes of events/telemetry data loss.

  1. Websocket was pushing messages to client too frequently and is causing ui not able to pick up all messages fast enough.
  2. EnqueueTimeUtc is not realiable enough to check duplicates as event hub can return messages not always in order.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit tests?
  • Have all unit tests passed locally? (by running npm run test command)
  • Have you updated the README.md with new screenshots if significant changes have been made?
  • Have you update the package version if the current version in package.json is not higher than the version released?

@YingXue YingXue changed the title check events dup using sequence number not enqueuetime address telemetry loss in very short intervals Nov 29, 2022
Elsie4ever
Elsie4ever previously approved these changes Nov 29, 2022
chieftn
chieftn previously approved these changes Nov 29, 2022
src/app/devices/deviceEvents/components/deviceEvents.tsx Outdated Show resolved Hide resolved
@YingXue YingXue dismissed stale reviews from chieftn and Elsie4ever via 364638e November 29, 2022 23:24
@YingXue YingXue merged commit 7f1d0b8 into Azure:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants