Update "dotnet build" CLI command to treat warning as error #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
approved these changes
Feb 2, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
commented
Feb 2, 2021
| @@ -120,9 +125,9 @@ Function BuildProject($path, $message) | |||
| } | |||
| } | |||
|
|
|||
| & dotnet build $projectPath --verbosity $verbosity --configuration $configuration | |||
| & dotnet build $projectPath --verbosity $verbosity --configuration $configuration -warnAsError | Tee-Object ./buildlog.txt | |||
There was a problem hiding this comment.
what we are doing here is routing the command output to a file and searching the text for the string "Build FAILED".
This is required because:
- dotnet build correctly marks the build as failed (on passing the flag -warnAsError)
- powershell does not report the LASTEXITCODE as not 0 (this behavior is not deterministic, it works sometimes, doesn't at other times)
Linked github discussions see this as an issue in the .NET sdk: https://github.com/dotnet/installer/issues/1708
See two consecutive runs returning different results:
PS S:\csharp\azure> . 's:\csharp\azure\build.ps1' -clean -build -configuration DEBUG
Local packages being used for testing: False
BUILD: --- Azure IoT C# SDK Solution DEBUG ---
cleaning
Microsoft (R) Build Engine version 16.8.3+39993bd9d for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
Microsoft (R) Build Engine version 16.8.3+39993bd9d for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
Build FAILED.
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
0 Warning(s)
4 Error(s)
Time Elapsed 00:00:20.48
LASTEXITCODE: 1
Time Elapsed 00:00:23.7478540
Build failed (Build failed: BUILD: --- Azure IoT C# SDK Solution DEBUG ---)
PS S:\csharp\azure> . 's:\csharp\azure\build.ps1' -clean -build -configuration DEBUG
Local packages being used for testing: False
BUILD: --- Azure IoT C# SDK Solution DEBUG ---
cleaning
Microsoft (R) Build Engine version 16.8.3+39993bd9d for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
Microsoft (R) Build Engine version 16.8.3+39993bd9d for .NET
Copyright (C) Microsoft Corporation. All rights reserved.
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
Build FAILED.
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
S:\csharp\azure\iothub\device\src\Edge\EdgeModuleClientFactory.cs(96,34): error CA2000: Call System.IDisposable.Dispose on object created by 'new ModuleAuthenticationWithHsm(signatureProvider, deviceId, moduleId, generationId)' before all references to it are out of scope [S:\csharp\azure\iothub\device\src\Microsoft.Azure.Devices.Client.csproj]
0 Warning(s)
4 Error(s)
Time Elapsed 00:00:22.52
LASTEXITCODE: 0
Time Elapsed 00:00:25.4949819
Build succeeded.
abhipsaMisra
force-pushed
the
abmisr/build
branch
from
ac4a51a
to
eafac91
Compare
abhipsaMisra
force-pushed
the
abmisr/build
branch
from
eafac91
to
e61ac55
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vinagesh
approved these changes
Feb 2, 2021
|
The pipeline is expected to fail, since we have a warning pending: #1768 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
requested review from
azabbasi,
barustum,
bikamani,
jamdavi and
timtay-microsoft
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.