New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Await completion of refresh loop #3021

Merged

abhipsaMisra merged 3 commits into main from abmisr/awaitLoop

Dec 19, 2022

Member

abhipsaMisra commented Dec 13, 2022 •

edited

Loading

Cont. of #2935 .

This PR mainly updates the code to stop the sas token refresh loop once CloseAsync() is called, and also as a part of cleanup actions.

wip

a2d14e1

abhipsaMisra requested review from drwill-ms, timtay-microsoft, andyk-ms, brycewang-microsoft, tmahmood-microsoft, ngastelum-ms, patilsnr and schoims as code owners

December 13, 2022 22:55

abhipsaMisra added 2 commits

December 18, 2022 23:01


          Updates to await loop (#3038)

23a8fb2


          null check

142aeab

abhipsaMisra commented

View reviewed changes

iothub/device/src/Transport/Amqp/AmqpAuthenticationRefresher.cs Show resolved Hide resolved

abhipsaMisra commented

View reviewed changes

iothub/device/src/Transport/Amqp/AmqpConnectionHolder.cs Show resolved Hide resolved

abhipsaMisra commented

View reviewed changes

iothub/device/src/Transport/Amqp/AmqpUnit.cs Show resolved Hide resolved

abhipsaMisra commented

View reviewed changes

iothub/device/src/Transport/Amqp/AmqpUnit.cs Show resolved Hide resolved

abhipsaMisra commented

View reviewed changes

iothub/device/src/Transport/Amqp/AmqpUnit.cs Show resolved Hide resolved

abhipsaMisra commented

View reviewed changes

iothub/device/src/Transport/Amqp/AmqpUnit.cs Show resolved Hide resolved

abhipsaMisra commented

View reviewed changes

iothub/device/src/Transport/Amqp/AmqpUnit.cs Show resolved Hide resolved

patilsnr approved these changes

View reviewed changes

andyk-ms approved these changes

View reviewed changes

abhipsaMisra merged commit 297bee8 into main

abhipsaMisra deleted the abmisr/awaitLoop branch

December 19, 2022 18:55

abhipsaMisra added a commit that referenced this pull request


          Await completion of refresh loop (#3021)

d89970a

This was referenced Dec 19, 2022

Bring amqp sas token refresh cleanup logic to LTS #3039

Merged

Address corner cases around sas token refresh loop cleanup #3041

Merged

abhipsaMisra added a commit that referenced this pull request


          Bring amqp sas token refresh cleanup logic to LTS (#3039)

5a2111b

* Cancel amqp token refresher as a part of transport cleanup (#2935)

* Await completion of refresh loop (#3021)

brycewang-microsoft mentioned this pull request

Version bump for release on main #3314

Merged

timstewartm pushed a commit to timstewartm/azure-iot-sdk-csharp that referenced this pull request


          Await completion of refresh loop (Azure#3021)

7bf6893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

patilsnr patilsnr approved these changes

andyk-ms andyk-ms approved these changes

drwill-ms Awaiting requested review from drwill-ms

timtay-microsoft Awaiting requested review from timtay-microsoft timtay-microsoft is a code owner

brycewang-microsoft Awaiting requested review from brycewang-microsoft

tmahmood-microsoft Awaiting requested review from tmahmood-microsoft

ngastelum-ms Awaiting requested review from ngastelum-ms

schoims Awaiting requested review from schoims

Labels

None yet