-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsubscribe from connection loss events when closing service client AMQP connection #3237
Conversation
…MQP connection There is no reason to notify users that the connection was lost when they are actively trying to close the connection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update the E2E test that I added to ensure the error processor gets called. I'd suggest changing it to ensuring it does NOT get called after a call to CloseAsync, and consider adding another test to ensure it does get called, maybe if the user code throws in the FileUploadNotificationProcessor callback?
Sure, I'll do that, too. I'm also working on a proper "reconnection" sample for these AMQP service clients. Edit: I'll save the sample for another PR to keep this one focused. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There is no reason to notify users that the connection was lost when they are actively trying to close the connection.
I also made the other callbacks in these AMQP using clients work asynchronously just like #3224 did for the file upload notification processor callbacks.