Connection state management #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
abhipsaMisra
commented
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
drwill-ms
reviewed
Apr 7, 2023
abhipsaMisra
commented
Apr 7, 2023
|
|
||
| // The retryAttemptsExhausted flag differentiates between calling this method while still retrying | ||
| // vs calling this when no more retry attempts are being made. | ||
| private void HandleConnectionStatusExceptions(Exception exception, bool retryAttemptsExhausted = false) |
There was a problem hiding this comment.
"retryAttemptsExhausted" is never being passed as false right now. Should it?
abhipsaMisra
commented
Apr 7, 2023
| } | ||
| } | ||
|
|
||
| public override async Task<DateTime> RefreshSasTokenAsync(CancellationToken cancellationToken) |
There was a problem hiding this comment.
Is this chained properly and does it get cancelled if CloseAsync() is called?
abhipsaMisra
commented
Apr 10, 2023
| _onConnectionStatusChanged = context.ConnectionStatusChangeHandler; | ||
|
|
||
| // This retry policy is saved only to handle the client state when the retry policy informs that no more retry attempts are to be made | ||
| _retryPolicy = context.RetryPolicy; |
There was a problem hiding this comment.
Todo - check exp backoff retry policy. Possible that we increase the wait time way quicker than "required"
abhipsaMisra
force-pushed
the
abmisr/connectionStatusHandler
branch
from
7b5c120 to
b2ddc19
Compare
abhipsaMisra
commented
Apr 11, 2023
abhipsaMisra
requested review from
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
abhipsaMisra
commented
Apr 11, 2023
tmahmood-microsoft
approved these changes
Apr 12, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
patilsnr
approved these changes
Apr 12, 2023
andyk-ms
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.