Simplify/rename error class given to IoT hub service client error processors #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessors Instead of provided either an IOException or an IotHubServiceException, we now just provide a single Exception that can be either of those types or more. Also create some facade classes around ErrorContext so that the error processors of each of the AMQP using clients' error processor is unique
timtay-microsoft
requested review from
drwill-ms,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
drwill-ms
reviewed
Apr 6, 2023
drwill-ms
reviewed
Apr 6, 2023
drwill-ms
reviewed
Apr 6, 2023
drwill-ms
reviewed
Apr 6, 2023
drwill-ms
approved these changes
Apr 7, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
reviewed
Apr 7, 2023
| { | ||
| await ErrorProcessor.Invoke(new ErrorContext(ioEx)).ConfigureAwait(false); | ||
| } | ||
| await ErrorProcessor.Invoke(new FileUploadNotificationProcessorError(ex)).ConfigureAwait(false); |
There was a problem hiding this comment.
So why await here and not for C2D?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of provided either an IOException or an IotHubServiceException, we now just provide a single Exception that can be either of those types or more. Also create some facade classes around ErrorContext so that the error processors of each of the AMQP clients reads more cohesively