Update MQTT and AMQP minor package versions #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
abhipsaMisra
approved these changes
Apr 17, 2023
patilsnr
approved these changes
Apr 17, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
commented
Apr 17, 2023
| @@ -78,15 +79,9 @@ internal static bool FaultShouldDisconnect(string faultType) | |||
|
|
|||
| await deviceClient.SendTelemetryAsync(faultInjectionMessage, linkedCts.Token).ConfigureAwait(false); | |||
| } | |||
| catch (IotHubClientException ex) when (ex.IsTransient || ex.ErrorCode == IotHubClientErrorCode.ConnectionForcefullyClosedOnFaultInjection) | |||
There was a problem hiding this comment.
This was showing up in GWv2, but they said they'd roll it back, so we don't need it anymore.
drwill-ms
commented
Apr 17, 2023
| { | ||
| VerboseTestLogger.WriteLine($"{nameof(ActivateFaultInjectionAsync)}: {ex}"); | ||
|
|
||
| // For quota injection, the fault is only seen for the original HTTP request. | ||
| if (transportSettings is IotHubClientHttpSettings) |
There was a problem hiding this comment.
Irrelevant in v2.
drwill-ms
commented
Apr 17, 2023
| @@ -439,9 +439,9 @@ public override async Task SendTelemetryAsync(TelemetryMessage message, Cancella | |||
|
|
|||
| if (message.Properties.ContainsKey("AzIoTHub_FaultOperationType")) | |||
| { | |||
| // When fualt injection causes this operation to fail, the MQTT layer throws a TaskCanceledException. | |||
| // When fault injection causes this operation to fail, the MQTT layer throws a MqttClientDisconnectedException. | |||
There was a problem hiding this comment.
This was the breaking change from the MQTT lib.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.