Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation button to pnp sample #1010

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Add documentation button to pnp sample #1010

merged 2 commits into from
Aug 18, 2021

Conversation

JimacoMS4
Copy link
Contributor

Checklist

  • [x ] I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-node/blob/master/.github/CONTRIBUTING.md).
  • [NA ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • [ NA] I edited the corresponding document in the devdoc folder and added or modified requirements.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Description of the solution

Just adding a documentation button to the PNP sample that points to https://docs.microsoft.com/en-us/azure/iot-develop/ . Part of documentation effort.

@JimacoMS4
Copy link
Contributor Author

@timlt Please check out this PR before I send email to Eric. I want to make sure we're on the same page with the following:

Thanks,

Jimaco

@timlt
Copy link

timlt commented Aug 5, 2021

Looks good to go!

@ericmitt
Copy link
Contributor

ericmitt commented Aug 5, 2021

Good for me as well. Thanks

@JimacoMS4
Copy link
Contributor Author

#sign-off

@JimacoMS4 JimacoMS4 closed this Aug 12, 2021
@JimacoMS4 JimacoMS4 reopened this Aug 12, 2021
@JimacoMS4
Copy link
Contributor Author

@ericmitt I'm not sure what else I need to do here to get this merged (Note I just closed and re-opened the request, so some checks might be in-progress). It's been sitting for several days.

@JimacoMS4
Copy link
Contributor Author

@pierreca @BertKleewein @anthonyvercolano can you please merge or let me know what else needs to be done? I'm not sure what to do to get the tests to complete, but the PR just adds some images for doc support and a button that points back to docs to one of the samples.

@YoDaMa
Copy link
Contributor

YoDaMa commented Aug 18, 2021

@JimacoMS4 thanks for your patience. we're gonna get this merged in now.

@YoDaMa
Copy link
Contributor

YoDaMa commented Aug 18, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@YoDaMa YoDaMa merged commit 66a7a05 into Azure:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants