-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation button to pnp sample #1010
Add documentation button to pnp sample #1010
Conversation
@timlt Please check out this PR before I send email to Eric. I want to make sure we're on the same page with the following:
Thanks, Jimaco |
Looks good to go! |
Good for me as well. Thanks |
#sign-off |
@ericmitt I'm not sure what else I need to do here to get this merged (Note I just closed and re-opened the request, so some checks might be in-progress). It's been sitting for several days. |
@pierreca @BertKleewein @anthonyvercolano can you please merge or let me know what else needs to be done? I'm not sure what to do to get the tests to complete, but the PR just adds some images for doc support and a button that points back to docs to one of the samples. |
@JimacoMS4 thanks for your patience. we're gonna get this merged in now. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Checklist
devdoc
folder and added or modified requirements.Reference/Link to the issue solved with this PR (if any)
Description of the problem
Description of the solution
Just adding a documentation button to the PNP sample that points to https://docs.microsoft.com/en-us/azure/iot-develop/ . Part of documentation effort.