fix: update error logging #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -315,7 +316,7 @@ export class SenderLink extends EventEmitter implements AmqpLink { | |||
| this._indicatedError = undefined; | |||
| this._senderCloseOccurred = true; | |||
| if (error) { | |||
| debugErrors(this.toString() + ': In sender attached state - close event for ' + context.sender.name + ' already indicated error is: ' + this._getErrorName(error)); | |||
| debugErrors(this.toString() + ': In sender attached state - close event for ' + context.sender.name + ' already indicated error is: ' + getErrorName(error)); | |||
There was a problem hiding this comment.
very minor nit: Template literals would be more readable and slightly shorter than concatenating strings, i.e.,
Suggested change
| debugErrors(this.toString() + ': In sender attached state - close event for ' + context.sender.name + ' already indicated error is: ' + getErrorName(error)); | |
| debugErrors(`${this.toString()}: In sender attached state - close event for ${context.sender.name} already indicated error is: ${getErrorName(error)}`); |
vishnureddy17
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes I needed to make to debug my current ICM. Mostly this changes debug logging that says "error is [object Object]" to something more meaningful.