Fix + changelog

Azure · Jul 23, 2024 · aa8eae0 · aa8eae0
1 parent 789678e
commit aa8eae0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 17 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.16.0]
+### Changed
+- the `WithApplicationCertificate` on `KustoConnectionStringBuilder` was removed as it was ambiguous and not implemented correctly. Instead there are two new methods:
+  - `WithAppCertificatePath` - Receives the path to the certificate file.
+  - `WithAppCertificateBytes` - Receives the certificate bytes in-memory.  
+  Both methods accept an optional password for the certificate.
+
 ## [0.15.3] - 2024-06-17
 ### Fixed
 - Fixed Mapping Kind not working correctly with certain formats.
@@ -48,9 +55,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [0.14.1] - 2023-09-27
 
 ### Added
-
 - Support new playfab domain
 
+
 ### Fixed
 
 - Fixed deadlock when having high number of concurrent queries
@@ -68,6 +75,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Fixed wrong context deadline setting
 * Fixed accepting empty url.
 
+
 ## [0.13.1] - 2023-05-24
 
 ### Changed

diff --git a/kusto/kcsb_test.go b/kusto/kcsb_test.go
@@ -31,22 +31,21 @@ func TestGetConnectionStringBuilder(t *testing.T) {
 			name:             "test_conn_string_fullstring",
 			connectionString: "https://help.kusto.windows.net/Samples;aad user id=1234;password=****;application key=1234;application client id=1234;application key=0987;application certificate=avsefsfbsrgbrb; authority id=123456;application token=token;user token=usertoken;;interactivelogin=false; domainhint=www.google.com",
 			want: ConnectionStringBuilder{
-				DataSource:                       "https://help.kusto.windows.net/Samples",
-				AadUserID:                        "1234",
-				Password:                         "****",
-				UserToken:                        "usertoken",
-				ApplicationClientId:              "1234",
-				ApplicationKey:                   "0987",
-				AuthorityId:                      "123456",
-				ApplicationCertificate:           "avsefsfbsrgbrb",
-				ApplicationCertificateThumbprint: "",
-				SendCertificateChain:             false,
-				ApplicationToken:                 "token",
-				AzCli:                            false,
-				MsiAuthentication:                false,
-				ManagedServiceIdentity:           "",
-				InteractiveLogin:                 false,
-				RedirectURL:                      "www.google.com",
+				DataSource:                 "https://help.kusto.windows.net/Samples",
+				AadUserID:                  "1234",
+				Password:                   "****",
+				UserToken:                  "usertoken",
+				ApplicationClientId:        "1234",
+				ApplicationKey:             "0987",
+				AuthorityId:                "123456",
+				ApplicationCertificatePath: "avsefsfbsrgbrb",
+				SendCertificateChain:       false,
+				ApplicationToken:           "token",
+				AzCli:                      false,
+				MsiAuthentication:          false,
+				ManagedServiceIdentity:     "",
+				InteractiveLogin:           false,
+				RedirectURL:                "www.google.com",
 			},
 		},
 	}