Fix headers v2 #306
Merged
Fix headers v2 #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Take `process.argv[1]` as an app identifier instead of `process.title` - More strict header escaping, limit the length to 100 characters per field ## [6.0.1] - 2024-04-07 ### Fixed - Version number fix
- Take `process.argv[1]` as an app identifier instead of `process.title` - More strict header escaping, limit the length to 100 characters per field ## [6.0.1] - 2024-04-07 ### Fixed - Version number fix
ohadbitt
approved these changes
Apr 11, 2024
| @@ -15,7 +15,7 @@ declare namespace NodeJS { | |||
| } | |||
|
|
|||
| // This regex allows all printable ascii, except spaces and chars we use in the format | |||
| const ReplaceRegex = /[^\x21-\x7A]+/g; | |||
There was a problem hiding this comment.
please just align this allover :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #299
Changed
process.argv[1]as an app identifier instead ofprocess.title