Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akhilailla/fix properties type object no definition false negatives #718

Conversation

AkhilaIlla
Copy link
Collaborator

@AkhilaIlla AkhilaIlla commented Jun 24, 2024

Blocking comment related to property of type object not having definition is added manually: (Azure/azure-rest-api-specs#28891 (comment))

This PR validates if the false negative mentioned in https://msazure.visualstudio.com/One/_workitems/edit/28199177 (Azure/azure-rest-api-specs#28891 (comment)) is being flagged.

Also, found that no jobs ran until a couple of comments on the PR. Either the checks didnt run & hence didnt flag the error or the builds arent showing up now.
image

akhilailla added 2 commits June 24, 2024 12:27
… into akhilailla/fix_PropertiesTypeObjectNoDefinition-_false_negatives

Pull master changes
Copy link
Contributor

@tejaswiMinnu tejaswiMinnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason this issue wasn't detected is because the rule is currently only in the staging environment. I have a PBI in this sprint to update the rules in the production environment.

@AkhilaIlla AkhilaIlla merged commit f3c16b5 into main Aug 20, 2024
4 checks passed
@AkhilaIlla AkhilaIlla deleted the akhilailla/fix_PropertiesTypeObjectNoDefinition-_false_negatives branch August 20, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants