Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SshUtilsUT build on GCC 4.8 distros #827

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

jepio
Copy link
Member

@jepio jepio commented Dec 5, 2024

Description

The file was missing an #include <system_error> statement. With this change commontests builds on centos 7/rhel 7/oracle linux 7 and ubuntu 14.04 again, so there is no reason to make the include of these files conditional.

Checklist

  • I have read the contribution guidelines.
  • All unit tests are passing.
  • I have merged the latest main branch prior to this PR submission.
  • I submitted this PR against the main branch.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio jepio requested a review from a team as a code owner December 5, 2024 14:25
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@MariusNi
Copy link
Contributor

MariusNi commented Dec 5, 2024

This is perfect, thank you!

Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi merged commit 033f3b7 into Azure:main Dec 5, 2024
115 of 117 checks passed
@jepio jepio deleted the ssh-ut-fix branch December 6, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants