Add ProcedureObjectName and ProcedureObjectValue to OsConfig Schema #856
Conversation
wupeka
force-pushed
the
wpk-add-procedure-to-osconfig
branch
from
4b190ab to
f632d24
Compare
|
@microsoft-github-policy-service agree company="Microsoft" |
wupeka
force-pushed
the
wpk-add-procedure-to-osconfig
branch
2 times, most recently
from
17970d9 to
8beb725
Compare
wupeka
force-pushed
the
wpk-add-procedure-to-osconfig
branch
from
8beb725 to
9237261
Compare
| payloadSize = (int)strlen(serializedValue); | ||
| if (NULL != (payloadString = malloc(payloadSize + 1))) | ||
| { | ||
| const OsConfigComponent *component = NULL; |
There was a problem hiding this comment.
Pure C style requires all variables locally declared withing a statement of a function to be defined at the beginning/top of the statement. To respect this old style and for consistency with existing code, can you please move the definition on line 421 at top, between lines 389 and 396? Please repeat the same for all other locals that would fall into this case.
| payloadSize = (int)strlen(serializedValue); | ||
| if (NULL != (payloadString = malloc(payloadSize + 1))) | ||
| { | ||
| const OsConfigComponent *component = NULL; |
| LogInfo(context, GetLog(), "[%s] MmiSet(%s, %s, '%.*s', %d) returned %d", | ||
| who, g_componentName, objectName, payloadSize, payloadString, payloadSize, mpiResult); | ||
|
|
||
| } |
There was a problem hiding this comment.
Please do not do this. This is the role of the Modules Manager. Adapters cannot call MMI directly. Adapters can only call the MPI.
Please remove this entire function and keep the NRP existing functions for get and set that talk to OSConfig over the MPI REST API.
Description
Add ProcedureObjectName and ProcedureObjectValue fields to OsConfig schema and OsConfigResource
Add support for multiple Components in OsConfigResource.
Checklist
devbranch prior to this PR submission.devbranch.