Vimundad appgwt: Adding Rule Priority for Application Gateway RequestRoutingRule #13542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 19, 2020 01:13
…aymundada27/azure-powershell into vimundad-appgwt-rulepriority
|
/azp run azure-powershell - powershell-core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-powershell - powershell-core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
msJinLei
requested changes
Nov 23, 2020
| @@ -27,6 +27,7 @@ The **Set-AzApplicationGatewaySslCertificate** cmdlet updates an SSL certificate | |||
| ### Example 1: Update an existing SSL certificate on Application Gateway | |||
| ``` | |||
| PS C:\> $appGW = Get-AzApplicationGateway -Name "ApplicationGateway01" -ResourceGroupName "ResourceGroup01" | |||
| [//]: # ([SuppressMessage\("Microsoft.Security", "CS002:SecretInNextLine", Justification="Test password for the ssl certificate"\)]) | |||
There was a problem hiding this comment.
It is better a use a variable in the replacement of "P@ssw0rd"
|
/azp run azure-powershell - powershell-core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
msJinLei
requested changes
Nov 23, 2020
| @@ -27,7 +27,8 @@ The **Set-AzApplicationGatewaySslCertificate** cmdlet updates an SSL certificate | |||
| ### Example 1: Update an existing SSL certificate on Application Gateway | |||
| ``` | |||
| PS C:\> $appGW = Get-AzApplicationGateway -Name "ApplicationGateway01" -ResourceGroupName "ResourceGroup01" | |||
| PS C:\> $password = ConvertTo-SecureString "P@ssw0rd" -AsPlainText -Force | |||
| PS C:\> $passwordString = "P@ssw0rd" | |||
There was a problem hiding this comment.
what I mean is not to list password content in the doc, but use a variable as the replacement such as
PS C:> $password = ConvertTo-SecureString $passwordPlainString -AsPlainText -Force
There was a problem hiding this comment.
And no need to declare the $passwordPlainString variable as well right?
msJinLei
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a parameter 'Priority' to the Application Gateway RequestRoutingRule object.
Swagger PR - Azure/azure-rest-api-specs#7131
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added