Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen for addomainservices #13914

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Codegen for addomainservices #13914

merged 2 commits into from
Jan 12, 2021

Conversation

dolauli
Copy link
Contributor

@dolauli dolauli commented Jan 11, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@isra-fel
Copy link
Member

Tests failed because of 404 when getting index from myget.
Will retry tomorrorw

@isra-fel isra-fel self-assigned this Jan 11, 2021
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel added this to the S181 (2021-01-19) milestone Jan 12, 2021
@isra-fel isra-fel merged commit 70ebe3b into master Jan 12, 2021
@isra-fel isra-fel deleted the codegen/ADDomainServices branch January 12, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants