-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate StackHCI from generation to main #24171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
Type | Cmdlet | Description | Remediation |
---|---|---|---|
Get-AzStackHciArcSetting | Get-AzStackHciArcSetting Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHciArcSetting | Get-AzStackHciArcSetting changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzStackHciCluster | Get-AzStackHciCluster Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHciCluster | Get-AzStackHciCluster changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzStackHciExtension | Get-AzStackHciExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHciExtension | Get-AzStackHciExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzStackHCIRemoteSupportAccess | Get-AzStackHCIRemoteSupportAccess Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHCIRemoteSupportAccess | Get-AzStackHCIRemoteSupportAccess changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzStackHCIRemoteSupportSessionHistory | Get-AzStackHCIRemoteSupportSessionHistory Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHCIRemoteSupportSessionHistory | Get-AzStackHCIRemoteSupportSessionHistory changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Windows PowerShell - Windows
Type | Cmdlet | Description | Remediation |
---|---|---|---|
Get-AzStackHciArcSetting | Get-AzStackHciArcSetting Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHciArcSetting | Get-AzStackHciArcSetting changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzStackHciCluster | Get-AzStackHciCluster Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHciCluster | Get-AzStackHciCluster changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzStackHciExtension | Get-AzStackHciExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHciExtension | Get-AzStackHciExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzStackHCIRemoteSupportAccess | Get-AzStackHCIRemoteSupportAccess Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHCIRemoteSupportAccess | Get-AzStackHCIRemoteSupportAccess changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzStackHCIRemoteSupportSessionHistory | Get-AzStackHCIRemoteSupportSessionHistory Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzStackHCIRemoteSupportSessionHistory | Get-AzStackHCIRemoteSupportSessionHistory changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Register-AzStackHCI 4 1 Mismatched_Parameter_Value_Type Register-AzStackHCI -Credential Get-Credential is not an expected parameter value type. -Credential Use correct parameter value type. Expected Type is pscredential. Now the type is string.(Static). ⚠️ Unregister-AzStackHCI 4 1 Mismatched_Parameter_Value_Type Unregister-AzStackHCI -Credential Get-Credential is not an expected parameter value type. -Credential Use correct parameter value type. Expected Type is pscredential. Now the type is string.(Static).
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Register-AzStackHCI 4 1 Mismatched_Parameter_Value_Type Register-AzStackHCI -Credential Get-Credential is not an expected parameter value type. -Credential Use correct parameter value type. Expected Type is pscredential. Now the type is string.(Static). ⚠️ Unregister-AzStackHCI 4 1 Mismatched_Parameter_Value_Type Unregister-AzStackHCI -Credential Get-Credential is not an expected parameter value type. -Credential Use correct parameter value type. Expected Type is pscredential. Now the type is string.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.74 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.74% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.74% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 40.74% Test coverage for the module cannot be lower than 50%.
msJinLei
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate StackHCI from generation-DesktopVirtualization-preview to main
The last commit of src/StackHCI in generation-DesktopVirtualization-preview is:
commit 5d7fca6 Author: Priyanshi Jain 87351063+priyjain358@users.noreply.github.com Date: Fri Jan 26 07:10:57 2024 +0530 Az.StackHCI OOB Release - Jan 25 (#24026) * changes to ps1 * build changes
Checklist