Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomScript rollout - stage #1 #2344

Merged
merged 1 commit into from
Aug 15, 2016
Merged

CustomScript rollout - stage #1 #2344

merged 1 commit into from
Aug 15, 2016

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Aug 12, 2016

cc: @bmoore-msft @gatneil PTAL
See #2340.

@ahmetb
Copy link
Contributor Author

ahmetb commented Aug 15, 2016

@gatneil can you please take a look at test failures, they don't seem pertinent to the changes.

@gatneil
Copy link
Contributor

gatneil commented Aug 15, 2016

It looks like in some cases we have publisher "Microsoft.Azure.Extension" with type "CustomScript" and in other cases we have publisher "Microsoft.Compute" with type "CustomScriptExtension". Is this on purpose?

@ahmetb
Copy link
Contributor Author

ahmetb commented Aug 15, 2016

@gatneil Microsoft.Compute one is the Windows CustomScript extension. We don't touch that just yet.

We have plans to merge them all in this new extension and make it work on Windows too. Unfortunately the organization names (such as Microsoft.Compute or Microsoft.OSTC) ended up in extension names, the new extension fixes that (see: Conway's Law).

@gatneil
Copy link
Contributor

gatneil commented Aug 15, 2016

Cool. Otherwise, the PR looks good. You're correct that the CI errors are unrelated to your changes. The azuredeploy.parameters.json files should be updated on 2 of them so they utilize the CI properly, but I can do that in a follow-up PR :)

@gatneil gatneil merged commit 649401b into Azure:master Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants