Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201-vmss-windows-webapp-dsc-autoscale #2762

Merged
merged 39 commits into from
Dec 23, 2016
Merged

201-vmss-windows-webapp-dsc-autoscale #2762

merged 39 commits into from
Dec 23, 2016

Conversation

jboeshart
Copy link
Contributor

Best Practice Checklist

Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md

  1. uri's compatible with all clouds (Stack, China, Government)
  2. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken
  3. Use resourceGroup().location for resource locations
  4. Folder names for artifacts (nestedtemplates, scripts, DSC)
  5. Use literal values for apiVersion (no variables)
  6. Parameter files (GEN-UNIQUE for value generation and no "changemeplease" values
  7. $schema and other uris use https
  8. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment.
  9. Update the metadata.json with the current date

For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

Initial ARM template commit.

@azurecla
Copy link

Hi @jboeshart, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (jaboes). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@jboeshart
Copy link
Contributor Author

Not sure why this is failing, as I made the paths for dependencies in github point to the master repo as instructed in the contribution guide. Doesn't look like they are getting rewritten to point to the artifacts in my fork, did I do something wrong or is this out of order at the moment?

@gatneil
Copy link
Contributor

gatneil commented Nov 16, 2016

Probably because you need to use specially named staging artifact parameters: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md :)

@gatneil gatneil merged commit 49bdc6b into Azure:master Dec 23, 2016
@jboeshart jboeshart deleted the 201-vmss-windows-webapp-dsc-autoscale branch December 27, 2016 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants