Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.Insights to add version …
Browse files Browse the repository at this point in the history
…preview/2017-11-01-preview (#12234)

* Fixed swagger validations for version 2017-11-01

* reverted errorREsponse, suppession in another PR

* added suppression rule

* removed suppression as it exists in another PR

* added back suppressoin rule

* added missing timestamps

* fixed suppression
  • Loading branch information
yashmuel authored Jan 6, 2021
1 parent 9b8310b commit b063290
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
}
},
"paths": {
"/{resourceUri}/providers/microsoft.insights/baseline/{metricName}": {
"/{resourceUri}/providers/Microsoft.Insights/baseline/{metricName}": {
"get": {
"tags": [
"Baseline"
Expand Down Expand Up @@ -238,6 +238,15 @@
"description": "A single high threshold value."
},
"description": "The high thresholds of the baseline."
},
"timestamps": {
"type": "array",
"items": {
"type": "string",
"format": "date-time",
"description": "the timestamp for the baseline value in ISO 8601 format."
},
"description": "the array of timestamps of the baselines."
}
},
"required": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,15 @@
"description": "A single high threshold value."
},
"description": "The high thresholds of the baseline."
},
"timestamps": {
"type": "array",
"items": {
"type": "string",
"format": "date-time",
"description": "the timestamp for the baseline value in ISO 8601 format."
},
"description": "the array of timestamps of the baselines."
}
},
"required": [
Expand Down
3 changes: 3 additions & 0 deletions specification/monitor/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,9 @@ directive:
from: dataCollectionRuleAssociations_API.json
where: $.paths
reason: 'Operations API is defined in a separate swagger spec for Microsoft.Insights namespace (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/operations_API.json)'
- suppress: R4007
from: baseline_API.json
reason: 'Updating the error response to the new format would be a breaking change.'
- suppress: R4007
from: metricBaselines_API.json
reason: 'Updating the error response to the new format would be a breaking change.'
Expand Down

0 comments on commit b063290

Please sign in to comment.