[Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview #10677

pabowers · 2020-09-02T22:36:33Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-09-02T22:36:37Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-09-02T22:36:50Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-02T22:41:59Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-02T22:42:04Z

azure-sdk-for-go - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 82a862a with merge commit 8d2a964. SDK Automation 13.0.17.20200909.5

[AutoRest] FATAL: System.InvalidOperationException: output-folder must be under a preview subdirectory for preview swagger set Microsoft.BareMetalInfrastructure/preview/2020-08-06-preview/baremetalinfrastructure.json
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 182
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: go/generate - FAILED
[AutoRest] FATAL: Error: Plugin go reported failure.
[AutoRest]   Error: Plugin go reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.155 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/baremetalinfrastructure/resource-manager/readme.md FATAL: System.InvalidOperationException: output-folder must be under a preview subdirectory for preview swagger set Microsoft.BareMetalInfrastructure/preview/2020-08-06-preview/baremetalinfrastructure.json
   at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 182
   at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
  Error: Plugin go reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-09-02T22:42:18Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 82a862a with merge commit 8d2a964. SDK Automation 13.0.17.20200909.5
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-02T22:42:32Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 82a862a with merge commit 8d2a964. SDK Automation 13.0.17.20200909.5
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-09-02T22:42:33Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-02T22:42:35Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 82a862a with merge commit 8d2a964. SDK Automation 13.0.17.20200909.5

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/_bare_metal_infrastructure_client.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/models/_bare_metal_infrastructure_client_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/operations/_azure_bare_metal_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/baremetalinfrastructure/version.py

openapi-sdkautomation · 2020-09-02T22:42:35Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-02T22:42:39Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-02T22:42:52Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-09-02T22:48:39Z

Azure Pipelines successfully started running 1 pipeline(s).

pabowers · 2020-09-02T22:50:03Z

/openapi pipeline

openapi-sdkautomation · 2020-09-02T22:50:05Z

/openapi pipeline

Unrecognized OpenAPI bot command (pipeline).
Try sdkautomation instead.

openapi-pipeline-app · 2020-09-02T22:50:05Z

/openapi pipeline

Unrecognized OpenAPI bot command (pipeline).
Try sdkautomation or run instead.

azure-pipelines · 2020-09-03T00:02:09Z

Azure Pipelines successfully started running 1 pipeline(s).

…ill needs some work

azure-pipelines · 2020-09-09T22:00:10Z

Azure Pipelines successfully started running 1 pipeline(s).

specification/baremetalinfrastructure/resource-manager/readme.go.md

azure-pipelines · 2020-09-10T00:18:39Z

Azure Pipelines successfully started running 1 pipeline(s).

...er/Microsoft.BareMetalInfrastructure/preview/2020-08-06-preview/baremetalinfrastructure.json

chiragg4u · 2020-09-10T00:34:09Z

Please share the details about the changes from your previous RP namespace in the PR for faster review.

erich-wang · 2020-09-10T02:32:13Z

@ArcturusZhang, could you please take a look for Go SDK errror?

ArcturusZhang · 2020-09-10T03:08:49Z

@erich-wang the Go generation failure is a preview directory error - please ignore it for now, I will make a PR to resolve all of this kind errors soon. Since the generation results for other languages are fine, we could proceed ignoring the go SDK failure.

pabowers · 2020-09-10T04:12:53Z

@chiragg4u For now, these resources are created in our Provisioning Portal by our Operations team. We have this for the HanaInstances as well, but also have the create command in the Swagger spec. Since we don’t have a way to create the BareMetalInstances from the Azure Portal yet, I didn’t include it in the swagger spec. Once we have CRUD, I will update the swagger spec.

The change from the previous namespace is due to a rebranding effort and we will support both HanaInstances as well as BareMetalInstances until we fully move away from the old namespace.

The key differences with the HanaInstances and AzureBareMetalInstances are as follows
We do not have the monitoring functionality on an AzureBareMetalInstance
The PUT API is not yet in place for AzureBareMetalInstances. There is an internal way for now and once it is possible from the portal, we will expose in the swagger spec

chiragg4u · 2020-09-10T04:15:37Z

Signed off based on the comments. Please resolve other failures and follow the process given @ https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/202/Overall-Process-of-AME-Onboarding

...er/Microsoft.BareMetalInfrastructure/preview/2020-08-06-preview/baremetalinfrastructure.json

azure-pipelines · 2020-09-11T01:01:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-11T01:37:38Z

Azure Pipelines successfully started running 1 pipeline(s).

erich-wang · 2020-09-11T02:40:58Z

@pabowers , could you please fix LintDiff error in CI check?

…ponse schema

azure-pipelines · 2020-09-11T03:24:22Z

Azure Pipelines successfully started running 1 pipeline(s).

…to add version preview/2020-08-06-preview (Azure#10677) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * started writing basic swagger specs for AzureBareMetalInstances it still needs some work * cleaning up some leftover naming from hana * adding an operationId for listByResourceGroup * changing the folder path to match our namespace * updating a slight naming change * addressing April's nit comments * changing the code generation name to be capitalized to meet python standards * Redoing most of the linting and prettier checks to make sure the api looks good * change json file name back to fix linter * add isDataAction to operation list type * Fixing an incorrectly named operation * rename title to be a client * fix go README.MD to have correct format with namespace * rename the list methods to conform to standards * changed to use common types for the majority of the parameters * use common error type and resource type * Change the error type back so that it complies with correct error response schema

…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (545 commits) Changes for new api version sdk generate (Azure#10685) Update batch sdk comments (Azure#10517) Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster (Azure#10673) Bump node-fetch from 2.6.0 to 2.6.1 in /.azure-pipelines-preproduction (Azure#10762) Spark Compute Isolation enabled (Azure#10726) [Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview (Azure#10677) PostgreSQL Flexible Server New API Swagger Changes (Azure#10586) Bump node-fetch from 2.6.0 to 2.6.1 (Azure#10760) Swagger changes. Remove weekly and monthly options from replicationSchedule enum (Azure#10752) modify description of properties to be self consistent (Azure#10711) Adding ComputeInstance to preview swagger (Azure#10654) remove unsupported reversproxy and useTestExtension (Azure#10728) Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview (Azure#10735) FR v2.1-preview.1 update (Azure#10747) ServiceBus : Swagger Split and Added PrivateEndPointConnection API (Azure#10071) Eventhub: Added PrivateEndpointConnection API (Azure#10635) codegen onboard df for cli (Azure#8531) Update swagger for outbound public ip feature (Azure#10713) 2020-09-01-hybrid profile for AzureStack (Azure#10295) Update pull_request_assignment.yml (Azure#10724) ...

openapi-assignment-bot bot assigned erich-wang Sep 2, 2020

pabowers force-pushed the dev-azurebaremetal-Microsoft.BareMetalInfrastructure-2020-08-06-preview branch from 512c065 to 0896a83 Compare September 2, 2020 22:48

pabowers marked this pull request as ready for review September 3, 2020 00:08

pabowers and others added 11 commits September 2, 2020 17:13

New Readme Config File

d1a17cf

New Go Language Readme Config File

00dfab8

New Typescript Language Readme Config File

d67e0a3

New Python Language Readme Config File

5d11da3

New C# Language Readme Config File

d63acc5

New Ruby Language Readme Config File

4fae7e1

New Swagger Spec File

1ad5d13

New Swagger Example Spec File

c1ee69e

started writing basic swagger specs for AzureBareMetalInstances it st…

7b2ee50

…ill needs some work

cleaning up some leftover naming from hana

7120a74

adding an operationId for listByResourceGroup

e92876c

pabowers force-pushed the dev-azurebaremetal-Microsoft.BareMetalInfrastructure-2020-08-06-preview branch from 5447aea to 7486e7c Compare September 9, 2020 21:59

allenjzhang reviewed Sep 10, 2020

View reviewed changes

specification/baremetalinfrastructure/resource-manager/readme.go.md Outdated Show resolved Hide resolved

fix go README.MD to have correct format with namespace

ec68332

chiragg4u reviewed Sep 10, 2020

View reviewed changes

...er/Microsoft.BareMetalInfrastructure/preview/2020-08-06-preview/baremetalinfrastructure.json Show resolved Hide resolved

chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 10, 2020

pabowers requested a review from allenjzhang September 10, 2020 21:30

allenjzhang reviewed Sep 11, 2020

View reviewed changes

...er/Microsoft.BareMetalInfrastructure/preview/2020-08-06-preview/baremetalinfrastructure.json Outdated Show resolved Hide resolved

allenjzhang reviewed Sep 11, 2020

View reviewed changes

...er/Microsoft.BareMetalInfrastructure/preview/2020-08-06-preview/baremetalinfrastructure.json Outdated Show resolved Hide resolved

allenjzhang requested changes Sep 11, 2020

View reviewed changes

...er/Microsoft.BareMetalInfrastructure/preview/2020-08-06-preview/baremetalinfrastructure.json Show resolved Hide resolved

...er/Microsoft.BareMetalInfrastructure/preview/2020-08-06-preview/baremetalinfrastructure.json Show resolved Hide resolved

pabowers added 2 commits September 10, 2020 17:34

rename the list methods to conform to standards

e8891c6

changed to use common types for the majority of the parameters

0ec2235

use common error type and resource type

4128328

Change the error type back so that it complies with correct error res…

82a862a

…ponse schema

erich-wang approved these changes Sep 11, 2020

View reviewed changes

allenjzhang approved these changes Sep 11, 2020

View reviewed changes

allenjzhang merged commit 8d2a964 into Azure:master Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview #10677

[Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview #10677

pabowers commented Sep 2, 2020 •

edited

Loading

openapi-pipeline-app bot commented Sep 2, 2020 •

edited

Loading

azure-pipelines bot commented Sep 2, 2020

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

azure-pipelines bot commented Sep 2, 2020

pabowers commented Sep 2, 2020

openapi-sdkautomation bot commented Sep 2, 2020

openapi-pipeline-app bot commented Sep 2, 2020

azure-pipelines bot commented Sep 3, 2020

azure-pipelines bot commented Sep 9, 2020

azure-pipelines bot commented Sep 10, 2020

chiragg4u commented Sep 10, 2020

erich-wang commented Sep 10, 2020

ArcturusZhang commented Sep 10, 2020

pabowers commented Sep 10, 2020 •

edited

Loading

chiragg4u commented Sep 10, 2020

azure-pipelines bot commented Sep 11, 2020

azure-pipelines bot commented Sep 11, 2020

erich-wang commented Sep 11, 2020

azure-pipelines bot commented Sep 11, 2020

[Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview #10677

[Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview #10677

Conversation

pabowers commented Sep 2, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Sep 2, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Sep 2, 2020

openapi-sdkautomation bot commented Sep 2, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Sep 2, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Sep 2, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Sep 2, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Sep 2, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Sep 2, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Sep 2, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Sep 2, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Sep 2, 2020 • edited Loading

Trenton Generation - Release

azure-pipelines bot commented Sep 2, 2020

pabowers commented Sep 2, 2020

openapi-sdkautomation bot commented Sep 2, 2020

openapi-pipeline-app bot commented Sep 2, 2020

azure-pipelines bot commented Sep 3, 2020

azure-pipelines bot commented Sep 9, 2020

azure-pipelines bot commented Sep 10, 2020

chiragg4u commented Sep 10, 2020

erich-wang commented Sep 10, 2020

ArcturusZhang commented Sep 10, 2020

pabowers commented Sep 10, 2020 • edited Loading

chiragg4u commented Sep 10, 2020

azure-pipelines bot commented Sep 11, 2020

azure-pipelines bot commented Sep 11, 2020

erich-wang commented Sep 11, 2020

azure-pipelines bot commented Sep 11, 2020

pabowers commented Sep 2, 2020 •

edited

Loading

openapi-pipeline-app bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 2, 2020 •

edited

Loading

pabowers commented Sep 10, 2020 •

edited

Loading