Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QnAMaker.json - response code correction #10828

Merged
merged 7 commits into from
Sep 28, 2020
Merged

Update QnAMaker.json - response code correction #10828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5586847
Update QnAMaker.json
sahithikkss Sep 17, 2020
1679241
Update example response set endpoint
sahithikkss Sep 17, 2020
025e295
Prettier validation fix
sahithikkss Sep 24, 2020
5e5ae55
required propery validation fix
sahithikkss Sep 24, 2020
89c4876
remove alternateQuestionClusters from example
sahithikkss Sep 24, 2020
303c5ca
removed alternateQuestionClusters across the example
sahithikkss Sep 24, 2020
58ddb84
ModelValidation fixed in example instead of spec - non breaking change
sahithikkss Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMaker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,8 @@
"application/json"
],
"responses": {
"200": {
"description": "Response with endpointSettings update status.",
"schema": {
"type": "string"
}
"204": {
"description": "HTTP 204 No Content."
},
"default": {
"description": "Error response.",
Expand Down
2 changes: 1 addition & 1 deletion ...ification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/examples/SuccessfulRepKb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"Ocp-Apim-Subscription-Key": "{API key}",
"kbId": "9d091697-fb8c-4ed5-9ac0-35bf8273bfff",
"replaceKb": {
"qnaList": [
"qnAList": [
{
"id": 0,
"answer": "You can change the default message if you use the QnAMakerDialog. See this for details: https://docs.botframework.com/en-us/azure-bot-service/templates/qnamaker/#navtitle",
Expand Down
5 changes: 1 addition & 4 deletions ...n/cognitiveservices/data-plane/QnAMaker/stable/v4.0/examples/SuccessfulSetEpSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
}
},
"responses": {
"200": {
"headers": {},
"body": "Successfully updated endpoint settings"
}
"204": {}
}
}
8 changes: 0 additions & 8 deletions ...ification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/examples/SuccessfulUpdKb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@
"add": [],
"delete": []
},
"alternateQuestionClusters": {
"delete": []
},
"context": {
"isContextOnly": false,
"promptsToAdd": [
Expand All @@ -65,7 +62,6 @@
"How can I add prompts?"
],
"metadata": [],
"alternateQuestionClusters": [],
"context": {
"isContextOnly": false,
"prompts": []
Expand All @@ -84,7 +80,6 @@
"How can I delete delete prompts?"
],
"metadata": [],
"alternateQuestionClusters": [],
"context": {
"isContextOnly": false,
"prompts": []
Expand Down Expand Up @@ -126,9 +121,6 @@
}
]
},
"alternateQuestionClusters": {
"delete": []
},
"context": {
"isContextOnly": false,
"promptsToAdd": [
Expand Down