add management group registration description to ARM #10869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
| Rule | Message |
|---|---|
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. New: Microsoft.Resources/stable/2020-06-01/resources.json#L36 |
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. New: Microsoft.Resources/stable/2020-06-01/resources.json#L36 |
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. New: Microsoft.Resources/stable/2020-06-01/resources.json#L36 |
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. New: Microsoft.Resources/stable/2020-06-01/resources.json#L36 |
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. New: Microsoft.Resources/stable/2020-06-01/resources.json#L36 |
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. New: Microsoft.Resources/stable/2020-06-01/resources.json#L36 |
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. New: Microsoft.Resources/stable/2020-06-01/resources.json#L36 |
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. New: Microsoft.Resources/stable/2020-06-01/resources.json#L36 |
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. New: Microsoft.Resources/stable/2020-06-01/resources.json#L36 |
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python-track2 - Release
|
This was referenced Sep 21, 2020
raych1
reviewed
Sep 22, 2020
specification/resources/resource-manager/Microsoft.Resources/stable/2020-06-01/resources.json
Outdated
Show resolved
Hide resolved
raych1
added
Reviewed-ChangesRequested
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 22, 2020
This was referenced Sep 25, 2020
It makes sense, we can skip these lintDiff errors. Once ARM sign off, we will force merge this PR. |
Tiano2017
reviewed
Sep 29, 2020
| "tags": [ | ||
| "Providers" | ||
| ], | ||
| "operationId": "ManagementGroup_Register", |
There was a problem hiding this comment.
let's name it "Providers_ManagementGroup_Register", or "ManagementGroup_Providers_Register".
|
Azure Pipelines successfully started running 1 pipeline(s). |
majastrz
added
ARMSignedOff
majastrz
approved these changes
Sep 30, 2020
|
@raych1 Hey Ray the PR is ready to merge |
allenjzhang
requested changes
Oct 2, 2020
specification/resources/resource-manager/Microsoft.Resources/stable/2020-06-01/resources.json
Outdated
Show resolved
Hide resolved
| @@ -2047,6 +2047,41 @@ | |||
| } | |||
| } | |||
| }, | |||
| "/providers/Microsoft.Management/managementGroups/{groupId}/providers/{resourceProviderNamespace}/register": { | |||
There was a problem hiding this comment.
Stable swagger is NOT supposed to be modified. Do you know if SDKs have been released on this api-version?
There was a problem hiding this comment.
My understanding is that this is a swagger bug fix rather than adding a new API. @tjegbejimba can you confirm that this is the case?
There was a problem hiding this comment.
The MG registration capability is already on the service side it just hasn't been added to the swagger yet. We're not adding a new API
|
Azure Pipelines successfully started running 1 pipeline(s). |
allenjzhang
approved these changes
Oct 5, 2020
|
Linter failure due to multiple RP in a single JSON. As there are already other ManagementGroup in the swagger, I am merging this but opened a refactor issue to track this. |
This was referenced Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.