-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove AKS Windows adminUsername and adminPassword pattern #11276
fix: Remove AKS Windows adminUsername and adminPassword pattern #11276
Conversation
Hi, @mainred Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Hi, @mainred your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @${PRAssignee} |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, @mainred your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @fengzhou-msft |
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Please also remove the pattern for Windows password in AKS WindowsProfile. |
The versions you described in the comment do not match your code. |
...erservice/resource-manager/Microsoft.ContainerService/stable/2019-04-01/managedClusters.json
Outdated
Show resolved
Hide resolved
...erservice/resource-manager/Microsoft.ContainerService/stable/2019-02-01/managedClusters.json
Outdated
Show resolved
Hide resolved
Could you please elaborate? |
437f7d2
to
db8eb2a
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Misunderstanding. Please ignore it. |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of adminUsername will be presented as:
and description of password will be presented as:
|
Add min length for Windows username; Remove "resetting the password" since it does not impact the value in AKS db so it will be reset to the original value after the VMSS model is updated. |
Azure Pipelines successfully started running 1 pipeline(s). |
663206b
to
347d3a4
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
@xizhamsft , could you please take a look at this PR? @fengzhou-msft , we plan to move the validation from the swagger and client side to server side. Could we turn the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LTGM
Hi @mainred, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@fengzhou-msft There is no any API changes for this PR. We only need to remove wrong pattern validation in the swagger so I think that it should not be a breaking change. Could we release this change as hotfix? |
…e#11276) * Remove adminUsername pattern for ManagedClusterWindowsProfile * Update description of adminPassword and adminUsername * Update description to remove Linux related * fix
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
This fixes #11267
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.