Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code owners file to include deployments team alias #11315

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Update code owners file to include deployments team alias #11315

merged 2 commits into from
Oct 23, 2020

Conversation

filizt
Copy link
Contributor

@filizt filizt commented Oct 21, 2020 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 21, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail] 
 There are no breaking changes.
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
️️✔️ModelValidation [Detail] 
 Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail] 
 Validation passes for SemanticValidation.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @filizt Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-sdk-for-net - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-resource-manager-schemas - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 21, 2020 •
    edited
    Loading

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    anthony-c-martin
    anthony-c-martin reviewed Oct 21, 2020
    View reviewed changes
    CODEOWNERS Outdated Show resolved Hide resolved
    @raych1
    Copy link
    Member

    raych1 commented Oct 22, 2020

    @Azure/arm-template-deployments , this is for testing purpose see if can receive the notification.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @raych1 raych1 merged commit b3a8c7c into Azure:master Oct 23, 2020
    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    @filizt
    Update code owners file to include deployments team alias (Azure#11315)
    1e772be 
    * Update code owners file for deployments team

* Update team name alias

Co-authored-by: Filiz Topatan <lsefitopata@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @raych1 raych1 raych1 approved these changes

    @majastrz majastrz majastrz approved these changes

    @anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

    Assignees

    @PhoenixHe-NV PhoenixHe-NV

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @filizt @raych1 @majastrz @anthony-c-martin @PhoenixHe-NV