Remove gallery preview version 2020-09-30 from stable release #12222
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -219,8 +219,7 @@ input-file: | |
| - Microsoft.Compute/stable/2020-06-01/runCommands.json | ||
| - Microsoft.Compute/stable/2019-04-01/skus.json | ||
| - Microsoft.Compute/stable/2020-06-30/disk.json | ||
| - Microsoft.Compute/stable/2019-12-01/gallery.json | ||
| - Microsoft.ContainerService/stable/2017-01-31/containerService.json | ||
| - Microsoft.Compute/preview/2020-10-01-preview/cloudService.json | ||
|
There was a problem hiding this comment. Should this preview CloudService also be removed? @akning-ms , @msyyc There was a problem hiding this comment. @akning-ms I think it's removed because it's a preview version There was a problem hiding this comment. If so, I think we don't need remove it if it is already in previous SDK version |
||
| ``` | ||
|
|
@@ -235,7 +234,6 @@ input-file: | |
| ``` | ||
|
|
||
| ### Tag: package-2020-09-30 | ||
|
There was a problem hiding this comment. We dont have to delete this tag as it will create avocado validation failure and we lost history for generation SDK base on this tag. so pls keep it or let me know why remove it? There was a problem hiding this comment. I put the tag back, but kept it removed from the SDK generation for the latest version. There was a problem hiding this comment. See our ongoing email thread "Candidate PR to fix breaking changes in compute SDK" for details. |
||
| These settings apply only when `--tag=package-2020-09-30` is specified on the command line. | ||
|
|
||
| ``` yaml $(tag) == 'package-2020-09-30' | ||
|
|
@@ -810,4 +808,4 @@ input-file: | |
|
|
||
| ## AzureResourceSchema | ||
|
|
||
| See configuration in [readme.azureresourceschema.md](./readme.azureresourceschema.md) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArcturusZhang @weidongxu-microsoft @msyyc @qiaozha to comments the sdk impact for this gallery api change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compute for python is multiapi, so it is not permitted to delete tag because there may be customers to use the tag now. It's ok to add a new tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an ongoing email thread to discuss this impact. This is to remove breaking changes that were introduced in the gallery version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per email discussion, Go, Java isn't released, but Python released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per email thread with Gallery team, no end users are whitelisted to use the 2020-09-30 version of Gallery and SharedGallery. No end behaviour should change.
@JeffreyRichter approved these changes, so I think we can proceed.