add MetricDimension properties to AVS #12240

ctaggart · 2020-12-28T20:40:35Z

This is for internal wok item 9031099 to fix S360 validation errors. It adds two standard properties for Geneva Metrics as documented internally at https://aka.ms/shoebox. These are common properties defined is many other specs.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2020-12-28T20:40:37Z

Hi, @ctaggart Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2020-12-28T20:40:38Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2020-07-17-preview/vmware.json <---> new: preview/2020-07-17-preview/vmware.json
- original: stable/2020-03-20/vmware.json <---> new: stable/2020-03-20/vmware.json

Rule	Message
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'internalName' in response that was not found in the old version. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L3689:7 Old: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L3689:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'toBeExportedForShoebox' in response that was not found in the old version. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L3689:7 Old: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L3689:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'internalName' in response that was not found in the old version. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1496:7 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1496:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'toBeExportedForShoebox' in response that was not found in the old version. New: Microsoft.AVS/stable/2020-03-20/vmware.json#L1496:7 Old: Microsoft.AVS/stable/2020-03-20/vmware.json#L1496:7

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- vmware/resource-manager/readme.md tag:package-2020-07-17-preview
- vmware/resource-manager/readme.md tag:package-2020-03-20
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- vmware/resource-manager/readme.md tag:package-2020-07-17-preview
- vmware/resource-manager/readme.md tag:package-2020-03-20

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-12-28T20:40:39Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from ba805c7. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/vmware/resource-manager/readme.md

️✔️vmware [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] npm WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from ba805c7. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/vmware/resource-manager/readme.md

️✔️@azure/arm-avs [View full logs] [Release SDK Changes]

azure-arm-avs-0.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/avsClient.js → ./dist/arm-avs.js...
cmderr	[npmPack] created ./dist/arm-avs.js in 523ms

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from ba805c7. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md

️✔️azure-mgmt-avs [View full logs] [Release SDK Changes] Breaking Change Detected

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-avs
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-avs
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.avs
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.avs
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.avs
cmderr	[changelogReport] INFO:__main__:Report written to sdk/compute/azure-mgmt-avs/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-avs on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '1.0.0rc1', '1.0.0']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0 of azure-mgmt-avs in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.avs
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.avs
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.avs
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/compute/azure-mgmt-avs/code_reports/1.0.0/report.json
cmdout	[Changelog] Size of delta 62.529% size of original (original: 55841 chars, delta: 34917 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model PrivateCloudUpdate has a new parameter nsxt_password
cmdout	[Changelog]   - Model PrivateCloudUpdate has a new parameter vcenter_password
cmdout	[Changelog]   - Model MetricDimension has a new parameter to_be_exported_for_shoebox
cmdout	[Changelog]   - Model MetricDimension has a new parameter internal_name
cmdout	[Changelog]   - Added operation group WorkloadNetworksOperations
cmdout	[Changelog]   - Added operation group GlobalReachConnectionsOperations
cmdout	[Changelog]   - Added operation group AddonsOperations
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Operation ClustersOperations.create_or_update has a new signature
cmdout	[Changelog]   - Operation ClustersOperations.create_or_update has a new signature
cmdout	[Changelog]   - Operation HcxEnterpriseSitesOperations.create_or_update has a new signature
cmdout	[Changelog]   - Operation AuthorizationsOperations.create_or_update has a new signature
warn	Breaking change found in changelog

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from ba805c7. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Avs [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Avs.1.0.0.nupkg
- Microsoft.Azure.Management.Avs.1.0.0.snupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from ba805c7. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/avs/mgmt/2020-07-17-preview/avs [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 60 items here, please refer to log for details.

info	[Changelog] - New function `WorkloadNetworksClient.UpdateDNSServiceSender(*http.Request) (WorkloadNetworksUpdateDNSServiceFuture, error)`
info	[Changelog] - New function `WorkloadNetworkDNSServicesListIterator.Value() WorkloadNetworkDNSService`
info	[Changelog] - New function `WorkloadNetworksClient.UpdateDNSZoneSender(*http.Request) (WorkloadNetworksUpdateDNSZoneFuture, error)`
info	[Changelog] - New function `PossibleAddonTypeValues() []AddonType`
info	[Changelog] - New function `AddonsClient.ListComplete(context.Context, string, string) (AddonListIterator, error)`
info	[Changelog] - New function `AddonsClient.CreateOrUpdate(context.Context, string, string, string, Addon) (AddonsCreateOrUpdateFuture, error)`
info	[Changelog] - New function `AddonListPage.Values() []Addon`
info	[Changelog] - New function `WorkloadNetworksClient.CreateDNSService(context.Context, string, string, string, WorkloadNetworkDNSService) (WorkloadNetworksCreateDNSServiceFuture, error)`
info	[Changelog] - New function `WorkloadNetworksClient.DeleteDNSServiceResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `WorkloadNetworksClient.GetDNSService(context.Context, string, string, string) (WorkloadNetworkDNSService, error)`
info	[Changelog] - New function `WorkloadNetworkDNSZonesListPage.NotDone() bool`
info	[Changelog] - New function `WorkloadNetworksClient.ListDNSServicesResponder(*http.Response) (WorkloadNetworkDNSServicesList, error)`
info	[Changelog] - New function `WorkloadNetworkDNSServicesListIterator.NotDone() bool`
info	[Changelog] - New function `PossibleDNSServiceLogLevelEnumValues() []DNSServiceLogLevelEnum`
info	[Changelog] - New function `NewAddonListIterator(AddonListPage) AddonListIterator`
info	[Changelog] - New function `WorkloadNetworksClient.ListDNSZonesSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `AddonsClient.Get(context.Context, string, string, string) (Addon, error)`
info	[Changelog] - New function `WorkloadNetworksClient.UpdateDNSZone(context.Context, string, string, string, WorkloadNetworkDNSZone) (WorkloadNetworksUpdateDNSZoneFuture, error)`
info	[Changelog] - New function `AddonsClient.DeletePreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `WorkloadNetworksClient.GetDNSServicePreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `AddonsClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `WorkloadNetworksClient.GetDNSZoneSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `WorkloadNetworksClient.CreateDNSServiceSender(*http.Request) (WorkloadNetworksCreateDNSServiceFuture, error)`
info	[Changelog] - New function `*WorkloadNetworkDNSServicesListIterator.Next() error`
info	[Changelog] - New function `AddonsClient.CreateOrUpdateSender(*http.Request) (AddonsCreateOrUpdateFuture, error)`
info	[Changelog] - New function `NewWorkloadNetworkDNSServicesListIterator(WorkloadNetworkDNSServicesListPage) WorkloadNetworkDNSServicesListIterator`
info	[Changelog] - New function `NewWorkloadNetworkDNSZonesListPage(WorkloadNetworkDNSZonesList, func(context.Context, WorkloadNetworkDNSZonesList) (WorkloadNetworkDNSZonesList, error)) WorkloadNetworkDNSZonesListPage`
info	[Changelog] - New function `AddonProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `Addon`
info	[Changelog] - New struct `AddonList`
info	[Changelog] - New struct `AddonListIterator`
info	[Changelog] - New struct `AddonListPage`
info	[Changelog] - New struct `AddonProperties`
info	[Changelog] - New struct `AddonSrmProperties`
info	[Changelog] - New struct `AddonUpdate`
info	[Changelog] - New struct `AddonUpdateProperties`
info	[Changelog] - New struct `AddonsClient`
info	[Changelog] - New struct `AddonsCreateOrUpdateFuture`
info	[Changelog] - New struct `AddonsDeleteFuture`
info	[Changelog] - New struct `WorkloadNetworkDNSService`
info	[Changelog] - New struct `WorkloadNetworkDNSServiceProperties`
info	[Changelog] - New struct `WorkloadNetworkDNSServicesList`
info	[Changelog] - New struct `WorkloadNetworkDNSServicesListIterator`
info	[Changelog] - New struct `WorkloadNetworkDNSServicesListPage`
info	[Changelog] - New struct `WorkloadNetworkDNSZone`
info	[Changelog] - New struct `WorkloadNetworkDNSZoneProperties`
info	[Changelog] - New struct `WorkloadNetworkDNSZonesList`
info	[Changelog] - New struct `WorkloadNetworkDNSZonesListIterator`
info	[Changelog] - New struct `WorkloadNetworkDNSZonesListPage`
info	[Changelog] - New struct `WorkloadNetworksCreateDNSServiceFuture`
info	[Changelog] - New struct `WorkloadNetworksCreateDNSZoneFuture`
info	[Changelog] - New struct `WorkloadNetworksDeleteDNSServiceFuture`
info	[Changelog] - New struct `WorkloadNetworksDeleteDNSZoneFuture`
info	[Changelog] - New struct `WorkloadNetworksUpdateDNSServiceFuture`
info	[Changelog] - New struct `WorkloadNetworksUpdateDNSZoneFuture`
info	[Changelog] - New field `InternalName` in struct `MetricDimension`
info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 206 additive change(s).
info	[Changelog]

️✔️avs/mgmt/2020-03-20/avs [View full logs] [Release SDK Changes]

info	[Changelog] ## New Content
info	[Changelog]
info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
info	[Changelog] - New field `InternalName` in struct `MetricDimension`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]

️❌ azure-sdk-for-java failed [Detail]

❌Failed [Logs]Release - Generate from ba805c7. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-11 07:06:29 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-avs"
cmderr	[generate.py] 2021-01-11 07:06:29 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-11 07:06:29 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.8 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/avs/azure-resourcemanager-avs --java.namespace=com.azure.resourcemanager.avs  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
cmderr	[generate.py] ERROR (PreCheck/PropertyRedeclaration): Schema 'PrivateCloudProperties' has a property 'vcenterPassword' that is conflicting with a property in the parent schema 'PrivateCloudUpdateProperties' differs more than just description : [enum => '<removed>',x-ms-enum => '<removed>',x-ms-secret => 'true']
cmderr	[generate.py] ERROR (PreCheck/PropertyRedeclaration): Schema 'PrivateCloudProperties' has a property 'nsxtPassword' that is conflicting with a property in the parent schema 'PrivateCloudUpdateProperties' differs more than just description : [enum => '<removed>',x-ms-enum => '<removed>',x-ms-secret => 'true']
cmderr	[generate.py] FATAL: Error: 2 errors occured -- cannot continue.
cmderr	[generate.py]   Error: Plugin prechecker reported failure.
cmderr	[generate.py] 2021-01-11 07:07:06 ERROR [GENERATE] Autorest fail
ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/avs/azure-resourcemanager-avs/pom.xml'
Error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/avs/azure-resourcemanager-avs/pom.xml'

️✔️azure-resourcemanager-avs [View full logs]

error	Fatal error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/avs/azure-resourcemanager-avs/pom.xml'
error	The following packages are still pending:
error		azure-resourcemanager-avs

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

ctaggart · 2020-12-28T21:45:53Z

I'll do an internal breaking change review next Monday.

ctaggart · 2021-01-04T18:28:57Z

@qianwens , the breaking change has been approved. Please review and merge.

qianwens · 2021-01-07T03:01:45Z

please help fix the conflict

…-properties-to-AVS

ctaggart · 2021-01-08T18:22:18Z

@qianwens, the conflict has been resolved. Please merge.

add MetricDimension properties to AVS

5afaecd

ctaggart requested a review from lirenhe as a code owner December 28, 2020 20:40

openapi-assignment-bot bot assigned qianwens Dec 28, 2020

openapi-pipeline-app bot added the CI-BreakingChange-Python label Dec 28, 2020

openapi-sdkautomation bot mentioned this pull request Dec 28, 2020

[AutoPR Microsoft.Azure.Management.Avs] add MetricDimension properties to AVS AzureSDKAutomation/azure-sdk-for-net#2737

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 4, 2021

JeffreyRichter approved these changes Jan 4, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into add-MetricDimension…

c27e059

…-properties-to-AVS

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 7, 2021

qianwens approved these changes Jan 11, 2021

View reviewed changes

qianwens merged commit ba805c7 into Azure:master Jan 11, 2021

ctaggart deleted the add-MetricDimension-properties-to-AVS branch January 11, 2021 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add MetricDimension properties to AVS #12240

add MetricDimension properties to AVS #12240

ctaggart commented Dec 28, 2020 •

edited

Loading

openapi-workflow-bot bot commented Dec 28, 2020

openapi-pipeline-app bot commented Dec 28, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 28, 2020 •

edited

Loading

ctaggart commented Dec 28, 2020

ctaggart commented Jan 4, 2021

qianwens commented Jan 7, 2021

ctaggart commented Jan 8, 2021

add MetricDimension properties to AVS #12240

add MetricDimension properties to AVS #12240

Conversation

ctaggart commented Dec 28, 2020 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Dec 28, 2020

openapi-pipeline-app bot commented Dec 28, 2020 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Dec 28, 2020 • edited Loading

Swagger Generation Artifacts

ctaggart commented Dec 28, 2020

ctaggart commented Jan 4, 2021

qianwens commented Jan 7, 2021

ctaggart commented Jan 8, 2021

ctaggart commented Dec 28, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 28, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 28, 2020 •

edited

Loading