[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2021-03-01-preview #12554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preview/2020-09-01-preview to version 2021-03-01-preview
|
Hi, @forteddyt Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/features' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L262:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/locations/{location}/Quotas' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L565:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces/skus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1163:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/linkedServices' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1378:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/linkedServices/{linkName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1420:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/services' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1560:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/services/{serviceName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1632:5 |
|
The new version is missing a definition that was found in the old version. Was 'LinkedServiceRequest' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2300:3 |
|
The new version is missing a definition that was found in the old version. Was 'LinkedServiceProps' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2300:3 |
|
The new version is missing a definition that was found in the old version. Was 'ACIServiceResponse' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2300:3 |
️❌Cross Version BreakingChange (Base on stable version): 130 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/features' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L262:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces/skus' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L1217:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/services' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L1432:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/services/{serviceName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L1504:5 |
|
The new version is missing a definition that was found in the old version. Was 'SystemData' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
|
The new version is missing a definition that was found in the old version. Was 'IdentityType' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
|
The new version is missing a definition that was found in the old version. Was 'ACIServiceResponse' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
|
The new version is missing a definition that was found in the old version. Was 'AKSVariantResponse' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
|
The new version is missing a definition that was found in the old version. Was 'AKSServiceResponse' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
|
The new version is missing a definition that was found in the old version. Was 'CreateServiceRequest' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"Schema 'AmlComputeNodesInformation' has a property 'nextLink' that is already declared the parent schema 'ComputeNodesInformation' but isn't significantly different. The property has been removed from AmlComputeNodesInformation" |
|
| "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"The schema 'components·1dsxf3l·schemas·commandjob·properties·parameters·additionalproperties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#/components/schemas/components·1dsxf3l·schemas·commandjob·properties·parameters·additionalproperties" |
|
| 💬 AutorestCore/Exception | "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @forteddyt your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
forteddyt
added
the
DoNotMerge
|
Hi @forteddyt, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 21, 2021
ArcturusZhang
approved these changes
May 10, 2021
|
@msyyc could you please take a look at the python SDK breaking changes? |
|
For python, the breaking change is ok |
ArcturusZhang
approved these changes
May 11, 2021
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
This was referenced May 11, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…to add version preview/2021-03-01-preview (Azure#12554) * Enabling java client (Azure#1) * Revert "Enabling java client (Azure#1)" (Azure#2) This reverts commit 26873d3. * Adds base for updating Microsoft.MachineLearningServices from version preview/2020-09-01-preview to version 2021-03-01-preview * Updates readme * Updates API version in new specs and examples * migrate java to own md * add mfe.json * prettier * fix example declarations in spec * add preliminary examples * update example api-version to 2021-03-01-preview * fix example validation errors * add mfe.json to 2021-03 readme * add to custom-words * Dictonary -> Dictionary * merge muzhi newVersion20210101 8ef3c1a * add java to swagger-to-sdk * update mfe.json & examples to latest * flatten nested properties * wrap ref with AllOf * prettier * [TEMP] Isolate client gen bug for easier reporting * Revert "[TEMP] Isolate client gen bug for easier reporting" This reverts commit 4f67cdf. * remove allOf wrapper for LongRunningNullResponseLongRunningOperationResponse * add some descriptions * OnlineDeploymentScaleSettings * ExportSummary no longer a resource * remove non PuP resources + add add async headers * removed unused examples * add format to integer type * add x-ms extensions to async operations * Add back LabelingJob for PuP, Add Docker discriminator definitions * add back LabelingJob examples * prettier * update modelContainer examples * added LabelingJobs_ListExportSummary * add listExportSummaries example * add missing discriminators * update to stand alone ExportSummary Resource * removed ExportSummary functionality, added remainder of missing discriminator definitions * remove ExportSummary examples * update pattern to [a-zA-Z0-9_] * proper async marking for LabelingJobs_Resume * prettier * all in:body parameters are now required * Revert "update pattern to [a-zA-Z0-9_]" This reverts commit 3e07c4a. * Revert "proper async marking for LabelingJobs_Resume" This reverts commit b111203. * change to 2020-09 to see if gate passes * Revert "change to 2020-09 to see if gate passes" This reverts commit a27c0e0. * Revert "Revert "proper async marking for LabelingJobs_Resume"" This reverts commit a0e0cf0. * Revert "Revert "update pattern to [a-zA-Z0-9_]"" This reverts commit 5e86dd0. * add orderby and top to appropriate List APIs * add LabelingJobs_ExportLabels to spec * add exportLabels example * update resume example * update with latest changes + readOnly fix * encompass non-discriminator schemas in AllOf * prettier * fix missing references + spelling error * update spec to latest contracts + address AllOf issues * reference common type api version, sub id, and rg name params * reference common type Resource definition * update mls spec to latest stable version * reference common types.json sub id, rg name, api version definitions in mls.json * reference common type systemData in mls.json * reference common type resource in mls.json * update examples to stable 2021 spec's examples * remove dangling Resource definition in mls * add pattern requirements for some parameters * move identityConfiguration out of TrialComponent and into SweepJob * remove default values from Retry-After definition * remove unused RootError and InnerErrorResponse * start deprecation of AssetPath -> Path * AssetGenerator no longer readOnly * add DockerImagePlatform usage * add InferenceContainerProperties * JobProvisioningState is ReadOnly * add environmentVariables * mark ServicePrincipalConfiguration.Properties.Secret as x-ms-secret * add various missing 'x-ms-mutability' properties * add AutoMLJob to spec * add PipelineJob * add ComponentContainer * add ComponentVersion * add datamodel, datapath, Explainability to custom-words.txt * remove incorrect x-ms-mutability props * move example to example prop * add x-ms-mutability ['read'] when readOnly: true is present * type -> dataType, enableDNNTraining -> enableDnnTraining * description updates * update examples * remove AutoMLJob, PipelineJob, Component from spec * remove Component examples * fix incorrect host * add OnlineEndpoint API + examples * update EnvironmentSpecificationVersion examples * add OnlineDeployment API + examples * update OnlineEndpoint/Deployment example version to 2021-03-01-preview * update LabelingJob example version to 2021-03-01-preview * add BatchEndpoint API + examples * decouple TrackedResource from OnlineEndpoint/OnlineDeployment * add BatchDeployment API + examples * update BatchEndpoint example api-version to 2021-03-01-preview * prettier * reference enum definitions instead of inlining them * add skipValidation query param to Datastores_CreateOrUpdate * Aks -> K8s * remove AssetPath in favor of Path * various contract updates * update examples * prettier * ServicePrincipalCredentialsTEMP probe * add PATCH Update to BatchEndpoint/Deployment * description update * label EndpointAuthKeys.PrimaryKey/SecondaryKey as secret * label EndpointAuthToken.AccessToken as secret * prettier * remove clientSecretUrl from UserAssignedIdentityMeta * add more descriptive descriptions to responses * rename most 'type' properties to something more descriptive * rename IdAssetReference's id -> assetId * rename ResourceIdentityInArm's type -> identityType * reorder responses in descending order * add x-ms-async-operation-timeout where appropriate * remove unreachable properties in Partial definitions * have 'Partial' preceed definitions, where applicable * add descriptions to various definitions/properties * misc enum reorderings * remove unusable JobType Enums (for polymorphic types) * rename all *Credentials definitions to end with 'DatastoreCredentials' * move Job definitions closer to their Polymorphic definitions * add PartialBatchEndpoint.Traffic as updatable prop * EndpointAuthKeys refactor for proper x-ms-secret usage * BatchEndpoints_ListKeys should respond with just EndpointAuthKeys * removed x-ms-secret prop from EndpointAuthToken.accessToken because EndpointAuthToken is only given directly in a post * spelling fix * redefine flavors prop to avoid anonymous type * add PE connections * add default response error * add count query param to BatchEndpoints_List * Move ComputeJobBase output to common ExperimentJobBase * redefine ResourceIdentityInArm -> ResourceIdentity * identityType -> type in examples * update example to follow new Identity definition * add missing comma to SystemAssignedUserAssigned * ResourceIdentityType -> ResourceIdentityAssignment * redefine to use FlavorData * proper secrets definition for datastores * add additional descriptions * use machineLearningServices.json version 2021-01-01 * use machineLearningServices.json 2021-04-01 * Revert "use machineLearningServices.json 2021-04-01" This reverts commit 2e7b88e. * Revert "use machineLearningServices.json version 2021-01-01" This reverts commit 8ff82a1. * use 2020-09-01-preview machineLearningServices.json spec * use common type definitions of sub id, rg name, and api version parameters * migrate mls to common-type Resource * remove unused example files * description updates * remove 'model' as a required property for online deployments * update datastore secrets, again * Update specification/machinelearningservices/resource-manager/readme.md to point to proper .md Co-authored-by: Jenny So <j-so@users.noreply.github.com> * add PrivateEndpointConnections_List * use 2021-04-01's machineLearningServices.json * use common-types where applicable * IdentityType -> IdentityConfigurationType * add PrivateEndpointConnections_List * prettier * update description * remove x-ms-client-flatten * flatten polymorphic types for better docs * update readme.java with changes * remove unused IdentityType in mls.json * Update with better examples (Azure#8) * adding descriptions * descriptions * examples * more descriptions * Fixing more descriptions * fix sweep * interactionEndpoints type -> jobEndpointType * remove extra properties wrapper from sweep get/list examples * prettier * fix flavorData representation * add id name type to examples Co-authored-by: Teddy <thtodoro@microsoft.com> * fix credscan issues * improve definition descriptions * fix typo * add unknown jobstatus enum * fix more typos * add examples and reorganize examples * fix example folder name casing * update descriptions * improve examples * prettier * migrate mfe to common-types ErrorResponse * migrate mls to common-types ErrorResponse * split select operations to separate files * fix model valiation * operation ID changes * correct readme Getting Started text * move workspace skus list to separate file * reorganize machineLearningServices.json examples * reorganize services.json examples * reorganize workspaceFeatures.json examples * reorganize workspaceSkus.json examples * bundle examples of same operation * mls.json opId Compute_ -> Computes_ * services.json opId MachineLearningService_ -> MachineLearningServices_ * Revert "mls.json opId Compute_ -> Computes_" This reverts commit 12dc59a. * revert package-lock changes * add 2021-03-01-preview tag in readme.go.md * add 2021-03-01-preview tag in readme.java.md * tag proper yaml in md * preview package must be under 'preview' subdirectory * change default tag back to package-2021-04-01 * change package-preview-2021-03 to package-2021-03-01-preview * add 'tags' as an optional query parameter to Dataversions_List * add asynchronous verbage to applicable descriptions * description grammar fix * add description to Datastores_ListSecrets response * fix flipped descriptions * use v2 common-types, not v1 for PrivateEndpointConnections_List Co-authored-by: Harneet Virk <harnvir@microsoft.com> Co-authored-by: Teddy Todorov <Teddy.Todorov@microsoft.com> Co-authored-by: zhaomuzhi <zhaoweixiong521@gmail.com> Co-authored-by: Jenny So <j-so@users.noreply.github.com> Co-authored-by: Jenny So <jenns@microsoft.com>
This was referenced Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.