Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaling plan ring #13129

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Add scaling plan ring #13129

merged 1 commit into from
Feb 26, 2021

Conversation

lordjeb
Copy link
Contributor

@lordjeb lordjeb commented Feb 24, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @lordjeb Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 24, 2021

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

    Rule Message
    1041 - AddedPropertyInResponse The new version has a new property 'ring' in response that was not found in the old version.
    New: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L4283:7
    Old: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L4283:7
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 7 Warnings warning [Detail]

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/CheckDuplicateSchemas "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"Checking for duplicate schemas,
    this could take a (long) while. Run with --verbose for more detail."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 24, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cb2ecbb. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/desktopvirtualization/mgmt/2021-02-01-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cb2ecbb. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
    • ️✔️desktopvirtualization [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cb2ecbb. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /HostPools/put/HostPool_Create
      cmderr	[Autorest]     - name: /HostPools/get/HostPool_Get
      cmderr	[Autorest]     - name: /HostPools/get/HostPool_List
      cmderr	[Autorest]     - name: /HostPools/get/HostPool_ListByResourceGroup
      cmderr	[Autorest]     - name: /HostPools/patch/HostPool_Update
      cmderr	[Autorest]     - name: /HostPools/post/HostPools_RetrieveRegistrationToken_Post
      cmderr	[Autorest]     - name: /ApplicationGroups/put/ApplicationGroup_Create
      cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_Get
      cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_List
      cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_ListByResourceGroup
      cmderr	[Autorest]     - name: /ApplicationGroups/patch/ApplicationGroups_Update
      cmderr	[Autorest]     - name: /ApplicationGroups/delete/ApplicationGroup_Delete
      cmderr	[Autorest]     - name: /MsixImages/post/MsixImage_Expand
      cmderr	[Autorest]     - name: /MSIXPackages/put/MSIXPackage_Create
      cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_Get
      cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_List
      cmderr	[Autorest]     - name: /MSIXPackages/patch/MSIXPackage_Update
      cmderr	[Autorest]     - name: /MSIXPackages/delete/MSIXPackage_Delete
      cmderr	[Autorest]     - name: /ScalingPlans/put/ScalingPlans_Create
      cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_Get
      cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListByResourceGroup
      cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListBySubscription
      cmderr	[Autorest]     - name: /ScalingPlans/get/UserSession_SendMessage_Post
      cmderr	[Autorest]     - name: /ScalingPlans/patch/ScalingPlans_Update
      cmderr	[Autorest]     - name: /ScalingPlans/delete/ScalingPlans_Delete
      cmderr	[Autorest]     - name: /HostPools/delete/HostPool_Delete
      cmderr	[Autorest]     - name: /Workspaces/put/Workspace_Create
      cmderr	[Autorest]     - name: /Workspaces/get/Workspace_Get
      cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListByResourceGroup
      cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListBySubscription
      cmderr	[Autorest]     - name: /Workspaces/patch/Workspace_Update
      cmderr	[Autorest]     - name: /Workspaces/delete/Workspace_Delete
      cmderr	[Autorest] --------------------------------------------------------
    • ️✔️desktopvirtualization [View full logs]  [Release Azure CLI Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cb2ecbb. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!
      warn	File azure-sdk-for-python_tmp/generateOutput.json not found to read
    • ️✔️azure-mgmt-desktopvirtualization [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cb2ecbb. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cb2ecbb. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-02-26 02:39:29 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-desktopvirtualization"
      cmderr	[generate.py] 2021-02-26 02:39:29 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-02-26 02:39:29 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.17 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/desktopvirtualization/azure-resourcemanager-desktopvirtualization --java.namespace=com.azure.resourcemanager.desktopvirtualization   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
      cmderr	[generate.py] 2021-02-26 02:40:16 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-02-26 02:40:16 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-02-26 02:40:16 INFO [POM][Skip] pom already has module azure-resourcemanager-desktopvirtualization
      cmderr	[generate.py] 2021-02-26 02:40:16 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-02-26 02:40:16 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-02-26 02:40:16 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] 2021-02-26 02:42:02 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-desktopvirtualization [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-02-26 02:43:19 DEBUG Got artifact_id: azure-resourcemanager-desktopvirtualization
      cmderr	[Inst] 2021-02-26 02:43:19 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-02-26 02:43:19 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-26 02:43:19 DEBUG Match jar package: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-26 02:43:19 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13129/azure-sdk-for-java/azure-resourcemanager-desktopvirtualization/azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\" -o azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-desktopvirtualization -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @lordjeb
    Copy link
    Contributor Author

    lordjeb commented Feb 25, 2021

    @weidongxu-microsoft Can you approve?

    @weidongxu-microsoft
    Copy link
    Member

    I approved, but you need approval from JeffreyRichter as this marked a breaking change (see comment above).

    @lordjeb
    Copy link
    Contributor Author

    lordjeb commented Feb 25, 2021

    @JeffreyRichter can you help approve this?

    @weidongxu-microsoft
    Copy link
    Member

    Let me when it need merged.

    @lordjeb
    Copy link
    Contributor Author

    lordjeb commented Feb 26, 2021

    @weidongxu-microsoft I'm ready for the merge whenever you are. :)

    @weidongxu-microsoft weidongxu-microsoft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 26, 2021
    @weidongxu-microsoft
    Copy link
    Member

    Breaking change proved by Jeffrey.

    @weidongxu-microsoft weidongxu-microsoft merged commit cb2ecbb into Azure:master Feb 26, 2021
    This was referenced Feb 26, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants