Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ResourceMover readme.az.md for CLI code generation #13231

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

houk-ms
Copy link
Contributor

@houk-ms houk-ms commented Mar 2, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @houk-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 2, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 2, 2021

    Swagger Generation Artifacts

    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 8c6d9ca. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      Resource not accessible by integration
      HttpError: Resource not accessible by integration
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.4.9/node_modules/@octokit/request/dist-node/index.js:66:23
          at processTicksAndRejections (internal/process/task_queues.js:93:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:305:21)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:40:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:171:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:18:20
    • ️✔️Az.ResourceMoverServiceApi [View full logs
      error	Fatal error: Resource not accessible by integration
      error	The following packages are still pending:
      error		Az.ResourceMoverServiceApi
    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 8c6d9ca. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!Error happened during package
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8c6d9ca. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-03-09 05:43:23 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-resourcemover"
      cmderr	[generate.py] 2021-03-09 05:43:23 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-03-09 05:43:23 INFO autorest --version=3.1.0 --use=@autorest/java@4.0.19 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/resourcemover/azure-resourcemanager-resourcemover --java.namespace=com.azure.resourcemanager.resourcemover   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md
      cmderr	[generate.py] 2021-03-09 05:43:58 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-03-09 05:43:58 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-03-09 05:43:58 INFO [POM][Skip] pom already has module azure-resourcemanager-resourcemover
      cmderr	[generate.py] 2021-03-09 05:43:58 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-03-09 05:43:58 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-03-09 05:43:58 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-resourcemover [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-03-09 05:46:46 DEBUG Got artifact_id: azure-resourcemanager-resourcemover
      cmderr	[Inst] 2021-03-09 05:46:46 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-03-09 05:46:46 DEBUG Got artifact: azure-resourcemanager-resourcemover-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-03-09 05:46:46 DEBUG Got artifact: azure-resourcemanager-resourcemover-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-03-09 05:46:46 DEBUG Got artifact: azure-resourcemanager-resourcemover-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-03-09 05:46:46 DEBUG Match jar package: azure-resourcemanager-resourcemover-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-03-09 05:46:46 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13231/azure-sdk-for-java/azure-resourcemanager-resourcemover/azure-resourcemanager-resourcemover-1.0.0-beta.1.jar\" -o azure-resourcemanager-resourcemover-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-resourcemover -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-resourcemover-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8c6d9ca. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md
    • ️✔️resourcemover [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8c6d9ca. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️resourcemover/mgmt/2021-01-01/resourcemover [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/resourcemover/mgmt/2019-10-01-preview/resourcemover [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New function `NetworkInterfaceResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
      info	[Changelog] - New function `UnresolvedDependencyCollectionPage.Values() []UnresolvedDependency`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsSQLDatabaseResourceSettings() (*SQLDatabaseResourceSettings, bool)`
      info	[Changelog] - New function `LoadBalancerResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsResourceSettings() (*ResourceSettings, bool)`
      info	[Changelog] - New function `VirtualNetworkResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
      info	[Changelog] - New function `*UnresolvedDependencyCollectionPage.NextWithContext(context.Context) error`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsSQLElasticPoolResourceSettings() (*SQLElasticPoolResourceSettings, bool)`
      info	[Changelog] - New function `UnresolvedDependencyCollectionPage.NotDone() bool`
      info	[Changelog] - New function `LoadBalancerResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsLoadBalancerResourceSettings() (*LoadBalancerResourceSettings, bool)`
      info	[Changelog] - New function `ResourceGroupResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
      info	[Changelog] - New function `ResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
      info	[Changelog] - New function `VirtualMachineResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
      info	[Changelog] - New function `MoveCollectionsClient.ListRequiredFor(context.Context, string, string, string) (RequiredForResourcesCollection, error)`
      info	[Changelog] - New function `UnresolvedDependencyCollection.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsLoadBalancerResourceSettings() (*LoadBalancerResourceSettings, bool)`
      info	[Changelog] - New function `UnresolvedDependencyCollectionIterator.NotDone() bool`
      info	[Changelog] - New function `AvailabilitySetResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
      info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsNetworkSecurityGroupResourceSettings() (*NetworkSecurityGroupResourceSettings, bool)`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsVirtualMachineResourceSettings() (*VirtualMachineResourceSettings, bool)`
      info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
      info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsVirtualMachineResourceSettings() (*VirtualMachineResourceSettings, bool)`
      info	[Changelog] - New function `SQLDatabaseResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsVirtualNetworkResourceSettings() (*VirtualNetworkResourceSettings, bool)`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsNetworkInterfaceResourceSettings() (*NetworkInterfaceResourceSettings, bool)`
      info	[Changelog] - New function `NetworkInterfaceResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
      info	[Changelog] - New function `*UnresolvedDependencyCollectionIterator.NextWithContext(context.Context) error`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsSQLServerResourceSettings() (*SQLServerResourceSettings, bool)`
      info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsVirtualNetworkResourceSettings() (*VirtualNetworkResourceSettings, bool)`
      info	[Changelog] - New function `SQLDatabaseResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
      info	[Changelog] - New function `NewUnresolvedDependencyCollectionIterator(UnresolvedDependencyCollectionPage) UnresolvedDependencyCollectionIterator`
      info	[Changelog] - New function `KeyVaultResourceSettings.AsNetworkSecurityGroupResourceSettings() (*NetworkSecurityGroupResourceSettings, bool)`
      info	[Changelog] - New struct `DiskEncryptionSetResourceSettings`
      info	[Changelog] - New struct `KeyVaultResourceSettings`
      info	[Changelog] - New struct `MoveCollectionPropertiesErrors`
      info	[Changelog] - New struct `NsgReference`
      info	[Changelog] - New struct `PublicIPReference`
      info	[Changelog] - New struct `RequiredForResourcesCollection`
      info	[Changelog] - New struct `Summary`
      info	[Changelog] - New struct `SummaryCollection`
      info	[Changelog] - New struct `UnresolvedDependenciesFilter`
      info	[Changelog] - New struct `UnresolvedDependenciesFilterProperties`
      info	[Changelog] - New struct `UnresolvedDependencyCollectionIterator`
      info	[Changelog] - New struct `UnresolvedDependencyCollectionPage`
      info	[Changelog] - New field `Etag` in struct `MoveCollection`
      info	[Changelog] - New field `TotalCount` in struct `MoveResourceCollection`
      info	[Changelog] - New field `SummaryCollection` in struct `MoveResourceCollection`
      info	[Changelog] - New field `Fqdn` in struct `PublicIPAddressResourceSettings`
      info	[Changelog] - New field `SummaryCollection` in struct `UnresolvedDependencyCollection`
      info	[Changelog] - New field `TotalCount` in struct `UnresolvedDependencyCollection`
      info	[Changelog] - New field `IsResolveRequired` in struct `MoveResourceProperties`
      info	[Changelog] - New field `LoadBalancerNatRules` in struct `NicIPConfigurationResourceSettings`
      info	[Changelog] - New field `PublicIP` in struct `NicIPConfigurationResourceSettings`
      info	[Changelog] - New field `NetworkSecurityGroup` in struct `SubnetResourceSettings`
      info	[Changelog] - New field `Errors` in struct `MoveCollectionProperties`
      info	[Changelog]
      info	[Changelog] Total 10 breaking change(s), 117 additive change(s).
      info	[Changelog]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8c6d9ca. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @erich-wang
    Copy link
    Member

    @jsntcy, could you take a look at python sdk failure?

    @jsntcy
    Copy link
    Member

    jsntcy commented Mar 9, 2021

    @jsntcy Yu Chen FTE, could you take a look at python sdk failure?

    This failure is not related to this change. The Python SDK generation script installed a yanked package from pypi which caused this failure. @msyyc will release a new Python SDK to fix this issue.
    I think you can just merge it by ignoring this failure.

    @msyyc
    Copy link
    Member

    msyyc commented Mar 9, 2021

    For python, please ignore the failure and we will fix it later

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants