Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.AzureActiveDirectory to add version preview/2019-01-01-preview #13621

Merged
merged 3 commits into from
Mar 26, 2021
Merged

[Hub Generated] Review request for Microsoft.AzureActiveDirectory to add version preview/2019-01-01-preview #13621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29cb554
adding australia to possible resources and cleaning up operationslist…
nickgmicrosoft Mar 25, 2021
6dde974
trying to fix python issue
nickgmicrosoft Mar 26, 2021
80667e2
fixing python issue
nickgmicrosoft Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...esource-manager/Microsoft.AzureActiveDirectory/preview/2019-01-01-preview/cpimTenant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@
},
"location": {
"type": "string",
"description": "The location in which the resource is hosted and data resides. Refer to [this documentation](https://aka.ms/B2CDataResidency) to see valid data residency locations. Please choose one of 'United States', 'Europe', and 'Asia Pacific'.",
"description": "The location in which the resource is hosted and data resides. Can be one of 'United States', 'Europe', 'Asia Pacific', or 'Australia' (preview). Refer to [this documentation](https://aka.ms/B2CDataResidency) for more information.",
"x-ms-mutability": [
"create",
"read"
Expand Down Expand Up @@ -830,7 +830,7 @@
"properties": {
"location": {
"type": "string",
"description": "The location in which the resource is hosted and data resides. Refer to [this documentation](https://aka.ms/B2CDataResidency) to see valid data residency locations. Please choose one of 'United States', 'Europe', and 'Asia Pacific'."
"description": "The location in which the resource is hosted and data resides. Can be one of 'United States', 'Europe', 'Asia Pacific', or 'Australia' (preview). Refer to [this documentation](https://aka.ms/B2CDataResidency) for more information."
},
"properties": {
"type": "object",
Expand Down
48 changes: 6 additions & 42 deletions ...er/Microsoft.AzureActiveDirectory/preview/2019-01-01-preview/examples/OperationsList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,67 +8,31 @@
"200": {
"body": {
"value": [
{
"name": "Microsoft.AzureActiveDirectory/register/action",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "Microsoft.AzureActiveDirectory Resource Provider",
"operation": "Registers the Microsoft.AzureActiveDirectory Resource Provider",
"description": "Registers the Microsoft.AzureActiveDirectory Resource Provider"
}
},
{
"name": "Microsoft.AzureActiveDirectory/guestUsages/read",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "GuestUsagesResource",
"operation": "read",
"description": "Read call for Guest Usages Resource"
}
},
{
"name": "Microsoft.AzureActiveDirectory/guestUsages/write",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "GuestUsagesResource",
"operation": "write",
"description": "Create or Update call for Guest Usages Resource"
}
},
{
"name": "Microsoft.AzureActiveDirectory/guestUsages/delete",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "GuestUsagesResource",
"operation": "delete",
"description": "Delete call for Guest Usages Resource"
}
},
{
"name": "Microsoft.AzureActiveDirectory/b2cDirectories/read",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "GuestUsagesResource",
"resource": "B2cDirectoriesResource",
"operation": "read",
"description": "Read call for Guest Usages Resource"
"description": "Read call for Azure AD B2C tenant resource"
}
},
{
"name": "Microsoft.AzureActiveDirectory/b2cDirectories/write",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "GuestUsagesResource",
"resource": "B2cDirectoriesResource",
"operation": "write",
"description": "Create or Update call for Guest Usages Resource"
"description": "Create or Update call for Azure AD B2C tenant resource"
}
},
{
"name": "Microsoft.AzureActiveDirectory/b2cDirectories/delete",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "GuestUsagesResource",
"resource": "B2cDirectoriesResource",
"operation": "delete",
"description": "Delete call for Guest Usages Resource"
"description": "Delete call for Azure AD B2C tenant resource"
}
},
{
Expand Down
36 changes: 0 additions & 36 deletions ...er/Microsoft.AzureActiveDirectory/preview/2020-05-01-preview/examples/OperationsList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,42 +43,6 @@
"operation": "delete",
"description": "Delete call for Guest Usages Resource"
}
},
{
"name": "Microsoft.AzureActiveDirectory/b2cDirectories/read",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "GuestUsagesResource",
"operation": "read",
"description": "Read call for Guest Usages Resource"
}
},
{
"name": "Microsoft.AzureActiveDirectory/b2cDirectories/write",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "GuestUsagesResource",
"operation": "write",
"description": "Create or Update call for Guest Usages Resource"
}
},
{
"name": "Microsoft.AzureActiveDirectory/b2cDirectories/delete",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "GuestUsagesResource",
"operation": "delete",
"description": "Delete call for Guest Usages Resource"
}
},
{
"name": "Microsoft.AzureActiveDirectory/checkNameAvailability",
"display": {
"provider": "Microsoft.AzureActiveDirectory",
"resource": "Check Name Availability",
"operation": "Get Check Name Availability",
"description": "Check if resource name is available."
}
}
]
}
Expand Down
3 changes: 1 addition & 2 deletions specification/cpim/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ These are the global settings for the azureadb2c APIs.
title: CPIMConfigurationClient
description: CPIM Configuration Client
openapi-type: arm
tag: package-2020-05-01-preview
tag: package-2019-01-01-preview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why to decrease the default version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cli team is working on sdk generation for the 2019-01-01-preview version, not the 2020-05-01-preview. We're prioritization 2019-01-01-preview at this time.

```

### Tag: package-2019-01-01-preview
Expand Down Expand Up @@ -60,7 +60,6 @@ This is not used by Autorest itself.

```yaml $(swagger-to-sdk)
swagger-to-sdk:
- repo: azure-sdk-for-python
- repo: azure-sdk-for-python-track2
- repo: azure-sdk-for-go
```
Expand Down
1 change: 1 addition & 0 deletions specification/cpim/resource-manager/readme.python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ These settings apply only when `--track2` is specified on the command line.
azure-arm: true
license-header: MICROSOFT_MIT_NO_VERSION
package-name: azure-mgmt-azureadb2c
package-version: 1.0.0b2
no-namespace-folders: true
python-base-folder: azureadb2c/azure-mgmt-azureadb2c/azure/mgmt/azureadb2c
```
Expand Down