Add Extensions Async API and other fixes #13709

NarayanThiru · 2021-03-29T18:54:00Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-03-29T18:54:04Z

Hi, @NarayanThiru Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-03-29T18:54:04Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2021-03-01/kubernetesconfiguration.json <---> new: stable/2021-03-01/kubernetesconfiguration.json

️⚠️LintDiff: 6 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- kubernetesconfiguration/resource-manager/readme.md tag:package-preview-2021-05
- kubernetesconfiguration/resource-manager/readme.md tag:package-2021-03
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- kubernetesconfiguration/resource-manager/readme.md tag:package-preview-2021-05
- kubernetesconfiguration/resource-manager/readme.md tag:package-2021-03

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L615
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'operations' with immediate parent 'Extension', must have a list by immediate parent operation. Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L290
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: forceDelete Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/extensions.json#L192
⚠️ R4021 - DescriptionAndTitleMissing	'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: common-types/resource-management/v2/types.json#L158
⚠️ R4021 - DescriptionAndTitleMissing	'sku' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: common-types/resource-management/v2/types.json#L165
⚠️ R4021 - DescriptionAndTitleMissing	'plan' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: common-types/resource-management/v2/types.json#L172

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4017 - TopLevelResourcesListBySubscription	The top-level resource 'SourceControlConfiguration' does not have list by subscription operation, please add it. Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L388
`❌` R4017 - TopLevelResourcesListBySubscription	The top-level resource 'SourceControlConfiguration' does not have list by subscription operation, please add it. Location: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L426
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L526
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L564

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️🔄Cross Version BreakingChange (Base on preview version) inProgress [Detail]

️❌Cross Version BreakingChange (Base on stable version): 8 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2021-03-01/kubernetesconfiguration.json <---> new: preview/2021-05-01-preview/kubernetesconfiguration.json

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: common-types/resource-management/v2/types.json#L317:9 Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L303:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v2/types.json#L280:9 Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L317:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v2/types.json#L285:9 Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L323:9
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L49:9 Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L49:9
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L98:9 Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L98:9
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L162:9 Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L162:9
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: Microsoft.KubernetesConfiguration/preview/2021-05-01-preview/kubernetesconfiguration.json#L214:9 Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L214:9
`❌` 1036 - ConstraintChanged	The new version has a different 'pattern' value than the previous one. New: common-types/resource-management/v2/types.json#L644:5 Old: Microsoft.KubernetesConfiguration/stable/2021-03-01/kubernetesconfiguration.json#L598:5

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-03-29T18:54:05Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 98790a7d4e2c8f3d58aad82bdd590f5ba4c5c40f. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.SourceControlConfiguration [View full logs] [Preview SDK Changes]
- Az.SourceControlConfiguration.0.1.0.nupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 98790a7d4e2c8f3d58aad82bdd590f5ba4c5c40f. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️kubernetesconfiguration/mgmt/2021-03-01/kubernetesconfiguration [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/kubernetesconfiguration/mgmt/2021-05-01-preview/kubernetesconfiguration [View full logs] [Preview SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/kubernetesconfiguration/mgmt/2020-07-01-preview/kubernetesconfiguration [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/kubernetesconfiguration/mgmt/2019-11-01-preview/kubernetesconfiguration [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 98790a7d4e2c8f3d58aad82bdd590f5ba4c5c40f. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️kubernetesconfiguration [View full logs] [Preview Schema Changes]

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from 98790a7d4e2c8f3d58aad82bdd590f5ba4c5c40f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-kubernetesconfiguration [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation SourceControlConfigurationsOperations.delete
info	[Changelog]   - Added operation group ExtensionsOperations
info	[Changelog]   - Added operation group OperationStatusOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation SourceControlConfigurationsOperations.list has a new signature
info	[Changelog]   - Operation SourceControlConfigurationsOperations.get has a new signature
info	[Changelog]   - Operation SourceControlConfigurationsOperations.create_or_update has a new signature
info	[Changelog]   - Model Resource no longer has parameter system_data
info	[Changelog]   - Model ProxyResource no longer has parameter system_data
info	[Changelog]   - Operation Operations.list has a new signature
info	[Changelog]   - Removed operation SourceControlConfigurationsOperations.begin_delete

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 98790a7d4e2c8f3d58aad82bdd590f5ba4c5c40f. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-04-14 02:40:55 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-kubernetesconfiguration;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-04-14 02:40:55 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-04-14 02:40:55 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.23 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration --java.namespace=com.azure.resourcemanager.kubernetesconfiguration   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md
cmderr	[generate.py] 2021-04-14 02:41:24 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-kubernetesconfiguration
cmderr	[generate.py] 2021-04-14 02:41:24 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-04-14 02:41:24 INFO [POM][Skip] pom already has module azure-resourcemanager-kubernetesconfiguration
cmderr	[generate.py] 2021-04-14 02:41:24 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-04-14 02:41:24 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-04-14 02:41:24 INFO [POM][Skip] pom already has module sdk/kubernetesconfiguration
cmderr	[generate.py] 2021-04-14 02:41:24 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-kubernetesconfiguration [View full logs] [Preview SDK Changes]

cmderr	[Inst] 2021-04-14 02:44:37 DEBUG Got artifact_id: azure-resourcemanager-kubernetesconfiguration
cmderr	[Inst] 2021-04-14 02:44:37 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-04-14 02:44:37 DEBUG Got artifact: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar
cmderr	[Inst] 2021-04-14 02:44:37 DEBUG Match jar package: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar
cmderr	[Inst] 2021-04-14 02:44:37 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13709/azure-sdk-for-java/azure-resourcemanager-kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar\" -o azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-kubernetesconfiguration -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 98790a7d4e2c8f3d58aad82bdd590f5ba4c5c40f. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md

️✔️@azure/arm-kubernetesconfiguration [View full logs] [Preview SDK Changes]

azure-arm-kubernetesconfiguration-3.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/sourceControlConfigurationClient.js → ./dist/arm-kubernetesconfiguration.js...
cmderr	[npmPack] created ./dist/arm-kubernetesconfiguration.js in 314ms

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-03-29T18:54:05Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-workflow-bot · 2021-03-29T18:56:02Z

Hi @NarayanThiru, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

NarayanThiru · 2021-04-13T22:36:30Z

@chunyu3, @ArcturusZhang, I made the fixes suggested earlier to unify the package version, and pushed them. Can you tell me

What do I need to do for the Breaking Changes - since this is a Preview api version; and
How to fix the azure-sdk-for-go error I am getting?

ArcturusZhang · 2021-04-14T01:37:35Z

@chunyu3, @ArcturusZhang, I made the fixes suggested earlier to unify the package version, and pushed them. Can you tell me

What do I need to do for the Breaking Changes - since this is a Preview api version; and

How to fix the azure-sdk-for-go error I am getting?

Hi @NarayanThiru sorry the go pipeline failure is due to some issues in the pipeline itself. I will get this fixed very soon and rerun the pipelines the failure would be gone

ArcturusZhang · 2021-04-14T02:35:16Z

/azp run

azure-pipelines · 2021-04-14T02:35:29Z

Azure Pipelines successfully started running 2 pipeline(s).

NarayanThiru · 2021-04-14T04:02:34Z

Thank you very much @ArcturusZhang for fixing the go readme issue.
Can you tell me what I need to do for the Cross Version Breaking Change? I reviewed the Breaking Change process, which notes that the process is not applicable for Preview versions.

NarayanThiru · 2021-04-14T18:14:19Z

@chunyu3 , @ArcturusZhang , can you please help merge this PR into the dev branch - over-riding the Cross-Version BreakingChange requirement, since this is Preview api-version?

This reverts commit b78af6e.

…5 01 preview (#14302) * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview * Updates readme * Updates API version in new specs and examples * Add Extensions Async API and other fixes (#13709) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Revert "Add Extensions Async API and other fixes (#13709)" (#13972) This reverts commit b78af6e. * Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (#13992) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Remove extensions resource in the route of ListAsyncOperations at Cluster scope * Remove extension parameter in the spec * Remove extension parameter from route of ListAsycOperations * Add Origin property to Available Operations response body * Make Identity property nullable * Add Get, List Extension Types (#13562) * Add Get, List Extension Types * style check fixes * - update spec - rename and update example files - fix validation errors * fix examples * - update readme.md - generate example files with oav - try to fix some new validation errors * more validation fixes * add ExtensionTypeVersion_List * - update readme for SDKs - update examples * fix typo and linting * rename ExtensionTypeVersions_List * - address comments - update list extension versions based on location * fix list versions route * fix tag and unused parameters in spec file * fix autorest validatoin errors * udpate readme * update readme * try to fix sdk validation warnings * - prettier fix - revert changes to types.json * fix pageable missing itemName Co-authored-by: Carlo Cardella <carloc@microsoft.com> Co-authored-by: chunyu3 <chunyu@microsoft.com>

…5 01 preview (Azure#14302) * Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview * Updates readme * Updates API version in new specs and examples * Add Extensions Async API and other fixes (Azure#13709) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Revert "Add Extensions Async API and other fixes (Azure#13709)" (Azure#13972) This reverts commit b78af6e. * Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (Azure#13992) * Add Extensions Async API and other fixes * Re-add missed out changes * Fix validation errors, remove UpdateExtension.json * Update Readme.md * Add back files removed accidentally * Revert accidental changes & fix readme.md * Remove SourceControlConfig from this api version * Fix Readme.md error for go package * Fix Go readme issues * Fix Go readme issues - revert accidental change * Fix Go readme issues * Add kubernetesconfiguration GA version to this version Tag for SDK * Fix Operations api descriptions * Fix spelling mistakes * Update ApiVersionParameter reference in kubernetesconfiguration * Fix review suggestions * Add SourceControlConfiguration resourceType to this api-version * Updated readme files for the added SourceControlConfiguration resource type * Fix readme files to revert to previous + additions for new api-version * Consolidated common definitions to avoid duplication errors * Rename definitions folder - fix Avocado error * Consolidated common definitions reference * Fix definitions.json * Fix go readme * Remove extensions resource in the route of ListAsyncOperations at Cluster scope * Remove extension parameter in the spec * Remove extension parameter from route of ListAsycOperations * Add Origin property to Available Operations response body * Make Identity property nullable * Add Get, List Extension Types (Azure#13562) * Add Get, List Extension Types * style check fixes * - update spec - rename and update example files - fix validation errors * fix examples * - update readme.md - generate example files with oav - try to fix some new validation errors * more validation fixes * add ExtensionTypeVersion_List * - update readme for SDKs - update examples * fix typo and linting * rename ExtensionTypeVersions_List * - address comments - update list extension versions based on location * fix list versions route * fix tag and unused parameters in spec file * fix autorest validatoin errors * udpate readme * update readme * try to fix sdk validation warnings * - prettier fix - revert changes to types.json * fix pageable missing itemName Co-authored-by: Carlo Cardella <carloc@microsoft.com> Co-authored-by: chunyu3 <chunyu@microsoft.com>

Add Extensions Async API and other fixes

613e0b8

NarayanThiru requested a review from ArcturusZhang as a code owner March 29, 2021 18:54

openapi-assignment-bot bot assigned chunyu3 Mar 29, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 29, 2021

openapi-sdkautomation bot mentioned this pull request Mar 29, 2021

[AutoPR azure-resourcemanager-kubernetesconfiguration] Add Extensions Async API and other fixes AzureSDKAutomation/azure-sdk-for-java#8059

Draft

NarayanThiru added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Mar 29, 2021

NarayanThiru added 2 commits March 29, 2021 13:42

Re-add missed out changes

f2e6a2e

Fix validation errors, remove UpdateExtension.json

2320485

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Mar 29, 2021

This was referenced Mar 29, 2021

[AutoPR kubernetesconfiguration] Add Extensions Async API and other fixes AzureSDKAutomation/azure-resource-manager-schemas#2115

Draft

[AutoPR Az.SourceControlConfiguration] Add Extensions Async API and other fixes AzureSDKAutomation/azure-powershell#179

Draft

Update Readme.md

e73b110

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Mar 29, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Mar 29, 2021

Add back files removed accidentally

c45449a

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Mar 29, 2021

Revert accidental changes & fix readme.md

f551b9a

Fix readme files to revert to previous + additions for new api-version

a2a101c

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Apr 13, 2021

Consolidated common definitions to avoid duplication errors

c427baf

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Apr 13, 2021

openapi-sdkautomation bot mentioned this pull request Apr 13, 2021

[AutoPR track2_azure-mgmt-kubernetesconfiguration] Add Extensions Async API and other fixes AzureSDKAutomation/azure-sdk-for-python#5106

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Python label Apr 13, 2021

Rename definitions folder - fix Avocado error

8517136

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Apr 13, 2021

openapi-sdkautomation bot mentioned this pull request Apr 13, 2021

[AutoPR kubernetesconfiguration/resource-manager] Add Extensions Async API and other fixes AzureSDKAutomation/azure-resource-manager-schemas#2454

Draft

openapi-pipeline-app bot removed the CI-BreakingChange-Python label Apr 13, 2021

Consolidated common definitions reference

483ad6b

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Apr 13, 2021

Fix definitions.json

38bf687

openapi-pipeline-app bot added the CI-BreakingChange-Python label Apr 13, 2021

Fix go readme

ff3497a

chunyu3 merged commit b78af6e into Azure:dev-kubernetesconfiguration-Microsoft.KubernetesConfiguration-2021-05-01-preview Apr 15, 2021

chunyu3 added a commit that referenced this pull request Apr 16, 2021

Revert "Add Extensions Async API and other fixes (#13709)"

7d91ca8

This reverts commit b78af6e.

chunyu3 mentioned this pull request Apr 16, 2021

Revert "Add Extensions Async API and other fixes" #13972

Merged

chunyu3 added a commit that referenced this pull request Apr 16, 2021

Revert "Add Extensions Async API and other fixes (#13709)" (#13972)

f3dca56

This reverts commit b78af6e.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Extensions Async API and other fixes #13709

Add Extensions Async API and other fixes #13709

NarayanThiru commented Mar 29, 2021 •

edited

Loading

openapi-workflow-bot bot commented Mar 29, 2021

openapi-pipeline-app bot commented Mar 29, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 29, 2021 •

edited

Loading

openapi-workflow-bot bot commented Mar 29, 2021

openapi-workflow-bot bot commented Mar 29, 2021

NarayanThiru commented Apr 13, 2021 •

edited

Loading

ArcturusZhang commented Apr 14, 2021

ArcturusZhang commented Apr 14, 2021

azure-pipelines bot commented Apr 14, 2021

NarayanThiru commented Apr 14, 2021

NarayanThiru commented Apr 14, 2021

Add Extensions Async API and other fixes #13709

Add Extensions Async API and other fixes #13709

Conversation

NarayanThiru commented Mar 29, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 29, 2021

openapi-pipeline-app bot commented Mar 29, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 29, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Mar 29, 2021

openapi-workflow-bot bot commented Mar 29, 2021

NarayanThiru commented Apr 13, 2021 • edited Loading

ArcturusZhang commented Apr 14, 2021

ArcturusZhang commented Apr 14, 2021

azure-pipelines bot commented Apr 14, 2021

NarayanThiru commented Apr 14, 2021

NarayanThiru commented Apr 14, 2021

NarayanThiru commented Mar 29, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 29, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 29, 2021 •

edited

Loading

NarayanThiru commented Apr 13, 2021 •

edited

Loading