[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-04-01-preview #14137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @susolank Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'PUT' operation 'Vaults_UpdateAccessPolicy' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json#L272 |
|
| 'PUT' operation 'PrivateEndpointConnections_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json#L810 |
|
| 'PUT' operation 'MHSMPrivateEndpointConnections_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L593 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/preview/2021-04-01-preview/keys.json#L488 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json#L1448 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json#L1469 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json#L1499 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json#L1542 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json#L1570 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json#L965 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"keyvault/resource-manager/readme.md",
"tag":"package-preview-2021-04",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"keyvault/resource-manager/readme.md",
"tag":"package-preview-2021-04",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"keyvault/resource-manager/readme.md",
"tag":"package-preview-2021-04",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
This was referenced Apr 26, 2021
This was referenced Apr 26, 2021
jlichwa
approved these changes
Apr 26, 2021
jkapil
approved these changes
Apr 26, 2021
jiacheng-L
approved these changes
Apr 26, 2021
heaths
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
What about export that is in 7.3-preview currently for data plane? /cc @herveyw-msft
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run unifiedPipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @susolank. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
NewApiVersionRequired reason: |
allenjzhang
added
the
Approved-BreakingChange
|
I approved the breaking change. Please fix the model validation and we can proceed. |
|
@allenjzhang When you get a chance, can you merge this PR because I don't have permission to do it. No additional changes will be made in this PR. |
This was referenced Jun 9, 2021
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
…preview/2021-04-01-preview (Azure#14137) * Support release key permission for vault access policies * Remove 400 and 409 error codes from response object * Fix model validation issues * Remove extra 400 from deleted vault response
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…preview/2021-04-01-preview (Azure#14137) * Support release key permission for vault access policies * Remove 400 and 409 error codes from response object * Fix model validation issues * Remove extra 400 from deleted vault response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.