Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01 #14225

Conversation

swagatmishra2007
Copy link
Contributor

@swagatmishra2007 swagatmishra2007 commented May 4, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
    We are targeting to be in public preview by July for private links (which are the new api's added in this new APIVersion
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
    The swagger would be published (as public preview) in june. We expect to go to a stable version a month after that
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @swagatmishra2007 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 4, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 3 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateLinkResources_ListByBotResource' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1379
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'Bot', must have a list by immediate parent operation.
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1422
    ⚠️ R4014 - AllResourcesMustHaveGetOperation The resource 'PrivateLinkResource' does not have get operation, please add it.
    Location: Microsoft.BotService/preview/2021-05-01-preview/privatelinks.json#L121


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.BotService/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L742
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1528
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1650
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1680
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1723
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1796
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1833
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1869
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1929
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1970
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 18 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with latest preview version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/Connections/{connectionName}/listWithSecrets' removed or restructured?
    Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L722:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/Connections/{connectionName}' removed or restructured?
    Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L767:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.BotService/checkEnterpriseChannelNameAvailability' removed or restructured?
    Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1016:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/enterpriseChannels' removed or restructured?
    Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1058:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/enterpriseChannels/{resourceName}' removed or restructured?
    Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1100:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EnterpriseChannelCheckNameAvailabilityRequest' removed or renamed?
    New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1422:3
    Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1306:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EnterpriseChannel' removed or renamed?
    New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1422:3
    Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1306:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EnterpriseChannelProperties' removed or renamed?
    New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1422:3
    Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L1306:3
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L766:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2873:5
    Old: Microsoft.BotService/preview/2018-07-12/botservice.json#L2607:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"botservice/resource-manager/readme.md",
    "tag":"package-preview-2021-05",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"botservice/resource-manager/readme.md",
    "tag":"package-preview-2021-05",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"botservice/resource-manager/readme.md",
    "tag":"package-preview-2021-05",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 4, 2021

    Swagger Generation Artifacts

    ️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=218738&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
    "detail":"Run.ps1 failed with exit code 1 "
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-botservice - 1.0.0
    +	Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_region
    +	Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_subscription_key
    +	Model DirectLineSpeechChannelProperties no longer has parameter cognitive_services_subscription_id
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 0c3188f. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/botservice/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.BotService [View full logs]  [Release SDK Changes]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
      cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Generated/OperationResultsOperations.cs(28,100): error CS0535: 'OperationResultsOperations' does not implement interface member 'IOperationResultsOperations.GetWithHttpMessagesAsync(string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/src/Microsoft.Azure.Management.BotService.csproj]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0c3188f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-botservice [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model BotProperties has a new parameter schema_transformation_version
      info	[Changelog]   - Model BotProperties has a new parameter is_isolated
      info	[Changelog]   - Added operation group OperationResultsOperations
      info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
      info	[Changelog]   - Added operation group HostSettingsOperations
      info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model DirectLineSpeechChannelProperties no longer has parameter cognitive_services_subscription_id
      info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_subscription_key
      info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_region
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0c3188f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-botservice [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
      info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
      info	[Changelog]   - Added operation group OperationResultsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model DirectLineSpeechChannelProperties no longer has parameter cognitive_services_subscription_id
      info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_region
      info	[Changelog]   - Model DirectLineSpeechChannelProperties has a new required parameter cognitive_service_subscription_key
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0c3188f. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️botservice/mgmt/2021-03-01/botservice [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 40 items here, please refer to log for details.
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameDirectLineSpeechChannel` has been removed
      info	[Changelog] - Const `SkuTierStandard` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameTelegramChannel` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameKikChannel` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameAlexaChannel` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameLineChannel` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameSlackChannel` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameDirectLineChannel` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameSmsChannel` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameFacebookChannel` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameWebChatChannel` has been removed
      info	[Changelog] - Const `SkuNameF0` has been removed
      info	[Changelog] - Const `SkuNameS1` has been removed
      info	[Changelog] - Const `ChannelNameBasicChannelChannelNameChannel` has been removed
      info	[Changelog] - Function `ServiceProviderParameter.MarshalJSON` has been removed
      info	[Changelog] - Function `ConnectionItemName.MarshalJSON` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `Free`
      info	[Changelog] - New const `ChannelNameAlexaChannel1`
      info	[Changelog] - New const `ChannelNameSlackChannel1`
      info	[Changelog] - New const `Standard`
      info	[Changelog] - New const `ChannelNameWebChatChannel1`
      info	[Changelog] - New const `ChannelNameChannel`
      info	[Changelog] - New const `ChannelNameDirectLineChannel1`
      info	[Changelog] - New const `ChannelNameEmailChannel1`
      info	[Changelog] - New const `ChannelNameKikChannel1`
      info	[Changelog] - New const `S1`
      info	[Changelog] - New const `ChannelNameTelegramChannel1`
      info	[Changelog] - New const `ChannelNameSkypeChannel1`
      info	[Changelog] - New const `ChannelNameFacebookChannel1`
      info	[Changelog] - New const `ChannelNameSmsChannel1`
      info	[Changelog] - New const `ChannelNameMsTeamsChannel1`
      info	[Changelog] - New const `ChannelNameDirectLineSpeechChannel1`
      info	[Changelog] - New const `F0`
      info	[Changelog] - New const `ChannelNameLineChannel1`
      info	[Changelog]
      info	[Changelog] Total 20 breaking change(s), 18 additive change(s).
      info	[Changelog]
    • ️✔️preview/botservice/mgmt/2018-07-12/botservice [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/botservice/mgmt/2017-12-01/botservice [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0c3188f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️botservice [View full logs]  [Release Schema Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0c3188f. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/botservice/resource-manager/readme.md
    • ️✔️@azure/arm-botservice [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/azureBotService.js → ./dist/arm-botservice.js...
      cmderr	[npmPack] created ./dist/arm-botservice.js in 352ms
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @swagatmishra2007, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @swagatmishra2007
    Copy link
    Contributor Author

    Changes in this PR-

    • Add support for operationresults, so that we can support async ARM api's
    • Add support for private links

    @swagatmishra2007 swagatmishra2007 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 4, 2021
    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
    @raych1
    Copy link
    Member

    raych1 commented May 21, 2021

    @swagatmishra2007 , model validation failed due to duplicated model name of Resource in botservice.json and types.json from common-type folder. Can you reference the common Resource model from common-type folder since this is a new API version?

    @swagatmishra2007
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @swagatmishra2007
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @lirenhe
    Copy link
    Member

    lirenhe commented May 26, 2021

    No breaking change compared with the latest version.

    @lirenhe lirenhe merged commit 0c3188f into Azure:master May 26, 2021
    @swagatmishra2007 swagatmishra2007 deleted the dev-botservice-Microsoft.BotService-2021-05-01 branch May 26, 2021 01:06
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …n preview/2021-05-01 (Azure#14225)
    
    * Adds base for updating Microsoft.BotService from version stable/2021-03-01 to version 2021-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add operation result api's to support async operations
    
    * add private links support
    
    * fix issues in examples
    
    * fix more errors
    
    * fix prettier issues
    
    * add missing private links operation. some more fixes
    
    * fix model validation errors
    
    * address comments
    
    * remove properties bag
    
    * remove unintentional change in unrelated api
    
    * update example
    
    * change api version to have preview suffix
    
    * fix lint and model validation errors
    
    * change folder name to preview to match api version
    
    * add breaking changes from base branch
    
    * fix api version
    
    * fix prettier warnings
    
    * update readme
    
    * Update specification/botservice/resource-manager/readme.md
    
    Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
    
    * check if rename works
    
    * remove system data since it's not support for other botservice
    
    * remove references to common types.json resource to avoid conflicts
    
    Co-authored-by: Swagat Mishra <swagatm@microsoft.com>
    Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python CI-FixRequiredOnFailure Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants