Fix wrong definition for share ACL and update policy id description #14477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hi, @zfchen95 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a property found in the old version. Was 'start' renamed or removed? New: Microsoft.Storage/stable/2021-04-01/file.json#L983:7 Old: Microsoft.Storage/stable/2021-04-01/file.json#L983:7 |
|
The new version is missing a property found in the old version. Was 'expiry' renamed or removed? New: Microsoft.Storage/stable/2021-04-01/file.json#L983:7 Old: Microsoft.Storage/stable/2021-04-01/file.json#L983:7 |
|
The new version has a new property 'startTime' in response that was not found in the old version. New: Microsoft.Storage/stable/2021-04-01/file.json#L983:7 Old: Microsoft.Storage/stable/2021-04-01/file.json#L983:7 |
|
The new version has a new property 'expiryTime' in response that was not found in the old version. New: Microsoft.Storage/stable/2021-04-01/file.json#L983:7 Old: Microsoft.Storage/stable/2021-04-01/file.json#L983:7 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/ListAccountSas' Location: Microsoft.Storage/stable/2021-04-01/storage.json#L605 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/ListServiceSas' Location: Microsoft.Storage/stable/2021-04-01/storage.json#L650 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/blobServices/{BlobServicesName}' Location: Microsoft.Storage/stable/2021-04-01/blob.json#L58 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/fileServices/{FileServicesName}' Location: Microsoft.Storage/stable/2021-04-01/file.json#L61 |
|
The response of operation:'BlobContainers_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-04-01/blob.json#L320 |
|
The response of operation:'BlobContainers_GetImmutabilityPolicy' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-04-01/blob.json#L553 |
|
The response of operation:'FileShares_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-04-01/file.json#L362 |
|
The response of operation:'Queue_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-04-01/queue.json#L266 |
|
The response of operation:'Table_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-04-01/table.json#L245 |
|
The response of operation:'BlobContainers_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2021-04-01/blob.json#L215 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"storage/resource-manager/readme.md",
"tag":"package-2021-04",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"storage/resource-manager/readme.md",
"tag":"package-2021-04",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
"readme":"storage/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:475" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"storage/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:479" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"storage/resource-manager/readme.md", "tag":"package-2021-04", "details":"Error: Plugin prechecker reported failure." |
| 💬 AutorestCore/Exception | "readme":"storage/resource-manager/readme.md", "tag":"package-2021-04", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @zfchen95, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
NewApiVersionRequired reason: |
This was referenced May 19, 2021
blueww
reviewed
May 20, 2021
| @@ -981,12 +981,12 @@ | |||
| }, | |||
| "AccessPolicy": { | |||
| "properties": { | |||
| "start": { | |||
| "startTime": { | |||
There was a problem hiding this comment.
The property name change is breaking, and we have already released SDK for the API version.
Please check with ARM review team if we need a new API version to add the change?
|
Add @JeffreyRichter for breaking change review. |
JeffreyRichter
approved these changes
May 25, 2021
JeffreyRichter
added
the
Approved-BreakingChange
Juliehzl
approved these changes
May 26, 2021
|
@msyyc do you have any concern for python SDK breaking change issue. |
blueww
approved these changes
May 26, 2021
|
For python, the breaking change is ok |
This was referenced May 26, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.