Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVS 2021-06-01 fixes for SDKs #14573

Merged
merged 2 commits into from
May 28, 2021
Merged

AVS 2021-06-01 fixes for SDKs #14573

merged 2 commits into from
May 28, 2021

Conversation

ctaggart
Copy link
Contributor

The AVS 2021-06-01 was merged 10 days ago in #14215. This removes breaking changes for the AVS .NET SDK by reordering two parameters to match the same order as the previous stable 2021-03-20 API.

The folder name for the Java multi-api was incorrect, so I updated that as well.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ctaggart Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 27, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 27, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - avs/mgmt/2021-06-01/avs - v54.3.0
    ️✔️azure-sdk-for-go - avs/mgmt/2020-03-20/avs - v54.3.0
    ️✔️azure-sdk-for-go - preview/avs/mgmt/2021-01-01-preview/avs - v54.3.0
    azure-sdk-for-go - preview/avs/mgmt/2020-07-17-preview/avs - v54.3.0
    +	Const `Cancelled` type has been changed from `ClusterProvisioningState` to `AddonProvisioningState`
    +	Const `Deleting` type has been changed from `ClusterProvisioningState` to `AddonProvisioningState`
    +	Const `Failed` type has been changed from `ClusterProvisioningState` to `AddonProvisioningState`
    +	Const `OnetimeRotate` has been removed
    +	Const `Succeeded` type has been changed from `ClusterProvisioningState` to `AddonProvisioningState`
    +	Const `Updating` type has been changed from `ClusterProvisioningState` to `AddonProvisioningState`
    +	Const `VcsaAdminRotateEnumOnetimeRotate` has been removed
    +	Field `NsxtPassword` of struct `PrivateCloudUpdateProperties` has been removed
    +	Field `VcenterPassword` of struct `PrivateCloudUpdateProperties` has been removed
    +	Function `PossibleNsxtAdminRotateEnumValues` has been removed
    +	Function `PossibleVcsaAdminRotateEnumValues` has been removed
    +	Type of `PrivateCloudProperties.NsxtPassword` has been changed from `NsxtAdminRotateEnum` to `*string`
    +	Type of `PrivateCloudProperties.VcenterPassword` has been changed from `VcsaAdminRotateEnum` to `*string`
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 87fe548. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      Resource not accessible by integration
      HttpError: Resource not accessible by integration
          at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.4.15/node_modules/@octokit/request/dist-node/index.js:68:23
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:330:21)
          at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
          at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
          at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Az.VMwareSolutionApi [View full logs
      error	Fatal error: Resource not accessible by integration
      error	The following packages are still pending:
      error		Az.VMwareSolutionApi
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 87fe548. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
    • ️✔️@azure/arm-avs [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/avsClient.js → ./dist/arm-avs.js...
      cmderr	[npmPack] created ./dist/arm-avs.js in 543ms
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 87fe548. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-avs [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model MetricDimension has a new parameter internal_name
      info	[Changelog]   - Model MetricDimension has a new parameter to_be_exported_for_shoebox
      info	[Changelog]   - Model PrivateCloud has a new parameter external_cloud_links
      info	[Changelog]   - Added operation PrivateCloudsOperations.rotate_nsxt_password
      info	[Changelog]   - Added operation PrivateCloudsOperations.rotate_vcenter_password
      info	[Changelog]   - Added operation group GlobalReachConnectionsOperations
      info	[Changelog]   - Added operation group DatastoresOperations
      info	[Changelog]   - Added operation group WorkloadNetworksOperations
      info	[Changelog]   - Added operation group ScriptPackagesOperations
      info	[Changelog]   - Added operation group ScriptCmdletsOperations
      info	[Changelog]   - Added operation group CloudLinksOperations
      info	[Changelog]   - Added operation group AddonsOperations
      info	[Changelog]   - Added operation group ScriptExecutionsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation HcxEnterpriseSitesOperations.create_or_update has a new signature
      info	[Changelog]   - Operation AuthorizationsOperations.create_or_update has a new signature
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 87fe548. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Avs [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 87fe548. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️avs/mgmt/2021-06-01/avs [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️avs/mgmt/2020-03-20/avs [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New field `InternalName` in struct `MetricDimension`
      info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
      info	[Changelog]
    • ️✔️preview/avs/mgmt/2021-01-01-preview/avs [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/avs/mgmt/2020-07-17-preview/avs [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 30 items here, please refer to log for details.
      info	[Changelog] - New struct `AddonProperties`
      info	[Changelog] - New struct `AddonSrmProperties`
      info	[Changelog] - New struct `AddonUpdate`
      info	[Changelog] - New struct `AddonUpdateProperties`
      info	[Changelog] - New struct `AddonsClient`
      info	[Changelog] - New struct `AddonsCreateOrUpdateFuture`
      info	[Changelog] - New struct `AddonsDeleteFuture`
      info	[Changelog] - New struct `PrivateCloudsRotateNsxtPasswordFuture`
      info	[Changelog] - New struct `PrivateCloudsRotateVcenterPasswordFuture`
      info	[Changelog] - New struct `WorkloadNetworkDNSService`
      info	[Changelog] - New struct `WorkloadNetworkDNSServiceProperties`
      info	[Changelog] - New struct `WorkloadNetworkDNSServicesList`
      info	[Changelog] - New struct `WorkloadNetworkDNSServicesListIterator`
      info	[Changelog] - New struct `WorkloadNetworkDNSServicesListPage`
      info	[Changelog] - New struct `WorkloadNetworkDNSZone`
      info	[Changelog] - New struct `WorkloadNetworkDNSZoneProperties`
      info	[Changelog] - New struct `WorkloadNetworkDNSZonesList`
      info	[Changelog] - New struct `WorkloadNetworkDNSZonesListIterator`
      info	[Changelog] - New struct `WorkloadNetworkDNSZonesListPage`
      info	[Changelog] - New struct `WorkloadNetworksCreateDNSServiceFuture`
      info	[Changelog] - New struct `WorkloadNetworksCreateDNSZoneFuture`
      info	[Changelog] - New struct `WorkloadNetworksDeleteDNSServiceFuture`
      info	[Changelog] - New struct `WorkloadNetworksDeleteDNSZoneFuture`
      info	[Changelog] - New struct `WorkloadNetworksUpdateDNSServiceFuture`
      info	[Changelog] - New struct `WorkloadNetworksUpdateDNSZoneFuture`
      info	[Changelog] - New field `InternalName` in struct `MetricDimension`
      info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
      info	[Changelog]
      info	[Changelog] Total 11 breaking change(s), 220 additive change(s).
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 87fe548. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-05-28 09:14:14 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-avs;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-05-28 09:14:14 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-05-28 09:14:14 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.29 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/avs/azure-resourcemanager-avs --java.namespace=com.azure.resourcemanager.avs   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
      cmderr	[generate.py] 2021-05-28 09:14:58 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-avs
      cmderr	[generate.py] 2021-05-28 09:14:58 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-05-28 09:14:58 INFO [POM][Skip] pom already has module azure-resourcemanager-avs
      cmderr	[generate.py] 2021-05-28 09:14:58 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-05-28 09:14:58 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-05-28 09:14:58 INFO [POM][Skip] pom already has module sdk/avs
      cmderr	[generate.py] 2021-05-28 09:14:58 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-avs [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-05-28 09:19:13 DEBUG Got artifact_id: azure-resourcemanager-avs
      cmderr	[Inst] 2021-05-28 09:19:13 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-05-28 09:19:13 DEBUG Got artifact: azure-resourcemanager-avs-1.0.0-beta.2-sources.jar
      cmderr	[Inst] 2021-05-28 09:19:13 DEBUG Got artifact: azure-resourcemanager-avs-1.0.0-beta.2-javadoc.jar
      cmderr	[Inst] 2021-05-28 09:19:13 DEBUG Got artifact: azure-resourcemanager-avs-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-05-28 09:19:13 DEBUG Match jar package: azure-resourcemanager-avs-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-05-28 09:19:13 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14573/azure-sdk-for-java/azure-resourcemanager-avs/azure-resourcemanager-avs-1.0.0-beta.2.jar\" -o azure-resourcemanager-avs-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-avs -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-avs-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 87fe548. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️vmware [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ctaggart
    Copy link
    Contributor Author

    @akning-ms, CI looks good. The failure for changes from the preview API azure-sdk-for-go - preview/avs/mgmt/2020-07-17-preview/avs is expected.

    @akning-ms akning-ms merged commit 87fe548 into master May 28, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * fix .NET constructors
    
    * fix java multiapi
    @JackTn JackTn deleted the AVS/dotnet branch June 16, 2022 00:47
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants