Vipinhas/Remove Cluster max capacity and Add new Api Version #14953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @vipinhas Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
ghost
added
the
customer-reported
|
Thank you for your contribution vipinhas! We will review the pull request and get back to you soon. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a property found in the old version. Was 'maxCapacity' renamed or removed? New: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L624:7 Old: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L624:7 |
️⚠️LintDiff: 2 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
| Rule | Message |
|---|---|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: capacityReservationLevel Location: Microsoft.OperationalInsights/stable/2021-06-01/Clusters.json#L636 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: capacityReservationLevel Location: Microsoft.OperationalInsights/stable/2021-06-01/Workspaces.json#L422 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/intelligencePacks/{intelligencePackName}/Disable' Location: Microsoft.OperationalInsights/stable/2020-08-01/IntelligencePacks.json#L37 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/intelligencePacks/{intelligencePackName}/Enable' Location: Microsoft.OperationalInsights/stable/2020-08-01/IntelligencePacks.json#L78 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/intelligencePacks/{intelligencePackName}/Disable' Location: Microsoft.OperationalInsights/stable/2020-08-01/IntelligencePacks.json#L37 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/intelligencePacks/{intelligencePackName}/Enable' Location: Microsoft.OperationalInsights/stable/2020-08-01/IntelligencePacks.json#L78 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/DataSources.json#L79 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/DataSources.json#L126 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/DataSources.json#L167 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/DataSources.json#L217 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/IntelligencePacks.json#L71 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/IntelligencePacks.json#L112 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/operationalinsights/resource-manager/readme.md tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2020-10 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 19 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-06-01/Clusters.json compared with base:stable/2020-10-01/Clusters.json
- current:stable/2021-06-01/Clusters.json compared with base:preview/2020-03-01-preview/Clusters.json
- current:stable/2021-06-01/Workspaces.json compared with base:stable/2020-10-01/Workspaces.json
- current:stable/2021-06-01/Workspaces.json compared with base:preview/2020-03-01-preview/Workspaces.json
| Rule | Message |
|---|---|
|
The new version is missing a property found in the old version. Was 'maxCapacity' renamed or removed? New: Microsoft.OperationalInsights/stable/2021-06-01/Clusters.json#L624:7 Old: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L624:7 |
The following breaking changes are detected by comparison with latest preview version:
Only 10 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'WorkspacePurgeBodyFilters-value' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-08-01/WorkspacePurge.json#/components/schemas/WorkspacePurgeBodyFilters-value" |
|
| "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2021-06", "details":"The schema 'WorkspacePurgeBodyFilters-value' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/operationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-08-01/WorkspacePurge.json#/components/schemas/WorkspacePurgeBodyFilters-value" |
|
| 💬 AutorestCore/Exception | "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10-only", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10-only", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2021-06", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2021-06", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"operationalinsights/resource-manager/readme.md",
"tag":"package-2020-10-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"operationalinsights/resource-manager/readme.md",
"tag":"package-2020-10",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"operationalinsights/resource-manager/readme.md",
"tag":"package-2020-10",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @vipinhas, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jun 23, 2021
This was referenced Jun 23, 2021
akning-ms
reviewed
Jun 24, 2021
...ionalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json
Show resolved
Hide resolved
|
For your new API version, can you follow ARM guideline to submit a separate PR in this way? |
vipinhas
changed the title
|
I was requested to create a new PR to follow ARM guidelines and corrected the PR -
Vipinhas/Remove Cluster max capacity by vipinhas · Pull Request #14953 · Azure/azure-rest-api-specs (github.com)<https://github.com/Azure/azure-rest-api-specs/pull/14953/files>
Vipinhas/add new api version la1 by vipinhas · Pull Request #14966 · Azure/azure-rest-api-specs (github.com)<#14966>
…________________________________
From: Arthur Ning ***@***.***>
Sent: Thursday, June 24, 2021 5:21 AM
To: Azure/azure-rest-api-specs ***@***.***>
Cc: Victoria Pinhasov ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/azure-rest-api-specs] Vipinhas/add new api version la (#14953)
For your new API version, can you follow ARM guideline to submit a separate PR in this way?
Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2FAzure%2Fazure-rest-api-specs%2Fpull%2F14953%23issuecomment-867281887&data=04%7C01%7CVictoria.Pinhasov%40microsoft.com%7C16832eb2c7194961bd9f08d936b6ba10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637600980723425680%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=mevMCGqGuxm%2F3T59NybpZ0TEee82ECMqd95biiCbDrw%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fnotifications%2Funsubscribe-auth%2FATSJB4OFES52LX2CT3NKS4TTUKJBJANCNFSM47GAMJAA&data=04%7C01%7CVictoria.Pinhasov%40microsoft.com%7C16832eb2c7194961bd9f08d936b6ba10%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637600980723435676%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Rg64gyGooaEDcpZQSP5teKCaBkU5%2FDbs73rv3Q3cGHk%3D&reserved=0>.
|
vipinhas
changed the title
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @vipinhas your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Hey @chiragg4u, |
pilor
reviewed
Jun 29, 2021
...ionalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json
Show resolved
Hide resolved
| "capacityReservationLevel": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "description": "The capacity reservation level for this workspace, when CapacityReservation sku is selected.", |
There was a problem hiding this comment.
Please specify what units this is using
pilor
added
the
ARMChangesRequested
…pecs into vipinhas/addNewApiVersion_LA
pilor
added
ARMSignedOff
This was referenced Jul 9, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…4953) * removing read only property, no longer in use - NOT a breaking change * Remove max capacity resrvation level from cluster * Add new api version to support new capaciry res level tiers * remove new api version * add copy of last dir. for new api-version * add new api version changes * add units
26 tasks
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.