Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing operation name #15125

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Fixing operation name #15125

merged 3 commits into from
Jul 8, 2021

Conversation

paterasMSFT
Copy link
Contributor

This PR renames the newly added ComputeNodeExtensions_List operation to ComputeNodeExtensions_List. The backing service code has not been made public, so this should not cause any consumer issues.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify - Fixing operation name.
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. This week.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet. Already published.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@paterasMSFT paterasMSFT requested a review from lmazuel July 8, 2021 21:30
@openapi-workflow-bot
Copy link

Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 8, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1008 - ModifiedOperationId The operation id has been changed from 'ComputeNodeExtensions_List' to 'ComputeNodeExtension_List'. This will impact generated code.
    New: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L10778:7
    Old: Microsoft.Batch/stable/2021-06-01.14.0/BatchService.json#L10778:7
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️🔄CredScan inProgress [Detail]
    ️🔄[Staging] SDK Track2 Validation inProgress [Detail]
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 8, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9b59c69. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️batch/2021-06-01.14.0/batch [View full logs]  [Release SDK Changes] 
      info	[Changelog] This is a new package
    • ️✔️batch/2020-09-01.12.0/batch [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️batch/2020-03-01.11.0/batch [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️batch/2019-08-01.10.0/batch [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️batch/2019-06-01.9.0/batch [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️batch/2018-12-01.8.0/batch [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️batch/2018-08-01.7.0/batch [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️batch/2018-03-01.6.1/batch [View full logs]  
      info	[Changelog] No exported changes
    • ️✔️batch/2017-05-01.5.0/batch [View full logs]  
      info	[Changelog] No exported changes
    ️❌ azure-sdk-for-js failed [Detail]
    • ❌Failed [Logs]Release - Generate from 9b59c69. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/batch/data-plane/readme.md
cmdout	[Autorest] WARNING: HEAD 'getPropertiesFromTask' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getPropertiesFromComputeNode' method missing 404 status code section -- this might be unintentional.
    • ❌@azure/batch [View full logs]  [Release SDK Changes] 
      error	Script return with result [failed] code [2] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js/sdk/batch/batch]: npm pack --silent
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @paterasMSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 8, 2021
    Closed
    lmazuel
    lmazuel approved these changes Jul 8, 2021
    View reviewed changes
    Copy link
    Member

    @lmazuel lmazuel left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Confirmed by email it's Swagger only on non-shippeed SDK, and not server changes

    @lmazuel lmazuel merged commit 9b59c69 into master Jul 8, 2021
    @lmazuel lmazuel deleted the paterasMSFT/computenodeextensionlist branch July 8, 2021 21:37
    This was referenced Jul 8, 2021
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @paterasMSFT @mkarmark
    Fixing operation name (Azure#15125)
    d84ffda 
    * Fixed operation name.

* Fixed readme.

* Fixed titles.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @lmazuel lmazuel lmazuel approved these changes

    @matthchr matthchr Awaiting requested review from matthchr

    @xingwu1 xingwu1 Awaiting requested review from xingwu1

    Assignees

    @tjprescott tjprescott

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @paterasMSFT @lmazuel @tjprescott