Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NetAppFiles] s360 fixes to 2021-01 #15213

Merged
merged 6 commits into from
Aug 27, 2021
Merged

[NetAppFiles] s360 fixes to 2021-01 #15213

merged 6 commits into from
Aug 27, 2021

Conversation

audunn
Copy link
Member

@audunn audunn commented Jul 15, 2021 •
edited
Loading

With this PR we are attempting to address S360 findings in our swagger and service

Swagger Completeness: Exploring Unified Platform for Azure NetApp Files (msftcloudes.com)
https://vnext.s360.msftcloudes.com/blades/unifiedplatform?blade=KPI:6dc4e485-2d1b-449c-a224-30b183391437~SLA:3~AssignedTo:All~Forums:All~_loc:UnifiedPlatform&def=&peopleBasedNodes=shanem_team;andche_team&tile=&global=4:8d05d9ca-054e-46a9-b16a-f3e4a8d2bfdc

Swagger Correctness: Exploring Unified Platform for Azure NetApp Files (msftcloudes.com)
https://vnext.s360.msftcloudes.com/blades/unifiedplatform?blade=KPI:cf751b97-2c95-420f-baa8-9a16e8643a5b~SLA:3~AssignedTo:All~Forums:All~_loc:UnifiedPlatform&def=&peopleBasedNodes=shanem_team;andche_team&tile=&global=4:8d05d9ca-054e-46a9-b16a-f3e4a8d2bfdc

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @zhenglaizhang
    Copy link
    Contributor

    /azp run

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 15, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 21 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3947:9
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3830:9
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L210:5
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'etag' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3067:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2996:7
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'etag' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3366:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3290:7
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'etag' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3642:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3531:7
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'etag' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4501:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4384:7
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'backupPolicyId' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4956:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4834:7
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'etag' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L5018:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4891:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'supportedAggregationTypes' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2844:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2807:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'supportedTimeGrainTypes' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2844:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2807:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'internalMetricName' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2844:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2807:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'sourceMdmAccount' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2844:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2807:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'sourceMdmNamespace' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2844:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2807:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'encryptionType' in response that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3413:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3332:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'etag' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3067:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L2996:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'etag' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3366:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3290:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'encryptionType' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3413:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3332:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'etag' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3642:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L3531:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'etag' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4501:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4384:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'backupPolicyId' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4956:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4834:7
    ❌ 1045 - AddedOptionalProperty The new version has a new optional property 'etag' that was not found in the old version.
    New: Microsoft.NetApp/stable/2021-04-01/netapp.json#L5018:7
    Old: Microsoft.NetApp/stable/2021-04-01/netapp.json#L4891:7
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ Modeler/MissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2019-05-01",
    "details":"The schema 'paths·sd6gve·subscriptions-subscriptionid-providers-microsoft-netapp-locations-location-checknameavailability·parameters·0·schema' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-05-01/netapp.json#/components/schemas/paths·sd6gve·subscriptions-subscriptionid-providers-microsoft-netapp-locations-location-checknameavailability·parameters·0·schema"
    ⚠️ Modeler/MissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2019-05-01",
    "details":"The schema 'paths·1mttsht·subscriptions-subscriptionid-providers-microsoft-netapp-locations-location-checkfilepathavailability·parameters·0·schema' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/netapp/resource-manager/Microsoft.NetApp/stable/2019-05-01/netapp.json#/components/schemas/paths·1mttsht·subscriptions-subscriptionid-providers-microsoft-netapp-locations-location-checkfilepathavailability·parameters·0·schema"
    💬 AutorestCore/Exception "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2021-06-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2021-06-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2021-06-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2021-04-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2021-04-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2021-02-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2021-02-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-12-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-12-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-11-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-11-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-08-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-08-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-07-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-07-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-06-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-06-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-05-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-05-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-03-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-03-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-02-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-02-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2019-11-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2019-11-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2019-10-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2019-10-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2019-08-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2019-08-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2019-07-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 15, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-netapp - 4.0.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2021-04-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2021-02-01/netapp - v56.3.0
    ❌azure-sdk-for-go - netapp/mgmt/2020-12-01/netapp - v56.3.0
    ❌azure-sdk-for-go - netapp/mgmt/2020-11-01/netapp - v56.3.0
    ❌azure-sdk-for-go - netapp/mgmt/2020-09-01/netapp - v56.3.0
    ❌azure-sdk-for-go - netapp/mgmt/2020-08-01/netapp - v56.3.0
    ❌azure-sdk-for-go - netapp/mgmt/2020-07-01/netapp - v56.3.0
    ❌azure-sdk-for-go - netapp/mgmt/2020-06-01/netapp - v56.3.0
    ❌azure-sdk-for-go - netapp/mgmt/2020-05-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2020-03-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2020-02-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-11-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-10-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-08-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-07-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-06-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2019-05-01/netapp - v56.3.0
    ️✔️azure-sdk-for-go - preview/netapp/mgmt/2021-04-01-preview/netapp - v56.3.0
    ️✔️azure-sdk-for-go - preview/netapp/mgmt/2017-08-15/netapp - v56.3.0
    ️✔️azure-sdk-for-go - netapp/mgmt/2021-06-01/netapp - v56.3.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 969a255. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-netapp        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model BackupPolicyPatch has a new parameter backup_policy_id
info	[Changelog]   - Model BackupPolicyDetails has a new parameter backup_policy_id
info	[Changelog]   - Model SnapshotPolicy has a new parameter etag
info	[Changelog]   - Model CapacityPool has a new parameter etag
info	[Changelog]   - Model CapacityPool has a new parameter encryption_type
info	[Changelog]   - Model NetAppAccount has a new parameter etag
info	[Changelog]   - Model BackupPolicy has a new parameter backup_policy_id
info	[Changelog]   - Model BackupPolicy has a new parameter etag
info	[Changelog]   - Model Volume has a new parameter default_user_quota_in_ki_bs
info	[Changelog]   - Model Volume has a new parameter clone_progress
info	[Changelog]   - Model Volume has a new parameter etag
info	[Changelog]   - Model Volume has a new parameter is_default_quota_enabled
info	[Changelog]   - Model Volume has a new parameter avs_data_store
info	[Changelog]   - Model Volume has a new parameter default_group_quota_in_ki_bs
info	[Changelog]   - Model VolumePatch has a new parameter is_default_quota_enabled
info	[Changelog]   - Model VolumePatch has a new parameter default_user_quota_in_ki_bs
info	[Changelog]   - Model VolumePatch has a new parameter default_group_quota_in_ki_bs
info	[Changelog]   - Model MetricSpecification has a new parameter internal_metric_name
info	[Changelog]   - Model MetricSpecification has a new parameter source_mdm_account
info	[Changelog]   - Model MetricSpecification has a new parameter supported_aggregation_types
info	[Changelog]   - Model MetricSpecification has a new parameter source_mdm_namespace
info	[Changelog]   - Model MetricSpecification has a new parameter supported_time_grain_types
info	[Changelog]   - Added operation AccountsOperations.list_by_subscription
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model BackupPolicyPatch no longer has parameter yearly_backups_to_keep
info	[Changelog]   - Model BackupPolicyDetails no longer has parameter yearly_backups_to_keep
info	[Changelog]   - Model BackupPolicy no longer has parameter yearly_backups_to_keep
    ️❌ azure-sdk-for-net failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 969a255. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ❌Microsoft.Azure.Management.NetApp        [View full logs]         [Release SDK Changes]      
      cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/netapp/Microsoft.Azure.Management.NetApp/tests/ResourceTests/ANFBackupPolicyTests.cs(291,17): error CS0117: 'BackupPolicy' does not contain a definition for 'YearlyBackupsToKeep' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/netapp/Microsoft.Azure.Management.NetApp/tests/Microsoft.Azure.Management.NetApp.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/netapp/Microsoft.Azure.Management.NetApp/tests/ResourceTests/ANFBackupPolicyTests.cs(291,17): error CS0117: 'BackupPolicy' does not contain a definition for 'YearlyBackupsToKeep' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/netapp/Microsoft.Azure.Management.NetApp/tests/Microsoft.Azure.Management.NetApp.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 969a255. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
    • ️✔️@azure/arm-netapp        [View full logs]         [Release SDK Changes]      
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/azureNetAppFilesManagementClient.js → ./dist/arm-netapp.js...
cmderr	[npmPack] created ./dist/arm-netapp.js in 481ms
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 969a255. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️netapp/mgmt/2021-06-01/netapp        [View full logs]         [Release SDK Changes]      
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2021-04-01/netapp        [View full logs]       
            Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `Etag` in struct `BackupPolicy`
info	[Changelog] - New field `SystemData` in struct `BackupPolicy`
info	[Changelog] - New field `Etag` in struct `Volume`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 19 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2021-02-01/netapp        [View full logs]       
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-12-01/netapp        [View full logs]         Breaking Change Detected
            Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `QosTypeManual`
info	[Changelog] - New const `Scheduled`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-11-01/netapp        [View full logs]         Breaking Change Detected
            Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `QosTypeAuto`
info	[Changelog] - New const `QosTypeManual`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-09-01/netapp        [View full logs]         Breaking Change Detected
            Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `Scheduled`
info	[Changelog] - New const `QosTypeManual`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-08-01/netapp        [View full logs]         Breaking Change Detected
            Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `QosTypeAuto`
info	[Changelog] - New const `QosTypeManual`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-07-01/netapp        [View full logs]         Breaking Change Detected
            Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `QosTypeManual`
info	[Changelog] - New const `Scheduled`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-06-01/netapp        [View full logs]         Breaking Change Detected
            Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `Scheduled`
info	[Changelog] - New const `QosTypeManual`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-05-01/netapp        [View full logs]         Breaking Change Detected
            Only show 6 items here, please refer to log for details.
      info	[Changelog] - New const `Scheduled`
info	[Changelog] - New const `Manual`
info	[Changelog] - New function `PossibleBackupTypeValues() []BackupType`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 3 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2020-03-01/netapp        [View full logs]       
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-02-01/netapp        [View full logs]       
            Only show 6 items here, please refer to log for details.
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-11-01/netapp        [View full logs]       
            Only show 6 items here, please refer to log for details.
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-10-01/netapp        [View full logs]       
            Only show 6 items here, please refer to log for details.
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-08-01/netapp        [View full logs]       
            Only show 6 items here, please refer to log for details.
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-07-01/netapp        [View full logs]       
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2019-06-01/netapp        [View full logs]       
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2019-05-01/netapp        [View full logs]       
      info	[Changelog] No exported changes
    • ️✔️preview/netapp/mgmt/2021-04-01-preview/netapp        [View full logs]       
      info	[Changelog] This is a new package
    • ️✔️preview/netapp/mgmt/2017-08-15/netapp        [View full logs]       
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-java warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 969a255. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-08-27 10:04:27 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-netapp;1.0.0-beta.5;1.0.0-beta.6"
cmderr	[generate.py] 2021-08-27 10:04:27 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.6"
cmderr	[generate.py] 2021-08-27 10:04:27 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.36 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/netapp/azure-resourcemanager-netapp --java.namespace=com.azure.resourcemanager.netapp   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
cmderr	[generate.py] 2021-08-27 10:05:03 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-netapp
cmderr	[generate.py] 2021-08-27 10:05:03 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-08-27 10:05:03 INFO [POM][Skip] pom already has module azure-resourcemanager-netapp
cmderr	[generate.py] 2021-08-27 10:05:03 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-08-27 10:05:03 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-08-27 10:05:03 INFO [POM][Skip] pom already has module sdk/netapp
cmderr	[generate.py] 2021-08-27 10:05:03 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-netapp        [View full logs]         [Release SDK Changes]      
      cmderr	[Inst] 2021-08-27 10:08:01 DEBUG Got artifact_id: azure-resourcemanager-netapp
cmderr	[Inst] 2021-08-27 10:08:01 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-08-27 10:08:01 DEBUG Got artifact: azure-resourcemanager-netapp-1.0.0-beta.6-javadoc.jar
cmderr	[Inst] 2021-08-27 10:08:01 DEBUG Got artifact: azure-resourcemanager-netapp-1.0.0-beta.6-sources.jar
cmderr	[Inst] 2021-08-27 10:08:01 DEBUG Got artifact: azure-resourcemanager-netapp-1.0.0-beta.6.jar
cmderr	[Inst] 2021-08-27 10:08:01 DEBUG Match jar package: azure-resourcemanager-netapp-1.0.0-beta.6.jar
cmderr	[Inst] 2021-08-27 10:08:01 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15213/azure-sdk-for-java/azure-resourcemanager-netapp/azure-resourcemanager-netapp-1.0.0-beta.6.jar\" -o azure-resourcemanager-netapp-1.0.0-beta.6.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-netapp -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-netapp-1.0.0-beta.6.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 969a255. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️netapp        [View full logs]         [Release Schema Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @azure-pipelines


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
Azure Pipelines successfully started running 1 pipeline(s).
    
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    NewApiVersionRequired reason:
     
    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.  

     EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @openapi-workflow-bot


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi @audunn, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. 
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
     If you want to know the production traffic statistic, please see ARM Traffic statistic. 
     If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
          
    
  
    
    
  
    

  
    
      
    
  This was referenced Jul 15, 2021

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
  This was referenced Jul 15, 2021

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    





    

      
    
  
        



    

      
    
  
      

    

  
    
  @ghost


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      



      

  
    

  
    
    
    
      

      
            ghost
  

      

      

      commented


        Aug 1, 2021


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi, @audunn. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR.  If you want to refresh the PR, please remove no-recent-activity label.
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            





    

      
    
  
      

    

  
    
  @audunn


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  Author


  
    

  
    
    
    
      

      
            audunn
  

      

      

      commented


        Aug 1, 2021


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Can we get this review?
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    




        
    
  
      

    

  
    
  @ruowan


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  
    

  
    
    
    
      

      
            ruowan
  

      

      

      commented


        Aug 2, 2021


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Hi, Your PR has breaking chnage. Could you go through breaking change review? #15213 (comment)
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


        
    
  
      

    

  
    
  @audunn


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  Author


  
    

  
    
    
    
      

      
            audunn
  

      

      

      commented


        Aug 10, 2021


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    We are still waiting on breaking change review
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


        
    
  
        



    

        
    
  
            


    
    
    
    
      
    
    
    
    

      

          @JeffreyRichter
JeffreyRichter




          added
  the 

  Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374
 label


      Aug 13, 2021

    
    
  
    





    

        
    
  
      

    

  
    
  @audunn


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  Author


  
    

  
    
    
    
      

      
            audunn
  

      

      

      commented


        Aug 19, 2021


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    Can we move this along now that Breanking changes reivew is done}
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


        
    
  
      

    

  
    
  @audunn


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  Author


  
    

  
    
    
    
      

      
            audunn
  

      

      

      commented


        Aug 23, 2021


      
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    @ruowan can we move this along now?
    
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


        
    
  
        



    

        
    
  
          
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Aug 26, 2021
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    

    





    

        
    
  
        



    

        
    
  
          
    
  
    
    
  
    
  
    


        @ruowan
  ruowan



        merged commit 969a255
      into

      
  
    Azure:main
  


    Aug 27, 2021

  
    

    


    

  
    
  
    
    
  
    

  
    
      
    
  This was referenced Aug 27, 2021

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Merged

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

  

    
  
    
  
  
    
      ghost

      pushed a commit
        to Azure/azure-resource-manager-schemas
      that referenced
      this pull request

    
      Aug 27, 2021
    
    
    
      

    
  
    
    
    
      

    
  
    
  
    

    


      
    
        
          [ReleasePR netapp] [NetAppFiles] s360 fixes to 2021-01 (#1868)
        

          
            
          

      
    

      
    
          

    
    
    

  

    


      
    

      
    
      
    

      
      
    
        
          29b85f1
        
      
    
    
    
  
    
    
    
      
    Create to sync Azure/azure-rest-api-specs#15213
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/netapp?expand=1)
    
    
    

    

    
    
  
    

    

  
    
  
    
    
  
    

  
    
      
    
    @openapi-sdkautomation
openapi-sdkautomation
bot


    mentioned this pull request
    
      Aug 27, 2021
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    

  



    



  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
    @ruowan
  
    ruowan



          
            
              
            
          
          ruowan approved these changes

        
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
    @ruowan
  
    ruowan
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    Approved-BreakingChange

  DO NOT USE! OBSOLETE label. See  https://github.com/Azure/azure-sdk-tools/issues/6374
  

    CI-BreakingChange-Go

  

    FixS360



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

        
          

    

  
      
    
  
    
    
    
      4 participants
    
    
    
    
        
          @audunn 
        
          @zhenglaizhang 
        
          @ruowan 
        
          @JeffreyRichter