Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 #15615

Conversation

magesh-jambulingam
Copy link

@magesh-jambulingam magesh-jambulingam commented Aug 11, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @magesh-jambulingam Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 11, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 11, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-costmanagement - 2.0.0
    +	Model ExportExecution no longer has parameter tags
    +	Model QueryFilter no longer has parameter dimensions
    +	Model QueryFilter no longer has parameter tags
    +	Model QueryResult no longer has parameter e_tag
    +	Model QueryResult no longer has parameter location
    +	Model QueryResult no longer has parameter sku
    +	Model ReportConfigFilter has a new signature
    +	Model View no longer has parameter currency
    +	Model View no longer has parameter data_set
    +	Model View no longer has parameter date_range
    +	Model View no longer has parameter include_monetary_commitment
    +	Operation ExportsOperations.get has a new signature
    +	Operation ExportsOperations.list has a new signature
    +	Removed operation group GenerateReservationDetailsReportOperations
    +	Removed operation group SettingsOperations
    ️✔️azure-sdk-for-go - costmanagement/mgmt/2021-01-01/costmanagement - v56.1.0
    ️✔️azure-sdk-for-go - costmanagement/mgmt/2020-06-01/costmanagement - v56.1.0
    ️✔️azure-sdk-for-go - costmanagement/mgmt/2019-11-01/costmanagement - v56.1.0
    ️✔️azure-sdk-for-go - costmanagement/mgmt/2019-10-01/costmanagement - v56.1.0
    ️✔️azure-sdk-for-go - costmanagement/mgmt/2019-01-01/costmanagement - v56.1.0
    ️✔️azure-sdk-for-go - costmanagement/mgmt/2018-05-31/costmanagement - v56.1.0
    ️✔️azure-sdk-for-go - preview/costmanagement/mgmt/2019-03-01/costmanagement - v56.1.0
    ️✔️azure-sdk-for-go - preview/costmanagement/mgmt/2018-08-01-preview/costmanagement - v56.1.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 17ebcee3c21d0c1fb14a197c05f41856f1951269. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.CostManagement [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 17ebcee3c21d0c1fb14a197c05f41856f1951269. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️costmanagement/mgmt/2021-01-01/costmanagement [View full logs]  [Preview SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️costmanagement/mgmt/2020-06-01/costmanagement [View full logs
      info	[Changelog] No exported changes
    • ️✔️costmanagement/mgmt/2019-11-01/costmanagement [View full logs
      info	[Changelog] No exported changes
    • ️✔️costmanagement/mgmt/2019-10-01/costmanagement [View full logs
      info	[Changelog] No exported changes
    • ️✔️costmanagement/mgmt/2019-01-01/costmanagement [View full logs
      info	[Changelog] No exported changes
    • ️✔️costmanagement/mgmt/2018-05-31/costmanagement [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/costmanagement/mgmt/2019-03-01/costmanagement [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/costmanagement/mgmt/2018-08-01-preview/costmanagement [View full logs
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 17ebcee3c21d0c1fb14a197c05f41856f1951269. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-costmanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ExportProperties has a new parameter run_history
      info	[Changelog]   - Model ExportProperties has a new parameter next_run_time_estimate
      info	[Changelog]   - Model CommonExportProperties has a new parameter run_history
      info	[Changelog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
      info	[Changelog]   - Model ExportExecution has a new parameter error
      info	[Changelog]   - Model ExportExecution has a new parameter e_tag
      info	[Changelog]   - Model View has a new parameter dataset
      info	[Changelog]   - Model QueryFilter has a new parameter tag
      info	[Changelog]   - Model QueryFilter has a new parameter not_property
      info	[Changelog]   - Model QueryFilter has a new parameter dimension
      info	[Changelog]   - Model Export has a new parameter run_history
      info	[Changelog]   - Model Export has a new parameter next_run_time_estimate
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter dataset of model QueryDefinition is now required
      info	[Changelog]   - Parameter dataset of model ForecastDefinition is now required
      info	[Changelog]   - Operation ExportsOperations.get has a new signature
      info	[Changelog]   - Operation ExportsOperations.list has a new signature
      info	[Changelog]   - Model QueryResult no longer has parameter sku
      info	[Changelog]   - Model QueryResult no longer has parameter location
      info	[Changelog]   - Model QueryResult no longer has parameter e_tag
      info	[Changelog]   - Model ExportExecution no longer has parameter tags
      info	[Changelog]   - Model View no longer has parameter include_monetary_commitment
      info	[Changelog]   - Model View no longer has parameter currency
      info	[Changelog]   - Model View no longer has parameter data_set
      info	[Changelog]   - Model View no longer has parameter date_range
      info	[Changelog]   - Model QueryFilter no longer has parameter tags
      info	[Changelog]   - Model QueryFilter no longer has parameter dimensions
      info	[Changelog]   - Model ReportConfigFilter has a new signature
      info	[Changelog]   - Removed operation group GenerateReservationDetailsReportOperations
      info	[Changelog]   - Removed operation group SettingsOperations
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 17ebcee3c21d0c1fb14a197c05f41856f1951269. Azure CLI Automation 14.0.0
      Only show 120 items here, please refer to log for details.
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /Alerts/get/BillingAccountAlerts
      cmderr	[Autorest]     - name: /Alerts/get/BillingProfileAlerts
      cmderr	[Autorest]     - name: /Alerts/get/DepartmentAlerts
      cmderr	[Autorest]     - name: /Alerts/get/EnrollmentAccountAlerts
      cmderr	[Autorest]     - name: /Alerts/get/ExternalBillingAccountAlerts
      cmderr	[Autorest]     - name: /Alerts/get/ExternalSubscriptionAlerts
      cmderr	[Autorest]     - name: /Alerts/get/InvoiceSectionAlerts
      cmderr	[Autorest]     - name: /Alerts/get/ResourceGroupAlerts
      cmderr	[Autorest]     - name: /Alerts/get/ResourceGroupAlerts
      cmderr	[Autorest]     - name: /Alerts/get/SubscriptionAlerts
      cmderr	[Autorest]     - name: /Alerts/get/SubscriptionAlerts
      cmderr	[Autorest]     - name: /Alerts/patch/ResourceGroupAlerts
      cmderr	[Autorest]     - name: /Alerts/patch/SubscriptionAlerts
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsList-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsList-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsListExpandAndTop-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsListWithFilter-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsList-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsListExpandAndTop-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsListWithFilter-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsListExpandAndTop-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsListWithFilter-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListExpandAndTop-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListWithFilter-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/ExternalBillingAccountDimensionList
      cmderr	[Autorest]     - name: /Dimensions/get/ExternalSubscriptionDimensionList
      cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsList-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsListExpandAndTop-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsListWithFilter-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsListExpandAndTop-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsListWithFilter-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/ResourceGroupDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/SubscriptionDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByBillingAccount
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByDepartment
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByManagementGroup
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByResourceGroup
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateBySubscription
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByBillingAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByDepartment
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByManagementGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByResourceGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportGetBySubscription
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByBillingAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByDepartment
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByManagementGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByResourceGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetBySubscription
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByBillingAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByDepartment
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByManagementGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByResourceGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetBySubscription
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByBillingAccount
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByDepartment
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByManagementGroup
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByResourceGroup
      cmderr	[Autorest]     - name: /Exports/post/ExportRunBySubscription
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByBillingAccount
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByDepartment
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByManagementGroup
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByResourceGroup
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteBySubscription
      cmderr	[Autorest]     - name: /Forecast/post/BillingAccountForecast
      cmderr	[Autorest]     - name: /Forecast/post/BillingProfileForecast
      cmderr	[Autorest]     - name: /Forecast/post/DepartmentForecast
      cmderr	[Autorest]     - name: /Forecast/post/EnrollmentAccountForecast
      cmderr	[Autorest]     - name: /Forecast/post/ExternalBillingAccountForecast
      cmderr	[Autorest]     - name: /Forecast/post/ExternalSubscriptionForecast
      cmderr	[Autorest]     - name: /Forecast/post/InvoiceSectionForecast
      cmderr	[Autorest]     - name: /Forecast/post/ResourceGroupForecast
      cmderr	[Autorest]     - name: /Forecast/post/SubscriptionForecast
      cmderr	[Autorest]     - name: /Query/post/BillingAccountQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/BillingAccountQuery-Modern
      cmderr	[Autorest]     - name: /Query/post/BillingAccountQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/BillingAccountQueryGrouping-Modern
      cmderr	[Autorest]     - name: /Query/post/BillingProfileQuery-Modern
      cmderr	[Autorest]     - name: /Query/post/BillingProfileQueryGrouping-Modern
      cmderr	[Autorest]     - name: /Query/post/CustomerQuery-Modern
      cmderr	[Autorest]     - name: /Query/post/CustomerQueryGrouping-Modern
      cmderr	[Autorest]     - name: /Query/post/DepartmentQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/DepartmentQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/EnrollmentAccountQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/EnrollmentAccountQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/ExternalBillingAccountQueryList
      cmderr	[Autorest]     - name: /Query/post/ExternalSubscriptionsQuery
      cmderr	[Autorest]     - name: /Query/post/InvoiceSectionQuery-Modern
      cmderr	[Autorest]     - name: /Query/post/InvoiceSectionQueryGrouping-Modern
      cmderr	[Autorest]     - name: /Query/post/ManagementGroupQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/ManagementGroupQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/ResourceGroupQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/ResourceGroupQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/SubscriptionQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/SubscriptionQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Views/put/CreateOrUpdatePrivateView
      cmderr	[Autorest]     - name: /Views/put/ResourceGroupCreateOrUpdateView
      cmderr	[Autorest]     - name: /Views/get/PrivateView
      cmderr	[Autorest]     - name: /Views/get/PrivateViewList
      cmderr	[Autorest]     - name: /Views/get/ResourceGroupView
      cmderr	[Autorest]     - name: /Views/get/ResourceGroupViewList
      cmderr	[Autorest]     - name: /Views/delete/DeletePrivateView
      cmderr	[Autorest]     - name: /Views/delete/ResourceGroupDeleteView
      cmderr	[Autorest] --------------------------------------------------------
    • ️✔️costmanagement [View full logs]  [Preview Azure CLI Changes]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from 17ebcee3c21d0c1fb14a197c05f41856f1951269. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] /home/vsts/work/1/s/azure-resource-manager-schemas/generator/specs.ts:29
      cmderr	[generateScript.sh]         throw new Error(`Unable to find readme '${readme}' in specs repo`);
      cmderr	[generateScript.sh]               ^
      cmderr	[generateScript.sh] Error: Unable to find readme '/home/vsts/work/1/s/azure-resource-manager-schemas_tmp/schm_azspc/specification/EnterpriseKnowledgeGraph/resource-manager/readme.md' in specs repo
      cmderr	[generateScript.sh]     at Object.validateAndReturnReadmePath (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/specs.ts:29:15)
      cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/cmd/generateall.ts:48:24
      error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
      warn	Skip package processing as generation is failed
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @weidongxu-microsoft
    Copy link
    Member

    Please confirm 2020-06 is online.

    @magesh-jambulingam
    Copy link
    Author

    Please confirm 2020-06 is online.

    Yes, It's Online. Kindly approve the PR

    @weidongxu-microsoft
    Copy link
    Member

    weidongxu-microsoft commented Aug 18, 2021

    Given the incident below I will need all SDK owner to sign off this PR.
    @qiaozha
    @msyyc
    @ArcturusZhang

    Quote from 2021 June email

    Yeah I am in same boat as customer but went through the pain of reading our cli code.
    Problem is that the latest version of the sdk, query does not function due to versioning issue.
    
    q = cost_client.query.usage("subscriptions/4aaa645c-5ae2-4ae9-a17a-84b9023bc56a", QueryDefinition(
    type = "Useage",
    timeframe = "TheLastMonth"
    ))
    
    
    It fails with error
    azure.core.exceptions.ResourceNotFoundError: (InvalidResourceType) The resource type 'Query' could not be found in the namespace 'Microsoft.CostManagement' for api version '2020-06-01'. The supported api-versions are '2018-05-31,2018-08-31,2018-08-01-preview,2018-10-01-preview,2018-12-01-preview,2019-01-01,2019-03-01-preview,2019-04-01-preview,2019-05-01-preview,2019-10-01,2019-11-01'.
    

    @qiaozha
    Copy link
    Member

    qiaozha commented Aug 20, 2021

    no js SDK generation was found in these PR. @magesh-jambulingam Do you not want the JS/TS SDK for cost management ?

    Copy link
    Member

    @ArcturusZhang ArcturusZhang left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    No Go Track 2 SDK generated for this RP yet

    Copy link
    Member

    @ArcturusZhang ArcturusZhang left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    No Go Track 2 SDK generated for this RP yet. Approved

    @msyyc
    Copy link
    Member

    msyyc commented Aug 23, 2021

    approved for python

    @weidongxu-microsoft
    Copy link
    Member

    OK for Java.

    @ghost
    Copy link

    ghost commented Sep 12, 2021

    Hi, @magesh-jambulingam. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Sep 12, 2021
    @ghost ghost closed this Sep 27, 2021
    @ghost
    Copy link

    ghost commented Sep 27, 2021

    Hi, @magesh-jambulingam. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    This pull request was closed.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants