DiskRP swagger for 2021-04-01 #15665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytruong
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
|
Hi, @rytruong Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L37:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L265:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L301:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L334:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L386:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L426:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L609:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L645:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L678:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L730:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L770:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L980:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1022:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1061:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1106:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1307:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1349:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1388:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1424:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1575:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1620:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1668:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1716:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/disk.json#L1780:5 |
|
The new version has a new property 'promotionCode' in response that was not found in the old version. New: Microsoft.Compute/stable/2021-04-01/compute.json#L10073:7 Old: Microsoft.Compute/stable/2021-04-01/compute.json#L10073:7 |
️🔄LintDiff inProgress [Detail]
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-07-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-07-01", "details":"Error: Plugin prechecker reported failure." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"Error: Plugin prechecker reported failure." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
ghost
added
the
Swagger Generation Artifacts
|
rytruong
changed the title
|
Hi @rytruong, Your PR has some issues. Please fix the CI sequentially by following the order of
|
add autoKeyRotationError property and example
…uong/azure-rest-api-specs into dev/rytruong/swagger_diskrp
|
NewApiVersionRequired reason: |
This was referenced Aug 17, 2021
Closed
11 tasks
chetmaddula
reviewed
Sep 2, 2021
| "autoKeyRotationError": { | ||
| "readOnly": true, | ||
| "$ref": "#/definitions/ApiError", | ||
| "description": "The error that was encountered during auto-key rotation. If an error is present, then auto-key rotation will not be attempted until the error on this disk encryption set is fixed." |
There was a problem hiding this comment.
@parkhyukjun89 "until the error on disk encryption set is fixed" does customer need to do something to tell that the error is fixed?
There was a problem hiding this comment.
No. Customers can simply do a PUT/PATCH to fix the issue and pipeline will clear this property once it is validated.
chetmaddula
reviewed
Sep 3, 2021
| "createOption": "Empty" | ||
| }, | ||
| "diskSizeGB": 200, | ||
| "networkAccessPolicy": "AllowPrivate", |
There was a problem hiding this comment.
nit: set publicNetworkAccess as Disabled here and show the same in response.
chetmaddula
approved these changes
Sep 3, 2021
vikramd-ms
approved these changes
Sep 3, 2021
|
hi @ArcturusZhang could you confirm impact to Go SDK? Thanks. |
|
approved for Python breaking change |
ArcturusZhang
added
the
Approved-SdkBreakingChange-Go
|
Something is wrong in the breaking change pipeline, confirming with the owner right now |
JeffreyRichter
added
the
Approved-BreakingChange
added the frozen and activeSASFrozen disk states
ArcturusZhang
approved these changes
Sep 9, 2021
This was referenced Sep 9, 2021
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Sep 10, 2021
…into add_endpoint * 'main' of https://github.com/Azure/azure-rest-api-specs: (5079 commits) Add Microsoft.ExtendedLocation [CustomLocation] 2021-08-15 stable API Version (Azure#15967) Updated SKU property to be read only (Azure#15965) Add Microsoft.Communication.UserDisconnected Event (Azure#15870) Add collection APIs (Azure#15221) [Cognitive Services - Personalizer] v1.1-preview.2 (Azure#15699) Adding default error response & updating basePath (Azure#15784) Update readme and readme.python (Azure#15973) add synapse batch tag package-composite-v1 (Azure#15974) Microsoft.BareMetalInfrastructure: add stable API version 2021-08-09 (Azure#15680) change readme.go.md template to track 2 (Azure#15972) [CosmosDB] Adding apiVersion 2021-07-01-preview (Azure#14817) Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954) DiskRP swagger for 2021-04-01 (Azure#15665) Use IncidentSeverity in IncidentInfo (Azure#15762) Add stable API version "2021-09-01" (Azure#15897) add-purview-typescript-file (Azure#15948) Swagger Completeness for Microsoft.Authorization (Azure#15253) [Hub Generated] Review request for Microsoft.Aadiam to add version preview/2020-03-01-preview and stable/2020-03-01 (Azure#15861) Add swagger for missing CheckPolicyRestrictions API version (Azure#15888) Add Red Hat OpenShift 2021-09-01-preview (Azure#15616) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET SDK PR: Azure/azure-sdk-for-net#23612
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.