Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 #15881

Conversation

ayfathim
Copy link
Contributor

@ayfathim ayfathim commented Sep 1, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Summary:
We are adding new API version( 2021-08-01) in recoveryservices, recoveryservicesbackup folder, since this version is added recently in recoveryservicessiterecovery folder.
This API version change is being made, to make it S360 Compliant.
There is no additional change in this PR.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ayfathim Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 1, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 1, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️⌛[Staging] SDK Breaking Change Tracking pending [Detail]
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3399816. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/recoveryservicesbackup/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.RecoveryServices.Backup [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3399816. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] opencensus-ext-azure 1.1.0 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] azure-identity 1.7.0 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-recoveryservicesbackup [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3399816. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-recoveryservicesbackup [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model AzureSqlProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureVmWorkloadSQLDatabaseProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureVmWorkloadSAPHanaDatabaseProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureVmWorkloadSAPAseDatabaseProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model BackupResourceVaultConfig has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model MabFileFolderProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureSqlProtectionPolicy has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureVmWorkloadProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model ProtectionPolicy has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureIaaSVMProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureIaaSClassicComputeVMProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model GenericProtectionPolicy has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureVmWorkloadProtectionPolicy has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureFileshareProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model MabProtectionPolicy has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureIaaSComputeVMProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model ProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureIaaSVMProtectionPolicy has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureFileShareProtectionPolicy has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model GenericProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model AzureFileshareProtectedItemAutoGenerated has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Model DPMProtectedItem has a new parameter resource_guard_operation_requests
      info	[Changelog]   - Added operation group ResourceGuardProxyOperations
      info	[Changelog]   - Added operation group BackupResourceStorageConfigsNonCRROperations
      info	[Changelog]   - Added operation group ResourceGuardProxiesOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation SecurityPINsOperations.get has a new signature
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3399816. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-10-19 07:00:09 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-recoveryservicesbackup;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-10-19 07:00:09 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-10-19 07:00:09 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.38 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/recoveryservicesbackup/azure-resourcemanager-recoveryservicesbackup --java.namespace=com.azure.resourcemanager.recoveryservicesbackup   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/recoveryservicesbackup/resource-manager/readme.md
      cmderr	[generate.py] 2021-10-19 07:00:59 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-recoveryservicesbackup
      cmderr	[generate.py] 2021-10-19 07:00:59 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-10-19 07:00:59 INFO [POM][Skip] pom already has module azure-resourcemanager-recoveryservicesbackup
      cmderr	[generate.py] 2021-10-19 07:00:59 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-10-19 07:00:59 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-10-19 07:00:59 INFO [POM][Skip] pom already has module sdk/recoveryservicesbackup
      cmderr	[generate.py] 2021-10-19 07:00:59 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-recoveryservicesbackup [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-10-19 07:03:13 DEBUG Got artifact_id: azure-resourcemanager-recoveryservicesbackup
      cmderr	[Inst] 2021-10-19 07:03:13 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-10-19 07:03:13 DEBUG Got artifact: azure-resourcemanager-recoveryservicesbackup-1.0.0-beta.2-javadoc.jar
      cmderr	[Inst] 2021-10-19 07:03:13 DEBUG Got artifact: azure-resourcemanager-recoveryservicesbackup-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-10-19 07:03:13 DEBUG Match jar package: azure-resourcemanager-recoveryservicesbackup-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-10-19 07:03:13 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15881/azure-sdk-for-java/azure-resourcemanager-recoveryservicesbackup/azure-resourcemanager-recoveryservicesbackup-1.0.0-beta.2.jar\" -o azure-resourcemanager-recoveryservicesbackup-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-recoveryservicesbackup -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-recoveryservicesbackup-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3399816. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️recoveryservices/mgmt/2021-01-01/backup [View full logs]  [Release SDK Changes]
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New field `ResourceGuardOperationRequests` in struct `AzureVMWorkloadSAPAseDatabaseProtectedItem`
      info	[Changelog] - New field `ResourceGuardOperationRequests` in struct `MabFileFolderProtectedItem`
      info	[Changelog] - New field `ResourceGuardOperationRequests` in struct `AzureIaaSVMProtectedItem`
      info	[Changelog] - New field `ResourceGuardOperationRequests` in struct `AzureFileshareProtectedItem`
      info	[Changelog] - New field `ResourceGuardOperationRequests` in struct `AzureVMWorkloadSAPHanaDatabaseProtectedItem`
      info	[Changelog] - New field `ResourceGuardOperationRequests` in struct `AzureVMWorkloadProtectedItem`
      info	[Changelog] - New field `ResourceGuardOperationRequests` in struct `AzureIaaSComputeVMProtectedItem`
      info	[Changelog] - New field `IdentityInfo` in struct `IaasVMRestoreWithRehydrationRequest`
      info	[Changelog] - New field `IdentityBasedRestoreDetails` in struct `IaasVMRestoreWithRehydrationRequest`
      info	[Changelog] - New field `IdentityBasedRestoreDetails` in struct `IaasVMRestoreRequest`
      info	[Changelog] - New field `IdentityInfo` in struct `IaasVMRestoreRequest`
      info	[Changelog] - New field `ResourceGuardOperationRequests` in struct `AzureVMWorkloadSQLDatabaseProtectedItem`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 19 additive change(s).
      info	[Changelog]
    • ️✔️recoveryservices/mgmt/2020-12-01/backup [View full logs
      info	[Changelog] This is a new package
    • ️✔️recoveryservices/mgmt/2020-02-02/backup [View full logs
      info	[Changelog] No exported changes
    • ️✔️recoveryservices/mgmt/2019-06-15/backup [View full logs
      info	[Changelog] No exported changes
    • ️✔️recoveryservices/mgmt/2019-05-13/backup [View full logs
      info	[Changelog] No exported changes
    • ️✔️recoveryservices/mgmt/2017-07-01/backup [View full logs
      info	[Changelog] This is a new package
    • ️✔️recoveryservices/mgmt/2016-12-01/backup [View full logs
      info	[Changelog] No exported changes
    • ️✔️recoveryservices/mgmt/2016-06-01/backup [View full logs
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3399816. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/recoveryservicesbackup/resource-manager/readme.md
    • ️✔️@azure/arm-recoveryservicesbackup [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/recoveryServicesBackupClient.js → ./dist/arm-recoveryservicesbackup.js...
      cmderr	[npmPack] created ./dist/arm-recoveryservicesbackup.js in 1.3s
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3399816. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️recoveryservicesbackup [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ayfathim, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @pratimaupadhyay02
    Copy link
    Contributor

    Hi @ayfathim . Please modify the readme to include 2018-12-20 version in the latest package like below.
    "### Tag: package-2021-07

    These settings apply only when --tag=package-2021-07 is specified on the command line.

    input-file:
      - Microsoft.RecoveryServices/stable/2021-07-01/bms.json
      - Microsoft.RecoveryServices/stable/2018-12-20/bms.json

    @ayfathim
    Copy link
    Contributor Author

    ayfathim commented Sep 1, 2021

    /azp run unifiedPipeline

    1 similar comment
    @ayfathim
    Copy link
    Contributor Author

    ayfathim commented Sep 1, 2021

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    1 similar comment
    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @openapi-workflow-bot
    Copy link

    Hi, @ayfathim your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @pratimaupadhyay02
    Copy link
    Contributor

    Reviewed from RecoveryServices-backup end

    @filizt
    Copy link
    Contributor

    filizt commented Sep 2, 2021

    Please fill the changelog section above. Also, add the summary of the changes in this PR (e.g.: adding a new route or a new resource type, etc).

    @ayfathim
    Copy link
    Contributor Author

    ayfathim commented Sep 2, 2021

    @filizt : I have added a summary above. Basically there is no change, except new version being introduced, to make it s360 compliant.

    Summary:
    We are adding new API version( 2021-08-01) in recoveryservices, recoveryservicesbackup folder, since this version is added recently in recoveryservicessiterecovery folder.
    This API version change is being made, to make it S360 Compliant.
    There is no additional change in this PR.

    @filizt
    Copy link
    Contributor

    filizt commented Sep 3, 2021

    No API changes review from 2021-07-01 version.

    @filizt filizt added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 3, 2021
    @ghost
    Copy link

    ghost commented Sep 19, 2021

    Hi, @ayfathim. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Sep 19, 2021
    @ayfathim
    Copy link
    Contributor Author

    ARM Manifest deployment for the new-version will complete this week. Post that we will merge this PR

    @ghost ghost removed the no-recent-activity label Sep 20, 2021
    @ayfathim ayfathim changed the title <Do not Merge>[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 Sep 22, 2021
    @qwordy qwordy merged commit 3399816 into Azure:main Sep 24, 2021
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Sep 24, 2021
    Hardell pushed a commit to Hardell/azure-rest-api-specs that referenced this pull request Sep 27, 2021
    …version stable/2021-08-01 (Azure#15881)
    
    * Adds base for updating Microsoft.RecoveryServices from version stable/2021-07-01 to version 2021-08-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Fixing readme file
    @RAY-316
    Copy link
    Contributor

    RAY-316 commented Oct 19, 2021

    /azp run

    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    …version stable/2021-08-01 (Azure#15881)
    
    * Adds base for updating Microsoft.RecoveryServices from version stable/2021-07-01 to version 2021-08-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Fixing readme file
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ReviewedFromRecoveryServices-backup
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants