[Azure Maps] Geolocation: swagger improvement for SDK generation [Hub Generated] #16030

alankashiwa · 2021-09-14T09:59:40Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- To improve swagger for generated clients and address some issues from this review in ApiView
When are you targeting to deploy the new service/feature to public regions? Services already deployed.
When do you expect to publish the swagger? ASAP
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published. No data-plane SDKs are onboarded yet, so no refresh is required.

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further questions about AME onboarding or validation tools, please view the FAQ.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

openapi-workflow-bot · 2021-09-14T09:59:42Z

Hi, @alankashiwa Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-09-14T09:59:43Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-09-14T09:59:45Z

Swagger Validation Report

️❌BreakingChange: 98 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.0)
- current:Creator/preview/2.0 compared with base:Creator/preview/2.0
- current:preview/1.0/common.json compared with base:preview/1.0/common.json
- current:preview/1.0/spatial.json compared with base:preview/1.0/spatial.json
- current:preview/1.0/elevation.json compared with base:preview/1.0/elevation.json
- current:preview/1.0/geolocation.json compared with base:preview/1.0/geolocation.json
- current:preview/1.0/render.json compared with base:preview/1.0/render.json
- current:preview/2.0/render.json compared with base:preview/2.0/render.json
- current:preview/2.1/render.json compared with base:preview/2.1/render.json
- current:preview/1.0/route.json compared with base:preview/1.0/route.json
- current:preview/1.0/search.json compared with base:preview/1.0/search.json
- current:preview/1.0/timezone.json compared with base:preview/1.0/timezone.json
- current:preview/1.0/traffic.json compared with base:preview/1.0/traffic.json
- current:preview/1.0/weather.json compared with base:preview/1.0/weather.json

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` 1002 - ProtocolNoLongerSupported	The new version does not support 'Https' as a protocol. Old: Common/preview/1.0/common.json#L15:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'TextFormat' removed or renamed? New: Common/preview/1.0/common.json#L523:3 Old: Common/preview/1.0/common.json#L535:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SpatialApiVersion' removed or renamed? New: Creator/preview/1.0/spatial.json#L51:3 Old: Creator/preview/1.0/spatial.json#L51:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResponseFormat' removed or renamed? New: Creator/preview/1.0/spatial.json#L51:3 Old: Creator/preview/1.0/spatial.json#L51:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ElevationApiVersion' removed or renamed? New: DEM/preview/1.0/elevation.json#L44:3 Old: DEM/preview/1.0/elevation.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResponseFormat' removed or renamed? New: DEM/preview/1.0/elevation.json#L44:3 Old: DEM/preview/1.0/elevation.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'GeolocationApiVersion' removed or renamed? New: Geolocation/preview/1.0/geolocation.json#L44:3 Old: Geolocation/preview/1.0/geolocation.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResponseFormat' removed or renamed? New: Geolocation/preview/1.0/geolocation.json#L44:3 Old: Geolocation/preview/1.0/geolocation.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'RenderApiVersion' removed or renamed? New: Render/preview/1.0/render.json#L44:3 Old: Render/preview/1.0/render.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'TextFormat' removed or renamed? New: Render/preview/1.0/render.json#L44:3 Old: Render/preview/1.0/render.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'RenderApiVersionV2' removed or renamed? New: Render/preview/2.0/render.json#L44:3 Old: Render/preview/2.0/render.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'RenderApiVersionV2' removed or renamed? New: Render/preview/2.1/render.json#L44:3 Old: Render/preview/2.1/render.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'RouteApiVersion' removed or renamed? New: Route/preview/1.0/route.json#L44:3 Old: Route/preview/1.0/route.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'TextFormat' removed or renamed? New: Route/preview/1.0/route.json#L44:3 Old: Route/preview/1.0/route.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SearchApiVersion' removed or renamed? New: Search/preview/1.0/search.json#L44:3 Old: Search/preview/1.0/search.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'TextFormat' removed or renamed? New: Search/preview/1.0/search.json#L44:3 Old: Search/preview/1.0/search.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'TimezoneApiVersion' removed or renamed? New: Timezone/preview/1.0/timezone.json#L44:3 Old: Timezone/preview/1.0/timezone.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResponseFormat' removed or renamed? New: Timezone/preview/1.0/timezone.json#L44:3 Old: Timezone/preview/1.0/timezone.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'TrafficApiVersion' removed or renamed? New: Traffic/preview/1.0/traffic.json#L44:3 Old: Traffic/preview/1.0/traffic.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'TextFormat' removed or renamed? New: Traffic/preview/1.0/traffic.json#L44:3 Old: Traffic/preview/1.0/traffic.json#L44:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResponseFormat' removed or renamed? New: Weather/preview/1.0/weather.json#L43:3 Old: Weather/preview/1.0/weather.json#L43:3
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Elevation_GetDataForPoints' to 'GetDataForPoints'. This will impact generated code. New: DEM/preview/1.0/elevation.json#L57:7 Old: DEM/preview/1.0/elevation.json#L57:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Elevation_PostDataForPoints' to 'PostDataForPoints'. This will impact generated code. New: DEM/preview/1.0/elevation.json#L102:7 Old: DEM/preview/1.0/elevation.json#L102:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Elevation_GetDataForPolyline' to 'GetDataForPolyline'. This will impact generated code. New: DEM/preview/1.0/elevation.json#L145:7 Old: DEM/preview/1.0/elevation.json#L145:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Elevation_PostDataForPolyline' to 'PostDataForPolyline'. This will impact generated code. New: DEM/preview/1.0/elevation.json#L198:7 Old: DEM/preview/1.0/elevation.json#L198:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Elevation_GetDataForBoundingBox' to 'GetDataForBoundingBox'. This will impact generated code. New: DEM/preview/1.0/elevation.json#L249:7 Old: DEM/preview/1.0/elevation.json#L249:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Geolocation_GetIPToLocationPreview' to 'GetLocation'. This will impact generated code. New: Geolocation/preview/1.0/geolocation.json#L57:7 Old: Geolocation/preview/1.0/geolocation.json#L57:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Render_GetMapStaticImage' to 'GetMapStaticImage'. This will impact generated code. New: Render/preview/1.0/render.json#L165:7 Old: Render/preview/1.0/render.json#L165:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Render_GetMapTile' to 'GetMapTile'. This will impact generated code. New: Render/preview/1.0/render.json#L331:7 Old: Render/preview/1.0/render.json#L331:7
`❌` 1008 - ModifiedOperationId	The operation id has been changed from 'Render_GetMapStateTilePreview' to 'GetMapStateTile'. This will impact generated code. New: Render/preview/1.0/render.json#L483:7 Old: Render/preview/1.0/render.json#L483:7

Rule	Message
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'AliasApiVersionV2' removed or renamed? New: Creator/preview/2.0/alias.json#L51:3 Old: Creator/preview/2.0/alias.json#L51:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'DataApiVersionV2' removed or renamed? New: Creator/preview/2.0/alias.json#L51:3 Old: Creator/preview/2.0/alias.json#L51:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'DatasetApiVersionV2' removed or renamed? New: Creator/preview/2.0/alias.json#L51:3 Old: Creator/preview/2.0/alias.json#L51:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ConversionApiVersionV2' removed or renamed? New: Creator/preview/2.0/alias.json#L51:3 Old: Creator/preview/2.0/alias.json#L51:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'FeaturestateApiVersionV2' removed or renamed? New: Creator/preview/2.0/alias.json#L51:3 Old: Creator/preview/2.0/alias.json#L51:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'TilesetApiVersionV2' removed or renamed? New: Creator/preview/2.0/alias.json#L51:3 Old: Creator/preview/2.0/alias.json#L51:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'WFSApiVersionV2' removed or renamed? New: Creator/preview/2.0/alias.json#L51:3 Old: Creator/preview/2.0/alias.json#L51:3

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Feedback/preview/1.0/feedback.json#L216
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Mobility/preview/1.0/mobility.json#L1464
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Mobility/preview/1.0/mobility.json#L1491
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Route/preview/1.0/route.json#L1813
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Route/preview/1.0/route.json#L1855
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Route/preview/1.0/route.json#L1878
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Route/preview/1.0/route.json#L1969
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Search/preview/1.0/search.json#L2075
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Spatial/preview/1.0/spatial.json#L1095
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Spatial/preview/1.0/spatial.json#L1118
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Spatial/preview/1.0/spatial.json#L1148
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Spatial/preview/1.0/spatial.json#L1175
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Dataset_Create' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Dataset/preview/2.0/dataset.json#L196
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Conversion_Convert' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: DwgConversion/preview/2.0/dwgconversion.json#L203
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Tileset_Create' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Tileset/preview/2.0/tileset.json#L216
⚠️ R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Property name: type Location: FeatureState/preview/2.0/featurestate.json#L827
⚠️ R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Property name: type Location: Search/preview/1.0/search.json#L3448
⚠️ R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Property name: geometryType Location: WFS/preview/2.0/wfs.json#L887
⚠️ R2064 - LROStatusCodesReturnTypeSchema	200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'FeatureState_PutStateset', Response code: '200' Location: Creator/preview/2.0/featurestate.json#L226
⚠️ R2064 - LROStatusCodesReturnTypeSchema	200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'FeatureState_UpdateStates', Response code: '200' Location: Creator/preview/2.0/featurestate.json#L327
⚠️ R2064 - LROStatusCodesReturnTypeSchema	200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'FeatureState_PutStateset', Response code: '200' Location: FeatureState/preview/2.0/featurestate.json#L325
⚠️ R2064 - LROStatusCodesReturnTypeSchema	200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'FeatureState_UpdateStates', Response code: '200' Location: FeatureState/preview/2.0/featurestate.json#L465

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-09-14T09:59:46Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-maps-creator - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-elevation - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-geolocation - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-render - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-route - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-search - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-timezone - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-traffic - first release
️✔️azure-sdk-for-python-track2 - track2_azure-maps-weather - first release

️⌛ azure-sdk-for-python-track2 pending [Detail]

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from e07d790. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
warn		specification/maps/data-plane/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e07d790. SDK Automation 14.0.0

Only show 14 items here, please refer to log for details.

command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Traffic/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/maps/data-plane/Weather/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Azure.Maps.Creator [View full logs] [Release SDK Changes]
️✔️Azure.Maps.Elevation [View full logs] [Release SDK Changes]
️✔️Azure.Maps.Geolocation [View full logs] [Release SDK Changes]
️✔️Azure.Maps.Render [View full logs] [Release SDK Changes]
️✔️Azure.Maps.Route [View full logs] [Release SDK Changes]
️✔️Azure.Maps.Search [View full logs] [Release SDK Changes]
️✔️Azure.Maps.Timezone [View full logs] [Release SDK Changes]
️✔️Azure.Maps.Traffic [View full logs] [Release SDK Changes]
️✔️Azure.Maps.Weather [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-09-14T10:03:32Z

Hi @alankashiwa, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

alankashiwa · 2021-09-15T06:26:18Z

/azp run

azure-pipelines · 2021-09-15T06:26:43Z

Azure Pipelines successfully started running 1 pipeline(s).

tjprescott

Overall looks great. Two enums I would recommend you keep modelAsString true and one rename.

specification/maps/data-plane/Common/preview/1.0/common.json

alankashiwa · 2021-09-16T06:12:53Z

@tjprescott I've made the corresponding changes. If you are okay with those, we are ready to merge :)

… Generated] (Azure#16030) * Geolocation: Use user-friendly key and filename for x-ms-examples * Geolocation: Use client name ipAddress for parameter ip * Common: Set TextFormat/ResponseFormat default to json * All: Remove operationId prefix for swagger except Creator * Geolocation: Rename method GetIPToLocationPreview to GetLocation * All: Rename [Service]ApiVersion to ApiVersion * Common: Use client name mapsClientId for x-ms-client-id * Remove -Preview suffix * Common: Remove x-ms-parameterized-host/schemes/cosumes * Common: TextFormat->ResponseFormat, ResponseFormat->JsonFormat * Common: Model GeojsonObject as a closed enum * Common: Reset JsonFormat/ResponseFormat modelAsString=true * Common: Rename mapsClientId as clientId

alankashiwa added 7 commits September 14, 2021 13:49

Geolocation: Use user-friendly key and filename for x-ms-examples

fe7a6da

Geolocation: Use client name ipAddress for parameter ip

530fdb6

Common: Set TextFormat/ResponseFormat default to json

8b6e33b

All: Remove operationId prefix for swagger except Creator

b2d393d

Geolocation: Rename method GetIPToLocationPreview to GetLocation

d58d4f3

All: Rename [Service]ApiVersion to ApiVersion

6cc6b8b

Common: Use client name mapsClientId for x-ms-client-id

04cf537

alankashiwa changed the title ~~[Hub Generated] Review request for Geolocation to add version preview/1.0~~ [Hub Generated] Azure Maps Geolocation: swagger improvement for SDK generation Sep 14, 2021

openapi-workflow-bot bot added the FixS360 label Sep 14, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Sep 14, 2021

alankashiwa added 3 commits September 15, 2021 16:05

Common: Remove x-ms-parameterized-host/schemes/cosumes

f99d6ea

Common: TextFormat->ResponseFormat, ResponseFormat->JsonFormat

f88b0b1

Common: Model GeojsonObject as a closed enum

eadc4f9

alankashiwa marked this pull request as ready for review September 15, 2021 08:39

openapi-assignment-bot bot assigned tjprescott Sep 15, 2021

tjprescott requested changes Sep 15, 2021

View reviewed changes

tjprescott added FalsePositive-BreakingChange Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels Sep 15, 2021

alankashiwa added 2 commits September 16, 2021 09:12

Common: Reset JsonFormat/ResponseFormat modelAsString=true

b809b38

Common: Rename mapsClientId as clientId

f484842

alankashiwa closed this Sep 16, 2021

alankashiwa reopened this Sep 16, 2021

tjprescott approved these changes Sep 16, 2021

View reviewed changes

tjprescott merged commit e07d790 into Azure:main Sep 16, 2021

alankashiwa deleted the maps-geolocation-improvement-for-sdk branch September 17, 2021 00:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Azure Maps] Geolocation: swagger improvement for SDK generation [Hub Generated] #16030

[Azure Maps] Geolocation: swagger improvement for SDK generation [Hub Generated] #16030

alankashiwa commented Sep 14, 2021 •

edited

Loading

openapi-workflow-bot bot commented Sep 14, 2021

openapi-workflow-bot bot commented Sep 14, 2021

openapi-pipeline-app bot commented Sep 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Sep 14, 2021

alankashiwa commented Sep 15, 2021

azure-pipelines bot commented Sep 15, 2021

tjprescott left a comment

alankashiwa commented Sep 16, 2021

[Azure Maps] Geolocation: swagger improvement for SDK generation [Hub Generated] #16030

[Azure Maps] Geolocation: swagger improvement for SDK generation [Hub Generated] #16030

Conversation

alankashiwa commented Sep 14, 2021 • edited Loading

Changelog

Contribution checklist:

Breaking Change Review Checklist

openapi-workflow-bot bot commented Sep 14, 2021

openapi-workflow-bot bot commented Sep 14, 2021

openapi-pipeline-app bot commented Sep 14, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 14, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Sep 14, 2021

alankashiwa commented Sep 15, 2021

azure-pipelines bot commented Sep 15, 2021

tjprescott left a comment

Choose a reason for hiding this comment

alankashiwa commented Sep 16, 2021

alankashiwa commented Sep 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2021 •

edited

Loading