Add GET endpoint at /config/authsettingsv2 for Microsoft.Web #16427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ConnorMcMahon Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response in the GET collection operation 'AppServicePlans_ListVnets' does not match the response definition in the individual GET operation 'AppServicePlans_GetVnetFromServerFarm' . Location: Microsoft.Web/stable/2021-03-01/AppServicePlans.json#L884 |
| Per the Noun_Verb convention for Operation Ids, the noun 'DeletedWebApps' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/DeletedWebApps.json#L106 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Diagnostics.json#L281 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Diagnostics.json#L334 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Diagnostics.json#L954 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Diagnostics.json#L1014 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Recommendations.json#L102 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Recommendations.json#L405 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Recommendations.json#L712 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L118 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L161 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L206 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L267 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L313 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L375 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L432 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L488 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L558 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L608 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L660 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L718 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L781 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L844 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L901 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L955 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1009 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1066 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1125 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1206 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1267 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @ConnorMcMahon, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Oct 15, 2021
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
This was referenced Oct 15, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weidongxu-microsoft
approved these changes
Oct 18, 2021
weidongxu-microsoft
pushed a commit
that referenced
this pull request
Jan 6, 2022
* Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (#15917) * Introduce enterpriseGradeCdnStatus to StaticSites.json (#16080) * Update StaticSites.json * Update StaticSites.json * Onedeploy API swapper spec (#15985) * Onedeploy API swapper spec * Adding onedeploy custom keyword * Formatting onedeploy api indentation Formatting onedeploy api indentation * prettifier Co-authored-by: Calvin Chan <calvinch4n@gmail.com> * Fix status codes for syncfunctiontriggers (#16413) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (#16427) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web * Fix duplicate operation ids * Swagger for ASD Transfer out (#16000) * Add domain transfer out to swagger * Prettifier * Add 202 response for webapp restart * Add certificate listHostnameBindingsOfCertificate * Formatting * Swagger for listHostnameBindings endpoint (#16516) * Swagger for listHostnameBindings endpoint * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (#15917) * ops Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * User/jennylaw/containerapp (#16657) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Add custom hostname sites endpoint (#16745) * Add custom hostname sites endpoint * Fix models * Swagger Fixes for Container App, KubeEnvironments spec (#16793) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger * Fix sercret read property * Prettier fix * Model fix * Prettier Fix #2 Co-authored-by: Jenny Lawrance <jennylaw@microsoft.com> * Add long running extension for restart (#16791) * Remove unused API from ANT95 swagger (#16901) * Address PR comments (#17019) * Fixing PR comments (#17127) * Remove Certificate Hostname bindings API (#17204) * Remove Certificate Hostname bindings API * Remove examples file as well Co-authored-by: mkarmark <mikarmar@microsoft.com> Co-authored-by: SatishRanjan <SatishRanjan@users.noreply.github.com> Co-authored-by: Calvin Chan <calvinch4n@gmail.com> Co-authored-by: Connor McMahon <comcmaho@microsoft.com> Co-authored-by: JennyLawrance <jennylaw@microsoft.com> Co-authored-by: Sanchit Mehta <sanchit.mehta602@gmail.com>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * Introduce enterpriseGradeCdnStatus to StaticSites.json (Azure#16080) * Update StaticSites.json * Update StaticSites.json * Onedeploy API swapper spec (Azure#15985) * Onedeploy API swapper spec * Adding onedeploy custom keyword * Formatting onedeploy api indentation Formatting onedeploy api indentation * prettifier Co-authored-by: Calvin Chan <calvinch4n@gmail.com> * Fix status codes for syncfunctiontriggers (Azure#16413) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (Azure#16427) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web * Fix duplicate operation ids * Swagger for ASD Transfer out (Azure#16000) * Add domain transfer out to swagger * Prettifier * Add 202 response for webapp restart * Add certificate listHostnameBindingsOfCertificate * Formatting * Swagger for listHostnameBindings endpoint (Azure#16516) * Swagger for listHostnameBindings endpoint * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * ops Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * User/jennylaw/containerapp (Azure#16657) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Add custom hostname sites endpoint (Azure#16745) * Add custom hostname sites endpoint * Fix models * Swagger Fixes for Container App, KubeEnvironments spec (Azure#16793) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger * Fix sercret read property * Prettier fix * Model fix * Prettier Fix Azure#2 Co-authored-by: Jenny Lawrance <jennylaw@microsoft.com> * Add long running extension for restart (Azure#16791) * Remove unused API from ANT95 swagger (Azure#16901) * Address PR comments (Azure#17019) * Fixing PR comments (Azure#17127) * Remove Certificate Hostname bindings API (Azure#17204) * Remove Certificate Hostname bindings API * Remove examples file as well Co-authored-by: mkarmark <mikarmar@microsoft.com> Co-authored-by: SatishRanjan <SatishRanjan@users.noreply.github.com> Co-authored-by: Calvin Chan <calvinch4n@gmail.com> Co-authored-by: Connor McMahon <comcmaho@microsoft.com> Co-authored-by: JennyLawrance <jennylaw@microsoft.com> Co-authored-by: Sanchit Mehta <sanchit.mehta602@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new GET API to the root of /authsettingsV2 to be more ARM compliant.